feat: make AbstractModuleService create method type-safe (#11216)

packages/modules/order/src/services/order-module-service.ts

@@ -663,13 +663,14 @@ export default class OrderModuleService
     data: OrderTypes.CreateOrderDTO[],
     sharedContext?: Context
   ): Promise<OrderTypes.OrderDTO[]>
-
+  // @ts-expect-error
   async createOrders(
     data: OrderTypes.CreateOrderDTO,
     sharedContext?: Context
   ): Promise<OrderTypes.OrderDTO>
 
   @InjectManager()
+  // @ts-expect-error
   async createOrders(
     data: OrderTypes.CreateOrderDTO[] | OrderTypes.CreateOrderDTO,
     @MedusaContext() sharedContext: Context = {}
@@ -814,11 +815,13 @@ export default class OrderModuleService
   async updateOrders(
     data: OrderTypes.UpdateOrderDTO[]
   ): Promise<OrderTypes.OrderDTO[]>
+  // @ts-expect-error
   async updateOrders(
     orderId: string,
     data: OrderTypes.UpdateOrderDTO,
     sharedContext?: Context
   ): Promise<OrderTypes.OrderDTO>
+  // @ts-expect-error
   async updateOrders(
     selector: Partial<OrderTypes.FilterableOrderProps>,
     data: OrderTypes.UpdateOrderDTO,
@@ -826,6 +829,7 @@ export default class OrderModuleService
   ): Promise<OrderTypes.OrderDTO[]>
 
   @InjectManager()
+  // @ts-expect-error
   async updateOrders(
     dataOrIdOrSelector:
       | OrderTypes.UpdateOrderDTO[]
@@ -891,9 +895,11 @@ export default class OrderModuleService
   createOrderLineItems(
     data: OrderTypes.CreateOrderLineItemForOrderDTO
   ): Promise<OrderTypes.OrderLineItemDTO[]>
+  // @ts-expect-error
   createOrderLineItems(
     data: OrderTypes.CreateOrderLineItemForOrderDTO[]
   ): Promise<OrderTypes.OrderLineItemDTO[]>
+  // @ts-expect-error
   createOrderLineItems(
     orderId: string,
     items: OrderTypes.CreateOrderLineItemDTO[],
@@ -901,6 +907,7 @@ export default class OrderModuleService
   ): Promise<OrderTypes.OrderLineItemDTO[]>
 
   @InjectManager()
+  // @ts-expect-error
   async createOrderLineItems(
     orderIdOrData:
       | string
@@ -1012,11 +1019,13 @@ export default class OrderModuleService
   updateOrderLineItems(
     data: OrderTypes.UpdateOrderLineItemWithSelectorDTO[]
   ): Promise<OrderTypes.OrderLineItemDTO[]>
+  // @ts-expect-error
   updateOrderLineItems(
     selector: Partial<OrderTypes.FilterableOrderLineItemProps>,
     data: OrderTypes.UpdateOrderLineItemDTO,
     sharedContext?: Context
   ): Promise<OrderTypes.OrderLineItemDTO[]>
+  // @ts-expect-error
   updateOrderLineItems(
     lineItemId: string,
     data: Partial<OrderTypes.UpdateOrderLineItemDTO>,
@@ -1024,6 +1033,7 @@ export default class OrderModuleService
   ): Promise<OrderTypes.OrderLineItemDTO>
 
   @InjectManager()
+  // @ts-expect-error
   async updateOrderLineItems(
     lineItemIdOrDataOrSelector:
       | string
@@ -1229,13 +1239,15 @@ export default class OrderModuleService
     return await this.orderItemService_.update(toUpdate, sharedContext)
   }
 
-  // @ts-ignore
+  // @ts-expect-error
   async createOrderShippingMethods(
     data: OrderTypes.CreateOrderShippingMethodDTO
   ): Promise<OrderTypes.OrderShippingMethodDTO>
+  // @ts-expect-error
   async createOrderShippingMethods(
     data: OrderTypes.CreateOrderShippingMethodDTO[]
   ): Promise<OrderTypes.OrderShippingMethodDTO[]>
+  // @ts-expect-error
   async createOrderShippingMethods(
     orderId: string,
     methods: OrderTypes.CreateOrderShippingMethodDTO[],
@@ -1243,6 +1255,7 @@ export default class OrderModuleService
   ): Promise<OrderTypes.OrderShippingMethodDTO[]>
 
   @InjectManager()
+  // @ts-expect-error
   async createOrderShippingMethods(
     orderIdOrData:
       | string
@@ -1394,9 +1407,11 @@ export default class OrderModuleService
   async createOrderLineItemAdjustments(
     adjustments: OrderTypes.CreateOrderLineItemAdjustmentDTO[]
   ): Promise<OrderTypes.OrderLineItemAdjustmentDTO[]>
+  // @ts-expect-error
   async createOrderLineItemAdjustments(
     adjustment: OrderTypes.CreateOrderLineItemAdjustmentDTO
   ): Promise<OrderTypes.OrderLineItemAdjustmentDTO[]>
+  // @ts-expect-error
   async createOrderLineItemAdjustments(
     orderId: string,
     adjustments: OrderTypes.CreateOrderLineItemAdjustmentDTO[],
@@ -1404,6 +1419,7 @@ export default class OrderModuleService
   ): Promise<OrderTypes.OrderLineItemAdjustmentDTO[]>
 
   @InjectTransactionManager()
+  // @ts-expect-error
   async createOrderLineItemAdjustments(
     orderIdOrData:
       | string
@@ -1564,9 +1580,11 @@ export default class OrderModuleService
   async createOrderShippingMethodAdjustments(
     adjustments: OrderTypes.CreateOrderShippingMethodAdjustmentDTO[]
   ): Promise<OrderTypes.OrderShippingMethodAdjustmentDTO[]>
+  // @ts-expect-error
   async createOrderShippingMethodAdjustments(
     adjustment: OrderTypes.CreateOrderShippingMethodAdjustmentDTO
   ): Promise<OrderTypes.OrderShippingMethodAdjustmentDTO>
+  // @ts-expect-error
   async createOrderShippingMethodAdjustments(
     orderId: string,
     adjustments: OrderTypes.CreateOrderShippingMethodAdjustmentDTO[],
@@ -1574,6 +1592,7 @@ export default class OrderModuleService
   ): Promise<OrderTypes.OrderShippingMethodAdjustmentDTO[]>
 
   @InjectTransactionManager()
+  // @ts-expect-error
   async createOrderShippingMethodAdjustments(
     orderIdOrData:
       | string
@@ -1643,9 +1662,11 @@ export default class OrderModuleService
   createOrderLineItemTaxLines(
     taxLines: OrderTypes.CreateOrderLineItemTaxLineDTO[]
   ): Promise<OrderTypes.OrderLineItemTaxLineDTO[]>
+  // @ts-expect-error
   createOrderLineItemTaxLines(
     taxLine: OrderTypes.CreateOrderLineItemTaxLineDTO
   ): Promise<OrderTypes.OrderLineItemTaxLineDTO>
+  // @ts-expect-error
   createOrderLineItemTaxLines(
     orderId: string,
     taxLines:
@@ -1655,6 +1676,7 @@ export default class OrderModuleService
   ): Promise<OrderTypes.OrderLineItemTaxLineDTO[]>
 
   @InjectTransactionManager()
+  // @ts-expect-error
   async createOrderLineItemTaxLines(
     orderIdOrData:
       | string
@@ -1754,9 +1776,11 @@ export default class OrderModuleService
   createOrderShippingMethodTaxLines(
     taxLines: OrderTypes.CreateOrderShippingMethodTaxLineDTO[]
   ): Promise<OrderTypes.OrderShippingMethodTaxLineDTO[]>
+  // @ts-expect-error
   createOrderShippingMethodTaxLines(
     taxLine: OrderTypes.CreateOrderShippingMethodTaxLineDTO
   ): Promise<OrderTypes.OrderShippingMethodTaxLineDTO>
+  // @ts-expect-error
   createOrderShippingMethodTaxLines(
     orderId: string,
     taxLines:
@@ -1766,6 +1790,7 @@ export default class OrderModuleService
   ): Promise<OrderTypes.OrderShippingMethodTaxLineDTO[]>
 
   @InjectTransactionManager()
+  // @ts-expect-error
   async createOrderShippingMethodTaxLines(
     orderIdOrData:
       | string
@@ -1870,12 +1895,14 @@ export default class OrderModuleService
     sharedContext?: Context
   ): Promise<OrderTypes.ReturnDTO>
 
+  // @ts-expect-error
   async createReturns(
     data: OrderTypes.CreateOrderReturnDTO[],
     sharedContext?: Context
   ): Promise<OrderTypes.ReturnDTO[]>
 
   @InjectTransactionManager()
+  // @ts-expect-error
   async createReturns(
     data: OrderTypes.CreateOrderReturnDTO | OrderTypes.CreateOrderReturnDTO[],
     @MedusaContext() sharedContext?: Context
@@ -1900,12 +1927,14 @@ export default class OrderModuleService
     sharedContext?: Context
   ): Promise<OrderTypes.OrderClaimDTO>
 
+  // @ts-expect-error
   async createOrderClaims(
     data: OrderTypes.CreateOrderClaimDTO[],
     sharedContext?: Context
   ): Promise<OrderTypes.OrderClaimDTO[]>
 
   @InjectTransactionManager()
+  // @ts-expect-error
   async createOrderClaims(
     data: OrderTypes.CreateOrderClaimDTO | OrderTypes.CreateOrderClaimDTO[],
     @MedusaContext() sharedContext?: Context
@@ -1930,12 +1959,14 @@ export default class OrderModuleService
     sharedContext?: Context
   ): Promise<OrderTypes.OrderExchangeDTO>
 
+  // @ts-expect-error
   async createOrderExchanges(
     data: OrderTypes.CreateOrderExchangeDTO[],
     sharedContext?: Context
   ): Promise<OrderTypes.OrderExchangeDTO[]>
 
   @InjectTransactionManager()
+  // @ts-expect-error
   async createOrderExchanges(
     data:
       | OrderTypes.CreateOrderExchangeDTO
@@ -3537,12 +3568,13 @@ export default class OrderModuleService
     )
   }
 
-  // @ts-ignore
+  // @ts-expect-error
   updateReturnReasons(
     id: string,
     data: UpdateOrderReturnReasonDTO,
     sharedContext?: Context
   ): Promise<OrderReturnReasonDTO>
+  // @ts-expect-error
   updateReturnReasons(
     selector: FilterableOrderReturnReasonProps,
     data: Partial<UpdateOrderReturnReasonDTO>,
@@ -3550,6 +3582,7 @@ export default class OrderModuleService
   ): Promise<OrderReturnReasonDTO[]>
 
   @InjectManager()
+  // @ts-expect-error
   async updateReturnReasons(
     idOrSelector: string | FilterableOrderReturnReasonProps,
     data: UpdateOrderReturnReasonDTO,
@@ -3652,4 +3685,16 @@ export default class OrderModuleService
   ): Promise<void> {
     return await BundledActions.registerDelivery.bind(this)(data, sharedContext)
   }
+
+  @InjectManager()
+  // @ts-expect-error
+  async createReturnItems(
+    data: OrderTypes.CreateOrderReturnItemDTO,
+    sharedContext?: Context
+  ): Promise<OrderTypes.OrderReturnItemDTO> {
+    return super.createReturnItems(
+      data as unknown as OrderTypes.OrderReturnItemDTO,
+      sharedContext
+    )
+  }
 }