fix(framework): throw when middleware fails to register (#9211)

This commit is contained in:
Riqwan Thamir
2024-09-22 14:46:52 +02:00
committed by GitHub
parent ba14d4341f
commit 0bce09f0a2
@@ -10,6 +10,9 @@ import {
} from "express" } from "express"
import { readdir } from "fs/promises" import { readdir } from "fs/promises"
import { extname, join, parse, sep } from "path" import { extname, join, parse, sep } from "path"
import { configManager } from "../config"
import { logger } from "../logger"
import { authenticate, AuthType, errorHandler } from "./middlewares"
import { import {
GlobalMiddlewareDescriptor, GlobalMiddlewareDescriptor,
HTTP_METHODS, HTTP_METHODS,
@@ -25,9 +28,6 @@ import {
RouteHandler, RouteHandler,
RouteVerb, RouteVerb,
} from "./types" } from "./types"
import { authenticate, AuthType, errorHandler } from "./middlewares"
import { configManager } from "../config"
import { logger } from "../logger"
const log = ({ const log = ({
activityId, activityId,
@@ -486,11 +486,8 @@ class ApiRoutesLoader {
const absolutePath = join(this.#sourceDir, middlewareFilePath) const absolutePath = join(this.#sourceDir, middlewareFilePath)
try {
await import(absolutePath).then((import_) => { await import(absolutePath).then((import_) => {
const middlewaresConfig = import_.default as const middlewaresConfig = import_.default as MiddlewaresConfig | undefined
| MiddlewaresConfig
| undefined
if (!middlewaresConfig) { if (!middlewaresConfig) {
log({ log({
@@ -515,14 +512,6 @@ class ApiRoutesLoader {
this.#globalMiddlewaresDescriptor = descriptor this.#globalMiddlewaresDescriptor = descriptor
}) })
} catch (error) {
log({
activityId: this.#activityId,
message: `Failed to load middleware configuration in ${absolutePath}. Skipping middleware configuration.`,
})
return
}
} }
protected async createRoutesMap(): Promise<void> { protected async createRoutesMap(): Promise<void> {