fix(framework): throw when middleware fails to register (#9211)

This commit is contained in:
Riqwan Thamir authored and GitHub committed 2024-09-22 14:46:52 +02:00
1 parent ba14d4341f
commit 0bce09f0a2
1 file changed
+4 -15
@@ -10,6 +10,9 @@ import {
} from "express"
import { readdir } from "fs/promises"
import { extname, join, parse, sep } from "path"
import { configManager } from "../config"
import { logger } from "../logger"
import { authenticate, AuthType, errorHandler } from "./middlewares"
import {
GlobalMiddlewareDescriptor,
HTTP_METHODS,
@@ -25,9 +28,6 @@ import {
RouteHandler,
RouteVerb,
} from "./types"
import { authenticate, AuthType, errorHandler } from "./middlewares"
import { configManager } from "../config"
import { logger } from "../logger"
const log = ({
activityId,
@@ -486,11 +486,8 @@ class ApiRoutesLoader {
const absolutePath = join(this.#sourceDir, middlewareFilePath)
try {
await import(absolutePath).then((import_) => {
const middlewaresConfig = import_.default as
| MiddlewaresConfig
| undefined
const middlewaresConfig = import_.default as MiddlewaresConfig | undefined
if (!middlewaresConfig) {
log({
@@ -515,14 +512,6 @@ class ApiRoutesLoader {
this.#globalMiddlewaresDescriptor = descriptor
})
} catch (error) {
log({
activityId: this.#activityId,
message: `Failed to load middleware configuration in ${absolutePath}. Skipping middleware configuration.`,
})
return
}
}
protected async createRoutesMap(): Promise<void> {