fix: integration tests modules 2 (#6599)

Currently, if the v2 flag is not enabled it can lead to issues if the modules are part of the medusa config as they will get loaded anyway leading to issues if the migrations did not ran
2024-03-06 14:26:42 +01:00
parent f0ef0a8784
commit 0c9018eddc
4 changed files with 214 additions and 173 deletions
--- a/integration-tests/modules/tests/cart/store/cart.workflows.spec.ts
+++ b/integration-tests/modules/tests/cart/store/cart.workflows.spec.ts
@@ -22,7 +22,7 @@ import {
 import adminSeeder from "../../../../helpers/admin-seeder"
 import { medusaIntegrationTestRunner } from "medusa-test-utils"

-jest.setTimeout(50000)
+jest.setTimeout(200000)

 const env = { MEDUSA_FF_MEDUSA_V2: true }

--- a/integration-tests/modules/tests/link-modules/index.ts
+++ b/integration-tests/modules/tests/link-modules/index.ts
@@ -1,188 +1,228 @@
 import { initialize, runMigrations } from "@medusajs/link-modules"
 import { MedusaModule, ModuleJoinerConfig } from "@medusajs/modules-sdk"
+import { medusaIntegrationTestRunner } from "medusa-test-utils/dist"

 jest.setTimeout(5000000)

-const DB_HOST = process.env.DB_HOST
-const DB_USERNAME = process.env.DB_USERNAME
-const DB_PASSWORD = process.env.DB_PASSWORD
-const DB_NAME = process.env.DB_TEMP_NAME
-const DB_URL = `postgres://${DB_USERNAME}:${DB_PASSWORD}@${DB_HOST}/${DB_NAME}`
+medusaIntegrationTestRunner({
+  force_modules_migration: true,
+  testSuite: ({ dbConnection, getContainer }) => {
+    let DB_URL
+    let container
+    let links

-describe("Link Modules", () => {
-  let links
-  const linkDefinition: ModuleJoinerConfig[] = [
-    {
-      serviceName: "linkServiceName",
-      isLink: true,
-      databaseConfig: {
-        tableName: "linkTableName",
-        idPrefix: "prefix",
-        extraFields: {
-          extra_field: {
-            type: "integer",
-            defaultValue: "-1",
-          },
-          another_field: {
-            type: "string",
-            nullable: true,
-          },
-        },
-      },
-      relationships: [
+    beforeAll(async () => {
+      DB_URL = dbConnection.manager.connection.options.url
+      container = getContainer()
+
+      const linkDefinition: ModuleJoinerConfig[] = [
        {
-          serviceName: "moduleA",
-          primaryKey: "id",
-          foreignKey: "product_id",
-          alias: "product",
+          serviceName: "linkServiceName",
+          isLink: true,
+          databaseConfig: {
+            tableName: "linkTableName",
+            idPrefix: "prefix",
+            extraFields: {
+              extra_field: {
+                type: "integer",
+                defaultValue: "-1",
+              },
+              another_field: {
+                type: "string",
+                nullable: true,
+              },
+            },
+          },
+          relationships: [
+            {
+              serviceName: "moduleA",
+              primaryKey: "id",
+              foreignKey: "product_id",
+              alias: "product",
+            },
+            {
+              serviceName: "moduleB",
+              primaryKey: "id",
+              foreignKey: "inventory_item_id",
+              alias: "inventory",
+            },
+          ],
        },
-        {
-          serviceName: "moduleB",
-          primaryKey: "id",
-          foreignKey: "inventory_item_id",
-          alias: "inventory",
+      ]
+      const dbConfig = {
+        database: {
+          clientUrl: DB_URL,
        },
-      ],
-    },
-  ]
-  const dbConfig = {
-    database: {
-      clientUrl: DB_URL,
-    },
-  }
+      }

-  beforeAll(async () => {
-    jest.spyOn(MedusaModule, "getLoadedModules").mockImplementation((() => {
-      return [{ moduleA: [{}] }, { moduleB: [{}] }]
-    }) as any)
+      jest.spyOn(MedusaModule, "getLoadedModules").mockImplementation((() => {
+        return [{ moduleA: [{}] }, { moduleB: [{}] }]
+      }) as any)

-    await runMigrations({ options: dbConfig }, linkDefinition)
-    links = await initialize(dbConfig, linkDefinition)
-  })
-
-  afterAll(async () => {
-    jest.clearAllMocks()
-  })
-
-  it("Should insert values in a declared link", async function () {
-    // simple
-    await links.linkServiceName.create("modA_id", "modB_id")
-
-    // extra fields
-    await links.linkServiceName.create("123", "abc", {
-      extra_field: 333,
-      another_field: "value**",
+      await runMigrations({ options: dbConfig }, linkDefinition)
+      links = await initialize(dbConfig, linkDefinition)
    })

-    // bulk
-    await links.linkServiceName.create([
-      ["111", "aaa", { another_field: "test" }],
-      ["222", "bbb"],
-      ["333", "ccc", { extra_field: 2 }],
-      ["444", "bbb"],
-    ])
-
-    const values = await links.linkServiceName.list()
-
-    expect(values).toEqual([
-      {
-        product_id: "modA_id",
-        inventory_item_id: "modB_id",
-        id: expect.stringMatching("prefix_.+"),
-        extra_field: -1,
-        another_field: null,
-        created_at: expect.any(Date),
-        updated_at: expect.any(Date),
-        deleted_at: null,
-      },
-      expect.objectContaining({
-        product_id: "123",
-        inventory_item_id: "abc",
-        id: expect.stringMatching("prefix_.+"),
-        extra_field: 333,
-        another_field: "value**",
-      }),
-      expect.objectContaining({
-        product_id: "111",
-        inventory_item_id: "aaa",
-        extra_field: -1,
-        another_field: "test",
-      }),
-      expect.objectContaining({
-        product_id: "222",
-        inventory_item_id: "bbb",
-        extra_field: -1,
-        another_field: null,
-      }),
-      expect.objectContaining({
-        product_id: "333",
-        inventory_item_id: "ccc",
-        id: expect.stringMatching("prefix_.+"),
-        extra_field: 2,
-      }),
-      expect.objectContaining({
-        product_id: "444",
-        inventory_item_id: "bbb",
-      }),
-    ])
-  })
-
-  it("Should dismiss the link of a given pair of keys", async function () {
-    // simple
-    const dismissSingle = await links.linkServiceName.dismiss(
-      "modA_id",
-      "modB_id"
-    )
-
-    // bulk
-    const dismissMulti = await links.linkServiceName.dismiss([
-      ["111", "aaa"],
-      ["333", "ccc"],
-    ])
-
-    expect(dismissSingle).toEqual([
-      expect.objectContaining({
-        product_id: "modA_id",
-        inventory_item_id: "modB_id",
-        deleted_at: expect.any(Date),
-      }),
-    ])
-
-    expect(dismissMulti).toEqual([
-      expect.objectContaining({
-        product_id: "111",
-        inventory_item_id: "aaa",
-        deleted_at: expect.any(Date),
-      }),
-      expect.objectContaining({
-        product_id: "333",
-        inventory_item_id: "ccc",
-        deleted_at: expect.any(Date),
-      }),
-    ])
-  })
-
-  it("Should delete all the links related to a given key", async function () {
-    await links.linkServiceName.softDelete({
-      inventory_item_id: "bbb",
+    afterAll(async () => {
+      jest.clearAllMocks()
    })

-    const values = await links.linkServiceName.list(
-      { inventory_item_id: "bbb" },
-      { withDeleted: true }
-    )
+    describe("Link Modules", () => {
+      it("Should insert values in a declared link", async function () {
+        // simple
+        await links.linkServiceName.create("modA_id", "modB_id")

-    expect(values).toEqual([
-      expect.objectContaining({
-        product_id: "222",
-        inventory_item_id: "bbb",
-        deleted_at: expect.any(Date),
-      }),
-      expect.objectContaining({
-        product_id: "444",
-        inventory_item_id: "bbb",
-        deleted_at: expect.any(Date),
-      }),
-    ])
-  })
+        // extra fields
+        await links.linkServiceName.create("123", "abc", {
+          extra_field: 333,
+          another_field: "value**",
+        })
+
+        // bulk
+        await links.linkServiceName.create([
+          ["111", "aaa", { another_field: "test" }],
+          ["222", "bbb"],
+          ["333", "ccc", { extra_field: 2 }],
+          ["444", "bbb"],
+        ])
+
+        const values = await links.linkServiceName.list()
+
+        expect(values).toEqual([
+          {
+            product_id: "modA_id",
+            inventory_item_id: "modB_id",
+            id: expect.stringMatching("prefix_.+"),
+            extra_field: -1,
+            another_field: null,
+            created_at: expect.any(Date),
+            updated_at: expect.any(Date),
+            deleted_at: null,
+          },
+          expect.objectContaining({
+            product_id: "123",
+            inventory_item_id: "abc",
+            id: expect.stringMatching("prefix_.+"),
+            extra_field: 333,
+            another_field: "value**",
+          }),
+          expect.objectContaining({
+            product_id: "111",
+            inventory_item_id: "aaa",
+            extra_field: -1,
+            another_field: "test",
+          }),
+          expect.objectContaining({
+            product_id: "222",
+            inventory_item_id: "bbb",
+            extra_field: -1,
+            another_field: null,
+          }),
+          expect.objectContaining({
+            product_id: "333",
+            inventory_item_id: "ccc",
+            id: expect.stringMatching("prefix_.+"),
+            extra_field: 2,
+          }),
+          expect.objectContaining({
+            product_id: "444",
+            inventory_item_id: "bbb",
+          }),
+        ])
+      })
+
+      it("Should dismiss the link of a given pair of keys", async function () {
+        // simple
+        await links.linkServiceName.create("modA_id", "modB_id")
+
+        // extra fields
+        await links.linkServiceName.create("123", "abc", {
+          extra_field: 333,
+          another_field: "value**",
+        })
+
+        // bulk
+        await links.linkServiceName.create([
+          ["111", "aaa", { another_field: "test" }],
+          ["222", "bbb"],
+          ["333", "ccc", { extra_field: 2 }],
+          ["444", "bbb"],
+        ])
+
+        // simple
+        const dismissSingle = await links.linkServiceName.dismiss(
+          "modA_id",
+          "modB_id"
+        )
+
+        // bulk
+        const dismissMulti = await links.linkServiceName.dismiss([
+          ["111", "aaa"],
+          ["333", "ccc"],
+        ])
+
+        expect(dismissSingle).toEqual([
+          expect.objectContaining({
+            product_id: "modA_id",
+            inventory_item_id: "modB_id",
+            deleted_at: expect.any(Date),
+          }),
+        ])
+
+        expect(dismissMulti).toEqual([
+          expect.objectContaining({
+            product_id: "111",
+            inventory_item_id: "aaa",
+            deleted_at: expect.any(Date),
+          }),
+          expect.objectContaining({
+            product_id: "333",
+            inventory_item_id: "ccc",
+            deleted_at: expect.any(Date),
+          }),
+        ])
+      })
+
+      it("Should delete all the links related to a given key", async function () {
+        // simple
+        await links.linkServiceName.create("modA_id", "modB_id")
+
+        // extra fields
+        await links.linkServiceName.create("123", "abc", {
+          extra_field: 333,
+          another_field: "value**",
+        })
+
+        // bulk
+        await links.linkServiceName.create([
+          ["111", "aaa", { another_field: "test" }],
+          ["222", "bbb"],
+          ["333", "ccc", { extra_field: 2 }],
+          ["444", "bbb"],
+        ])
+
+        await links.linkServiceName.softDelete({
+          inventory_item_id: "bbb",
+        })
+
+        const values = await links.linkServiceName.list(
+          { inventory_item_id: "bbb" },
+          { withDeleted: true }
+        )
+
+        expect(values).toEqual([
+          expect.objectContaining({
+            product_id: "222",
+            inventory_item_id: "bbb",
+            deleted_at: expect.any(Date),
+          }),
+          expect.objectContaining({
+            product_id: "444",
+            inventory_item_id: "bbb",
+            deleted_at: expect.any(Date),
+          }),
+        ])
+      })
+    })
+  },
 })
--- a/integration-tests/modules/tests/modules/load-standalone.ts
+++ b/integration-tests/modules/tests/modules/load-standalone.ts
@@ -3,6 +3,7 @@ import { medusaIntegrationTestRunner } from "medusa-test-utils"
 jest.setTimeout(30000)

 medusaIntegrationTestRunner({
+  force_modules_migration: true,
  testSuite: ({ dbConnection }) => {
    describe("Standalone Modules", () => {
      beforeAll(async () => {
--- a/integration-tests/modules/package.json
+++ b/integration-tests/modules/package.json
@@ -5,7 +5,7 @@
  "license": "MIT",
  "private": true,
  "scripts": {
-    "test:integration": "node --expose-gc ./../../node_modules/.bin/jest --ci --silent=true --concurrency=50% --detectOpenHandles --logHeapUsage --forceExit",
+    "test:integration": "node --expose-gc ./../../node_modules/.bin/jest --ci --silent=true -i --detectOpenHandles --logHeapUsage --forceExit",
    "build": "babel src -d dist --extensions \".ts,.js\""
  },
  "dependencies": {