fix(dashboard, js-sdk, types, medusa): separate between delete response with and without parent (#8852)

- Separate the previous `DeleteResponse` to `DeleteResponse` and `DeleteResponseWithParent`, as not every API route's delete response returns a parent. This ensures more accurate types shown in OAS / documentation.
- Use `DeleteResponse` or `DeleteResponseWithParent` in response API routes based on what they return
- Remove direct usage of `DeleteResponse` in API route, and instead create a type in the `type` package specific for the route / domain.
- Use the new types in the `js-sdk` and `dashboard`.

packages/admin-next/dashboard/src/hooks/api/api-keys.tsx

@@ -114,7 +114,7 @@ export const useRevokeApiKey = (
 export const useDeleteApiKey = (
   id: string,
   options?: MutationOptions<
-    HttpTypes.DeleteResponse<"api_key">,
+    HttpTypes.AdminApiKeyDeleteResponse,
     FetchError,
     void
   >

packages/admin-next/dashboard/src/hooks/api/collections.tsx

@@ -129,7 +129,7 @@ export const useCreateCollection = (
 export const useDeleteCollection = (
   id: string,
   options?: UseMutationOptions<
-    HttpTypes.DeleteResponse<"collection">,
+    HttpTypes.AdminCollectionDeleteResponse,
     FetchError,
     void
   >

packages/admin-next/dashboard/src/hooks/api/customer-groups.tsx

@@ -105,7 +105,7 @@ export const useUpdateCustomerGroup = (
 export const useDeleteCustomerGroup = (
   id: string,
   options?: UseMutationOptions<
-    HttpTypes.DeleteResponse<"customer_group">,
+    HttpTypes.AdminCustomerGroupDeleteResponse,
     FetchError,
     void
   >

packages/admin-next/dashboard/src/hooks/api/customers.tsx

@@ -1,5 +1,5 @@
 import { FetchError } from "@medusajs/js-sdk"
-import { DeleteResponse, HttpTypes, PaginatedResponse } from "@medusajs/types"
+import { HttpTypes, PaginatedResponse } from "@medusajs/types"
 import {
   QueryKey,
   UseMutationOptions,
@@ -96,7 +96,11 @@ export const useUpdateCustomer = (
 
 export const useDeleteCustomer = (
   id: string,
-  options?: UseMutationOptions<DeleteResponse<"customer">, FetchError, void>
+  options?: UseMutationOptions<
+    HttpTypes.AdminCustomerDeleteResponse,
+    FetchError,
+    void
+  >
 ) => {
   return useMutation({
     mutationFn: () => sdk.admin.customer.delete(id),

packages/admin-next/dashboard/src/hooks/api/invites.tsx

@@ -1,6 +1,5 @@
 import {
   AdminInviteResponse,
-  DeleteResponse,
   HttpTypes,
   PaginatedResponse,
 } from "@medusajs/types"
@@ -94,7 +93,7 @@ export const useResendInvite = (
 
 export const useDeleteInvite = (
   id: string,
-  options?: UseMutationOptions<DeleteResponse<"invite">, Error, void>
+  options?: UseMutationOptions<HttpTypes.AdminInviteDeleteResponse, Error, void>
 ) => {
   return useMutation({
     mutationFn: () => sdk.admin.invite.delete(id),

packages/admin-next/dashboard/src/hooks/api/regions.tsx

@@ -1,4 +1,4 @@
-import { DeleteResponse, HttpTypes, PaginatedResponse } from "@medusajs/types"
+import { HttpTypes, PaginatedResponse } from "@medusajs/types"
 import {
   QueryKey,
   UseMutationOptions,
@@ -111,7 +111,7 @@ export const useUpdateRegion = (
 
 export const useDeleteRegion = (
   id: string,
-  options?: UseMutationOptions<DeleteResponse<"region">, Error, void>
+  options?: UseMutationOptions<HttpTypes.AdminRegionDeleteResponse, Error, void>
 ) => {
   return useMutation({
     mutationFn: () => sdk.admin.region.delete(id),

packages/admin-next/dashboard/src/hooks/api/reservations.tsx

@@ -122,7 +122,7 @@ export const useCreateReservationItem = (
 export const useDeleteReservationItem = (
   id: string,
   options?: UseMutationOptions<
-    HttpTypes.DeleteResponse<"reservation">,
+    HttpTypes.AdminReservationDeleteResponse,
     FetchError,
     void
   >

packages/core/js-sdk/src/admin/api-key.ts

@@ -73,7 +73,7 @@ export class ApiKey {
   }
 
   async delete(id: string, headers?: ClientHeaders) {
-    return await this.client.fetch<HttpTypes.DeleteResponse<"api_key">>(
+    return await this.client.fetch<HttpTypes.AdminApiKeyDeleteResponse>(
       `/admin/api-keys/${id}`,
       {
         method: "DELETE",

packages/core/js-sdk/src/admin/customer-group.ts

@@ -71,7 +71,7 @@ export class CustomerGroup {
   }
 
   async delete(id: string, headers?: ClientHeaders) {
-    return await this.client.fetch<HttpTypes.DeleteResponse<"customer_group">>(
+    return await this.client.fetch<HttpTypes.AdminCustomerGroupDeleteResponse>(
       `/admin/customer-groups/${id}`,
       {
         method: "DELETE",

packages/core/js-sdk/src/admin/customer.ts

@@ -1,5 +1,4 @@
 import {
-  DeleteResponse,
   FindParams,
   HttpTypes,
   PaginatedResponse,
@@ -69,7 +68,7 @@ export class Customer {
   }
 
   async delete(id: string, headers?: ClientHeaders) {
-    return this.client.fetch<DeleteResponse<"customer">>(
+    return this.client.fetch<HttpTypes.AdminCustomerDeleteResponse>(
       `/admin/customers/${id}`,
       {
         method: "DELETE",

packages/core/js-sdk/src/admin/invite.ts

@@ -1,5 +1,4 @@
 import {
-  DeleteResponse,
   FindParams,
   HttpTypes,
   PaginatedResponse,
@@ -76,7 +75,7 @@ export class Invite {
   }
 
   async delete(id: string, headers?: ClientHeaders) {
-    return await this.client.fetch<DeleteResponse<"invite">>(
+    return await this.client.fetch<HttpTypes.AdminInviteDeleteResponse>(
       `/admin/invites/${id}`,
       {
         method: "DELETE",

packages/core/js-sdk/src/admin/region.ts

@@ -1,5 +1,4 @@
 import {
-  DeleteResponse,
   FindParams,
   HttpTypes,
   PaginatedResponse,
@@ -70,7 +69,7 @@ export class Region {
   }
 
   async delete(id: string, headers?: ClientHeaders) {
-    return await this.client.fetch<DeleteResponse<"region">>(
+    return await this.client.fetch<HttpTypes.AdminRegionDeleteResponse>(
       `/admin/regions/${id}`,
       {
         method: "DELETE",

packages/core/js-sdk/src/admin/reservation.ts

@@ -71,7 +71,7 @@ class Reservation {
   }
 
   async delete(id: string, headers?: ClientHeaders) {
-    return await this.client.fetch<HttpTypes.DeleteResponse<"reservation">>(
+    return await this.client.fetch<HttpTypes.AdminReservationDeleteResponse>(
       `/admin/reservations/${id}`,
       {
         method: "DELETE",

packages/core/js-sdk/src/admin/upload.ts

@@ -1,4 +1,4 @@
-import { DeleteResponse, HttpTypes, SelectParams } from "@medusajs/types"
+import { HttpTypes, SelectParams } from "@medusajs/types"
 import { Client } from "../client"
 import { ClientHeaders } from "../types"
 
@@ -59,7 +59,7 @@ export class Upload {
   }
 
   async delete(id: string, headers?: ClientHeaders) {
-    return this.client.fetch<DeleteResponse<"file">>(`/admin/uploads/${id}`, {
+    return this.client.fetch<HttpTypes.AdminFileDeleteResponse>(`/admin/uploads/${id}`, {
       method: "DELETE",
       headers,
     })

packages/core/js-sdk/src/store/index.ts

@@ -1,5 +1,4 @@
 import {
-  DeleteResponse,
   FindParams,
   HttpTypes,
   PaginatedResponse,
@@ -206,7 +205,7 @@ export class Store {
       headers?: ClientHeaders
     ) => {
       return this.client.fetch<
-        DeleteResponse<"line-item", HttpTypes.StoreCart>
+        HttpTypes.StoreLineItemDeleteResponse
       >(`/store/carts/${cartId}/line-items/${lineItemId}`, {
         method: "DELETE",
         headers,
@@ -434,7 +433,7 @@ export class Store {
     },
     deleteAddress: async (addressId: string, headers?: ClientHeaders) => {
       return this.client.fetch<
-        DeleteResponse<"address", HttpTypes.StoreCustomer>
+        HttpTypes.StoreCustomerAddressDeleteResponse
       >(`/store/customers/me/addresses/${addressId}`, {
         method: "DELETE",
         headers,

packages/core/types/src/http/api-key/admin/index.ts

@@ -1,3 +1,3 @@
-export * from "./api-key"
+export * from "./responses"
 export * from "./payloads"
 export * from "./queries"

packages/core/types/src/http/api-key/admin/responses.ts

@@ -1,5 +1,5 @@
 import { ApiKeyType } from "../../../api-key"
-import { PaginatedResponse } from "../../common"
+import { DeleteResponse, PaginatedResponse } from "../../common"
 
 interface AdminApiKey {
   id: string
@@ -21,3 +21,5 @@ export interface AdminApiKeyResponse {
 export type AdminApiKeyListResponse = PaginatedResponse<{
   api_keys: AdminApiKey[]
 }>
+
+export type AdminApiKeyDeleteResponse = DeleteResponse<"api_key">

packages/core/types/src/http/campaign/admin/responses.ts

@@ -1,5 +1,5 @@
 import { CampaignBudgetTypeValues } from "../../../promotion"
-import { PaginatedResponse } from "../../common"
+import { DeleteResponse, PaginatedResponse } from "../../common"
 
 export interface AdminCampaign {
   id: string
@@ -25,3 +25,5 @@ export type AdminCampaignListResponse = PaginatedResponse<{
 export interface AdminCampaignResponse {
   campaign: AdminCampaign
 }
+
+export type AdminCampaignDeleteResponse = DeleteResponse<"campaign">

packages/core/types/src/http/cart/store/responses.ts

@@ -1,3 +1,4 @@
+import { DeleteResponseWithParent } from "../../common"
 import { StoreOrder } from "../../order"
 import { StoreCart } from "./entities"
 
@@ -17,3 +18,5 @@ export type StoreCompleteCartResponse = {
   type: "order"
   order: StoreOrder
 }
+
+export type StoreLineItemDeleteResponse = DeleteResponseWithParent<"line-item", StoreCart>

packages/core/types/src/http/common/response.ts

@@ -1,4 +1,4 @@
-export type DeleteResponse<TObject extends string, TParent = {}> = {
+export type DeleteResponse<TObject extends string> = {
   /**
    * The ID of the item that was deleted.
    */
@@ -13,12 +13,16 @@ export type DeleteResponse<TObject extends string, TParent = {}> = {
    * Whether the item was deleted successfully.
    */
   deleted: boolean
+}
 
+export type DeleteResponseWithParent<TObject extends string, TParent = {}> = 
+  DeleteResponse<TObject> & 
+  {
     /**
      * The parent resource of the item that was deleted, if applicable.
      */
     parent?: TParent
-}
+  }
 
 export type PaginatedResponse<T> = {
   limit: number

packages/core/types/src/http/customer/admin/responses.ts

@@ -1,4 +1,4 @@
-import { PaginatedResponse } from "../../common"
+import { DeleteResponse, DeleteResponseWithParent, PaginatedResponse } from "../../common"
 import { AdminCustomer, AdminCustomerAddress } from "./entities"
 
 export interface AdminCustomerResponse {
@@ -16,3 +16,12 @@ export interface AdminCustomerAddressResponse {
 export type AdminCustomerAddressListResponse = PaginatedResponse<{
   addresses: AdminCustomerAddress[]
 }>
+
+export type AdminCustomerDeleteResponse = DeleteResponse<"customer">
+
+export type AdminCustomerGroupDeleteResponse = DeleteResponse<"customer_group">
+
+export type AdminCustomerAddressDeleteResponse = DeleteResponseWithParent<
+  "customer_address",
+  AdminCustomer
+>

packages/core/types/src/http/customer/store/responses.ts

@@ -1,4 +1,4 @@
-import { PaginatedResponse } from "../../common";
+import { DeleteResponseWithParent, PaginatedResponse } from "../../common";
 import { StoreCustomer, StoreCustomerAddress } from "./entities";
 
 export interface StoreCustomerResponse {
@@ -11,3 +11,5 @@ export interface StoreCustomerAddressResponse {
 
 export interface StoreCustomerAddressListResponse
   extends PaginatedResponse<{ addresses: StoreCustomerAddress[] }> {}
+
+export type StoreCustomerAddressDeleteResponse = DeleteResponseWithParent<"address", StoreCustomer>

packages/core/types/src/http/file/admin/responses.ts

@@ -1,3 +1,4 @@
+import { DeleteResponse } from "../../common";
 import { AdminFile } from "./entities";
 
 export interface AdminFileResponse {
@@ -7,3 +8,5 @@ export interface AdminFileResponse {
 export interface AdminFileListResponse {
   files: AdminFile[]
 }
+
+export type AdminFileDeleteResponse = DeleteResponse<"file">

packages/core/types/src/http/fulfillment-set/admin/responses.ts

@@ -1,4 +1,4 @@
-import { DeleteResponse } from "../../common"
+import { DeleteResponse, DeleteResponseWithParent } from "../../common"
 import { AdminFulfillmentSet, AdminServiceZone } from "./entities"
 
 export interface AdminServiceZoneResponse {
@@ -6,7 +6,7 @@ export interface AdminServiceZoneResponse {
 }
 
 export interface AdminServiceZoneDeleteResponse
-  extends DeleteResponse<"service_zone", AdminFulfillmentSet> {}
+  extends DeleteResponseWithParent<"service_zone", AdminFulfillmentSet> {}
 
 export interface AdminFulfillmentSetResponse {
   fulfillment_set: AdminFulfillmentSet

packages/core/types/src/http/inventory/admin/responses.ts

@@ -1,4 +1,4 @@
-import { DeleteResponse, PaginatedResponse } from "../../common"
+import { DeleteResponse, DeleteResponseWithParent, PaginatedResponse } from "../../common"
 import { AdminInventoryItem } from "./entities"
 
 export interface AdminInventoryItemResponse {
@@ -10,3 +10,8 @@ export type AdminInventoryItemListResponse = PaginatedResponse<{
 }>
 
 export type AdminInventoryItemDeleteResponse = DeleteResponse<"inventory_item">
+
+export type AdminInventoryLevelDeleteResponse = DeleteResponseWithParent<
+  "inventory-level",
+  AdminInventoryItem
+>

packages/core/types/src/http/invite/admin/responses.ts

@@ -1,4 +1,4 @@
-import { PaginatedResponse } from "../../common";
+import { DeleteResponse, PaginatedResponse } from "../../common";
 import { AdminUser } from "../../user";
 import { AdminInvite } from "./entities";
 
@@ -15,3 +15,5 @@ export type AdminAcceptInviteResponse = {
 } | {
   message: string
 }
+
+export type AdminInviteDeleteResponse = DeleteResponse<"invite">

packages/core/types/src/http/order-edit/admin/responses.ts

@@ -1,4 +1,5 @@
 import { OrderChangeDTO, OrderPreviewDTO } from "../../../order"
+import { DeleteResponse } from "../../common"
 
 export interface AdminOrderEditPreviewResponse {
   order_preview: OrderPreviewDTO
@@ -8,8 +9,4 @@ export interface AdminOrderEditResponse {
   order_change: OrderChangeDTO
 }
 
-export interface AdminOrderEditDeleteResponse {
+export type AdminOrderEditDeleteResponse = DeleteResponse<"order-edit">
-  id: string
-  object: "order-edit"
-  deleted: true
-}

packages/core/types/src/http/payment/admin/responses.ts

@@ -45,3 +45,5 @@ export type RefundReasonsResponse = PaginatedResponse<{
 export type AdminPaymentProviderListResponse = PaginatedResponse<{
   payment_providers: AdminPaymentProvider[]
 }>
+
+export type AdminRefundReasonDeleteResponse = DeleteResponse<"refund_reason">

packages/core/types/src/http/product/admin/responses.ts

@@ -1,5 +1,5 @@
 import { BatchMethodResponse } from "../../../common"
-import { DeleteResponse, PaginatedResponse } from "../../common"
+import { DeleteResponse, DeleteResponseWithParent, PaginatedResponse } from "../../common"
 import {
   AdminProduct,
   AdminProductOption,
@@ -30,7 +30,7 @@ export type AdminProductVariantListResponse = PaginatedResponse<{
 }>
 
 export interface AdminProductVariantDeleteResponse
-  extends DeleteResponse<"variant", AdminProduct> {}
+  extends DeleteResponseWithParent<"variant", AdminProduct> {}
 
 export interface AdminExportProductResponse {
   transaction_id: string
@@ -59,7 +59,7 @@ export type AdminProductOptionListResponse = PaginatedResponse<{
 }>
 
 export interface AdminProductOptionDeleteResponse
-  extends DeleteResponse<"product_option", AdminProduct> {}
+  extends DeleteResponseWithParent<"product_option", AdminProduct> {}
 
 export type AdminProductVariantInventoryResponse = AdminProductVariantInventoryLink | AdminProductVariantInventoryLink[]
 

packages/core/types/src/http/promotion/admin/responses.ts

@@ -1,5 +1,5 @@
 import { BatchMethodResponse } from "../../../common";
-import { PaginatedResponse } from "../../common";
+import { DeleteResponse, PaginatedResponse } from "../../common";
 import { 
   AdminPromotion, 
   AdminPromotionRule, 
@@ -55,3 +55,5 @@ export type AdminRuleValueOptionsListResponse = {
 }
 
 export type AdminPromotionRuleBatchResponse = BatchMethodResponse<AdminPromotionRule>
+
+export type AdminPromotionDeleteResponse = DeleteResponse<"promotion">

packages/core/types/src/http/region/admin/responses.ts

@@ -1,4 +1,4 @@
-import { PaginatedResponse } from "../../common";
+import { DeleteResponse, PaginatedResponse } from "../../common";
 import { AdminRegion } from "./entities";
 
 export interface AdminRegionResponse {
@@ -8,3 +8,5 @@ export interface AdminRegionResponse {
 export type AdminRegionListResponse = PaginatedResponse<{
   regions: AdminRegion[]
 }>
+
+export type AdminRegionDeleteResponse = DeleteResponse<"region">

packages/core/types/src/http/reservation/admin/responses.ts

@@ -1,4 +1,4 @@
-import { PaginatedResponse } from "../../common"
+import { DeleteResponse, PaginatedResponse } from "../../common"
 import { AdminReservation } from "./entities"
 
 export interface AdminReservationResponse {
@@ -8,3 +8,5 @@ export interface AdminReservationResponse {
 export type AdminReservationListResponse = PaginatedResponse<{
   reservations: AdminReservation[]
 }>
+
+export type AdminReservationDeleteResponse = DeleteResponse<"reservation">

packages/core/types/src/http/return/admin/responses.ts

@@ -1,5 +1,5 @@
 import { OrderDTO } from "../../../order"
-import { PaginatedResponse } from "../../common"
+import { DeleteResponse, PaginatedResponse } from "../../common"
 import { AdminOrderPreview } from "../../order"
 import { AdminReturn } from "./entities"
 
@@ -20,3 +20,5 @@ export interface AdminReturnPreviewResponse {
   order_preview: AdminOrderPreview
   return: AdminReturn
 }
+
+export type AdminReturnDeleteResponse = DeleteResponse<"return">

packages/core/types/src/http/tax-rate/admin/responses.ts

@@ -1,4 +1,4 @@
-import { DeleteResponse, PaginatedResponse } from "../../common"
+import { DeleteResponse, DeleteResponseWithParent, PaginatedResponse } from "../../common"
 import { AdminTaxRate } from "./entities"
 
 export interface AdminTaxRateResponse {
@@ -11,3 +11,5 @@ export type AdminTaxRateListResponse = PaginatedResponse<{
 
 export interface AdminTaxRateDeleteResponse
   extends DeleteResponse<"tax_rate"> {}
+
+export type AdminTaxRateRuleDeleteResponse = DeleteResponseWithParent<"tax_rate_rule", AdminTaxRate>

packages/medusa/src/api/admin/api-keys/[id]/route.ts

@@ -10,7 +10,7 @@ import {
 import { refetchApiKey } from "../helpers"
 import { AdminUpdateApiKeyType } from "../validators"
 import { MedusaError } from "@medusajs/utils"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 
 export const GET = async (
   req: AuthenticatedMedusaRequest,
@@ -54,7 +54,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"api_key">>
+  res: MedusaResponse<HttpTypes.AdminApiKeyDeleteResponse>
 ) => {
   const id = req.params.id
 

packages/medusa/src/api/admin/campaigns/[id]/route.ts

@@ -10,7 +10,7 @@ import {
 import { refetchCampaign } from "../helpers"
 import { AdminUpdateCampaignType } from "../validators"
 import { MedusaError } from "@medusajs/utils"
-import { AdditionalData, DeleteResponse, HttpTypes } from "@medusajs/types"
+import { AdditionalData, HttpTypes } from "@medusajs/types"
 
 export const GET = async (
   req: AuthenticatedMedusaRequest,
@@ -59,7 +59,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"campaign">>
+  res: MedusaResponse<HttpTypes.AdminCampaignDeleteResponse>
 ) => {
   const id = req.params.id
   const deleteCampaigns = deleteCampaignsWorkflow(req.scope)

packages/medusa/src/api/admin/customer-groups/[id]/route.ts

@@ -10,7 +10,7 @@ import {
 import { MedusaError } from "@medusajs/utils"
 import { refetchCustomerGroup } from "../helpers"
 import { AdminUpdateCustomerGroupType } from "../validators"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 
 export const GET = async (
   req: AuthenticatedMedusaRequest,
@@ -53,7 +53,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"customer_group">>
+  res: MedusaResponse<HttpTypes.AdminCustomerGroupDeleteResponse>
 ) => {
   const id = req.params.id
   const deleteCustomerGroups = deleteCustomerGroupsWorkflow(req.scope)

packages/medusa/src/api/admin/customers/[id]/addresses/[address_id]/route.ts

@@ -13,7 +13,7 @@ import {
 } from "@medusajs/utils"
 import { AdminCreateCustomerAddressType } from "../../../validators"
 import { refetchCustomer } from "../../../helpers"
-import { AdditionalData, DeleteResponse, HttpTypes } from "@medusajs/types"
+import { AdditionalData, HttpTypes } from "@medusajs/types"
 
 export const GET = async (
   req: AuthenticatedMedusaRequest,
@@ -61,7 +61,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"customer_address">>
+  res: MedusaResponse<HttpTypes.AdminCustomerAddressDeleteResponse>
 ) => {
   const id = req.params.address_id
   const deleteAddress = deleteCustomerAddressesWorkflow(req.scope)

packages/medusa/src/api/admin/customers/[id]/route.ts

@@ -2,7 +2,7 @@ import {
   deleteCustomersWorkflow,
   updateCustomersWorkflow,
 } from "@medusajs/core-flows"
-import { AdditionalData, DeleteResponse, HttpTypes } from "@medusajs/types"
+import { AdditionalData, HttpTypes } from "@medusajs/types"
 import { MedusaError } from "@medusajs/utils"
 import {
   AuthenticatedMedusaRequest,
@@ -55,7 +55,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"customer">>
+  res: MedusaResponse<HttpTypes.AdminCustomerDeleteResponse>
 ) => {
   const id = req.params.id
   const deleteCustomers = deleteCustomersWorkflow(req.scope)

packages/medusa/src/api/admin/exchanges/[id]/request/route.ts

@@ -2,7 +2,7 @@ import {
   cancelBeginOrderExchangeWorkflow,
   confirmExchangeRequestWorkflow,
 } from "@medusajs/core-flows"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 import {
   ContainerRegistrationKeys,
   remoteQueryObjectFromString,
@@ -66,7 +66,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"exchange">>
+  res: MedusaResponse<HttpTypes.AdminExchangeDeleteResponse>
 ) => {
   const { id } = req.params
 

packages/medusa/src/api/admin/fulfillment-sets/[id]/service-zones/[zone_id]/route.ts

@@ -5,7 +5,7 @@ import {
 import {
   AdminFulfillmentSetResponse,
   AdminServiceZoneResponse,
-  DeleteResponse,
+  HttpTypes,
   IFulfillmentModuleService,
 } from "@medusajs/types"
 import {
@@ -94,7 +94,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"service_zone">>
+  res: MedusaResponse<HttpTypes.AdminServiceZoneDeleteResponse>
 ) => {
   const { id, zone_id } = req.params
 
@@ -125,6 +125,6 @@ export const DELETE = async (
     id: zone_id,
     object: "service_zone",
     deleted: true,
-    parent: fulfillmentSet,
+    parent: fulfillmentSet as unknown as HttpTypes.AdminFulfillmentSet,
   })
 }

packages/medusa/src/api/admin/inventory-items/[id]/location-levels/[location_id]/route.ts

@@ -11,11 +11,11 @@ import {
 } from "@medusajs/core-flows"
 import { refetchInventoryItem } from "../../../helpers"
 import { AdminUpdateInventoryLocationLevelType } from "../../../validators"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 
 export const DELETE = async (
   req: MedusaRequest,
-  res: MedusaResponse<DeleteResponse<"inventory-level">>
+  res: MedusaResponse<HttpTypes.AdminInventoryLevelDeleteResponse>
 ) => {
   const { id, location_id } = req.params
 

packages/medusa/src/api/admin/inventory-items/[id]/route.ts

@@ -9,7 +9,7 @@ import {
   AdminUpdateInventoryItemType,
 } from "../validators"
 import { refetchInventoryItem } from "../helpers"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 
 export const GET = async (
   req: MedusaRequest<AdminGetInventoryItemParamsType>,
@@ -59,7 +59,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: MedusaRequest,
-  res: MedusaResponse<DeleteResponse<"inventory_item">>
+  res: MedusaResponse<HttpTypes.AdminInventoryItemDeleteResponse>
 ) => {
   const id = req.params.id
   const deleteInventoryItems = deleteInventoryItemWorkflow(req.scope)

packages/medusa/src/api/admin/invites/[id]/route.ts

@@ -6,7 +6,7 @@ import { MedusaError } from "@medusajs/utils"
 
 import { deleteInvitesWorkflow } from "@medusajs/core-flows"
 import { refetchInvite } from "../helpers"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 
 export const GET = async (
   req: AuthenticatedMedusaRequest,
@@ -31,7 +31,7 @@ export const GET = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"invite">>
+  res: MedusaResponse<HttpTypes.AdminInviteDeleteResponse>
 ) => {
   const { id } = req.params
   const workflow = deleteInvitesWorkflow(req.scope)

packages/medusa/src/api/admin/order-edits/[id]/route.ts

@@ -1,5 +1,5 @@
 import { cancelBeginOrderEditWorkflow } from "@medusajs/core-flows"
-import { DeleteResponse } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 import {
   AuthenticatedMedusaRequest,
   MedusaResponse,
@@ -7,7 +7,7 @@ import {
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"order-edit">>
+  res: MedusaResponse<HttpTypes.AdminOrderEditDeleteResponse>
 ) => {
   const { id } = req.params
 

packages/medusa/src/api/admin/payment-collections/[id]/route.ts

@@ -1,5 +1,5 @@
 import { deleteOrderPaymentCollections } from "@medusajs/core-flows"
-import { DeleteResponse } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 import {
   AuthenticatedMedusaRequest,
   MedusaResponse,
@@ -7,7 +7,7 @@ import {
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"payment-collection">>
+  res: MedusaResponse<HttpTypes.AdminDeletePaymentCollectionResponse>
 ) => {
   const { id } = req.params
 

packages/medusa/src/api/admin/promotions/[id]/route.ts

@@ -16,7 +16,7 @@ import {
   AdminGetPromotionParamsType,
   AdminUpdatePromotionType,
 } from "../validators"
-import { AdditionalData, DeleteResponse, HttpTypes } from "@medusajs/types"
+import { AdditionalData, HttpTypes } from "@medusajs/types"
 
 export const GET = async (
   req: AuthenticatedMedusaRequest<AdminGetPromotionParamsType>,
@@ -71,7 +71,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"promotion">>
+  res: MedusaResponse<HttpTypes.AdminPromotionDeleteResponse>
 ) => {
   const id = req.params.id
   const deletePromotions = deletePromotionsWorkflow(req.scope)

packages/medusa/src/api/admin/refund-reasons/[id]/route.ts

@@ -2,7 +2,7 @@ import {
   deleteReturnReasonsWorkflow,
   updateRefundReasonsWorkflow,
 } from "@medusajs/core-flows"
-import { DeleteResponse, RefundReasonResponse } from "@medusajs/types"
+import { HttpTypes, RefundReasonResponse } from "@medusajs/types"
 import {
   AuthenticatedMedusaRequest,
   MedusaResponse,
@@ -51,7 +51,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"refund_reason">>
+  res: MedusaResponse<HttpTypes.AdminRefundReasonDeleteResponse>
 ) => {
   const { id } = req.params
   const input = { ids: [id] }

packages/medusa/src/api/admin/regions/[id]/route.ts

@@ -9,7 +9,7 @@ import {
 } from "../../../../types/routing"
 import { refetchRegion } from "../helpers"
 import { AdminGetRegionParamsType, AdminUpdateRegionType } from "../validators"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 
 export const GET = async (
   req: AuthenticatedMedusaRequest<AdminGetRegionParamsType>,
@@ -53,7 +53,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"region">>
+  res: MedusaResponse<HttpTypes.AdminRegionDeleteResponse>
 ) => {
   const id = req.params.id
 

packages/medusa/src/api/admin/reservations/[id]/route.ts

@@ -10,7 +10,7 @@ import { MedusaError } from "@medusajs/utils"
 import { deleteReservationsWorkflow } from "@medusajs/core-flows"
 import { updateReservationsWorkflow } from "@medusajs/core-flows"
 import { refetchReservation } from "../helpers"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 
 export const GET = async (
   req: AuthenticatedMedusaRequest<AdminGetReservationParamsType>,
@@ -55,7 +55,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"reservation">>
+  res: MedusaResponse<HttpTypes.AdminReservationDeleteResponse>
 ) => {
   const id = req.params.id
 

packages/medusa/src/api/admin/return-reasons/[id]/route.ts

@@ -4,7 +4,7 @@ import {
 } from "@medusajs/core-flows"
 import {
   AdminReturnReasonResponse,
-  DeleteResponse,
+  HttpTypes,
   UpdateOrderReturnReasonDTO,
 } from "@medusajs/types"
 import {
@@ -69,7 +69,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"return_reason">>
+  res: MedusaResponse<HttpTypes.AdminReturnReasonDeleteResponse>
 ) => {
   const { id } = req.params
 

packages/medusa/src/api/admin/returns/[id]/receive/route.ts

@@ -13,7 +13,7 @@ import {
   MedusaResponse,
 } from "../../../../../types/routing"
 import { AdminPostReceiveReturnsReqSchemaType } from "../../validators"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 
 export const POST = async (
   req: AuthenticatedMedusaRequest<AdminPostReceiveReturnsReqSchemaType>,
@@ -56,7 +56,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"return">>
+  res: MedusaResponse<HttpTypes.AdminReturnDeleteResponse>
 ) => {
   const { id } = req.params
 

packages/medusa/src/api/admin/returns/[id]/request/route.ts

@@ -2,7 +2,7 @@ import {
   cancelReturnRequestWorkflow,
   confirmReturnRequestWorkflow,
 } from "@medusajs/core-flows"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 import {
   ContainerRegistrationKeys,
   remoteQueryObjectFromString,
@@ -49,7 +49,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"return">>
+  res: MedusaResponse<HttpTypes.AdminReturnDeleteResponse>
 ) => {
   const { id } = req.params
 

packages/medusa/src/api/admin/tax-rates/[id]/rules/[rule_id]/route.ts

@@ -4,11 +4,11 @@ import {
   MedusaResponse,
 } from "../../../../../../types/routing"
 import { refetchTaxRate } from "../../../helpers"
-import { DeleteResponse } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"tax_rate_rule">>
+  res: MedusaResponse<HttpTypes.AdminTaxRateRuleDeleteResponse>
 ) => {
   await deleteTaxRateRulesWorkflow(req.scope).run({
     input: { ids: [req.params.rule_id] },

packages/medusa/src/api/admin/uploads/[id]/route.ts

@@ -3,7 +3,7 @@ import {
   MedusaResponse,
 } from "../../../../types/routing"
 import { deleteFilesWorkflow } from "@medusajs/core-flows"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 import { ContainerRegistrationKeys, MedusaError } from "@medusajs/utils"
 import { remoteQueryObjectFromString } from "@medusajs/utils"
 
@@ -33,7 +33,7 @@ export const GET = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"file">>
+  res: MedusaResponse<HttpTypes.AdminFileDeleteResponse>
 ) => {
   const id = req.params.id
 

packages/medusa/src/api/store/carts/[id]/line-items/[line_id]/route.ts

@@ -2,7 +2,7 @@ import {
   deleteLineItemsWorkflow,
   updateLineItemInCartWorkflow,
 } from "@medusajs/core-flows"
-import { DeleteResponse, HttpTypes } from "@medusajs/types"
+import { HttpTypes } from "@medusajs/types"
 import { MedusaError } from "@medusajs/utils"
 import { MedusaRequest, MedusaResponse } from "../../../../../../types/routing"
 import { prepareListQuery } from "../../../../../../utils/get-query-config"
@@ -60,7 +60,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: MedusaRequest,
-  res: MedusaResponse<DeleteResponse<"line-item">>
+  res: MedusaResponse<HttpTypes.StoreLineItemDeleteResponse>
 ) => {
   const id = req.params.line_id
 

packages/medusa/src/api/store/customers/me/addresses/[address_id]/route.ts

@@ -6,8 +6,7 @@ import {
   AuthenticatedMedusaRequest,
   MedusaResponse,
 } from "../../../../../../types/routing"
-
+import { HttpTypes, MedusaContainer } from "@medusajs/types"
-import { DeleteResponse, HttpTypes, MedusaContainer } from "@medusajs/types"
 import {
   ContainerRegistrationKeys,
   MedusaError,
@@ -71,7 +70,7 @@ export const POST = async (
 
 export const DELETE = async (
   req: AuthenticatedMedusaRequest,
-  res: MedusaResponse<DeleteResponse<"address">>
+  res: MedusaResponse<HttpTypes.StoreCustomerAddressDeleteResponse>
 ) => {
   const id = req.auth_context.actor_id
   await validateCustomerAddress(req.scope, id, req.params.address_id)