From 10ff72c30ae59d2174d876b0c4141aad135d9a1c Mon Sep 17 00:00:00 2001 From: josetr <37419832+josetr@users.noreply.github.com> Date: Tue, 14 Feb 2023 08:24:39 +0000 Subject: [PATCH] fix(medusa): Add missing scoped transaction on update currency endpoint (#3254) --- .changeset/quiet-nails-jam.md | 5 +++++ .../src/api/routes/admin/currencies/update-currency.ts | 10 +++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 .changeset/quiet-nails-jam.md diff --git a/.changeset/quiet-nails-jam.md b/.changeset/quiet-nails-jam.md new file mode 100644 index 0000000000..fa5afd7614 --- /dev/null +++ b/.changeset/quiet-nails-jam.md @@ -0,0 +1,5 @@ +--- +"@medusajs/medusa": patch +--- + +fix(medusa): Add missing scoped transaction on update currency endpoint diff --git a/packages/medusa/src/api/routes/admin/currencies/update-currency.ts b/packages/medusa/src/api/routes/admin/currencies/update-currency.ts index 090d6fb2cc..84fa5035dd 100644 --- a/packages/medusa/src/api/routes/admin/currencies/update-currency.ts +++ b/packages/medusa/src/api/routes/admin/currencies/update-currency.ts @@ -4,6 +4,7 @@ import { ExtendedRequest } from "../../../../types/global" import { CurrencyService } from "../../../../services" import { FeatureFlagDecorators } from "../../../../utils/feature-flag-decorators" import TaxInclusivePricingFeatureFlag from "../../../../loaders/feature-flags/tax-inclusive-pricing" +import { EntityManager } from "typeorm" /** * @oas [post] /currencies/{code} @@ -56,8 +57,15 @@ export default async (req: ExtendedRequest, res) => { const code = req.params.code as string const data = req.validatedBody as AdminPostCurrenciesCurrencyReq const currencyService: CurrencyService = req.scope.resolve("currencyService") + const manager: EntityManager = req.scope.resolve("manager") - const currency = await currencyService.update(code, data) + const currency = await manager.transaction( + async (transactionManager) => { + return await currencyService + .withTransaction(transactionManager) + .update(code, data) + } + ) res.json({ currency }) }