From 12fcb655cd0e398e75acce39166d14db13aa2c08 Mon Sep 17 00:00:00 2001 From: Adrien de Peretti Date: Thu, 4 Apr 2024 20:40:41 +0200 Subject: [PATCH] chore: Ensure Redis connection is ready with callback (#6924) * chore(workflow-engine-redis): await for the connection callback * cleanup * cleanup * Create early-rice-marry.md * cleanup --- .changeset/early-rice-marry.md | 6 ++++++ packages/event-bus-redis/src/loaders/index.ts | 4 +++- packages/workflow-engine-redis/src/loaders/redis.ts | 6 ++++-- 3 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 .changeset/early-rice-marry.md diff --git a/.changeset/early-rice-marry.md b/.changeset/early-rice-marry.md new file mode 100644 index 0000000000..b51f3b49d0 --- /dev/null +++ b/.changeset/early-rice-marry.md @@ -0,0 +1,6 @@ +--- +"@medusajs/event-bus-redis": patch +"@medusajs/workflow-engine-redis": patch +--- + +Chore/workflow engine loader redis diff --git a/packages/event-bus-redis/src/loaders/index.ts b/packages/event-bus-redis/src/loaders/index.ts index a405013078..40028b57e1 100644 --- a/packages/event-bus-redis/src/loaders/index.ts +++ b/packages/event-bus-redis/src/loaders/index.ts @@ -27,7 +27,9 @@ export default async ({ }) try { - await connection.connect() + await new Promise(async resolve => { + await connection.connect(resolve) + }) logger?.info(`Connection to Redis in module 'event-bus-redis' established`) } catch (err) { logger?.error( diff --git a/packages/workflow-engine-redis/src/loaders/redis.ts b/packages/workflow-engine-redis/src/loaders/redis.ts index dd8a974c0f..df82f0f4b8 100644 --- a/packages/workflow-engine-redis/src/loaders/redis.ts +++ b/packages/workflow-engine-redis/src/loaders/redis.ts @@ -7,7 +7,7 @@ export default async ({ container, logger, options, - dataLoaderOnly + dataLoaderOnly, }: LoaderOptions): Promise => { const { url, @@ -80,7 +80,9 @@ async function getConnection(url, redisOptions) { ...(redisOptions ?? {}), }) - await connection.connect() + await new Promise(async (resolve) => { + await connection.connect(resolve) + }) return connection }