From 1263d24ca380918345c844c1793f2706a49f85c6 Mon Sep 17 00:00:00 2001 From: Sebastian Rindom Date: Mon, 8 Mar 2021 15:31:39 +0100 Subject: [PATCH] fix: enable gift-card creation without order_id (#195) --- packages/medusa-plugin-sendgrid/src/services/sendgrid.js | 4 ++++ packages/medusa/src/services/gift-card.js | 7 ------- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/medusa-plugin-sendgrid/src/services/sendgrid.js b/packages/medusa-plugin-sendgrid/src/services/sendgrid.js index 0d027700f8..61aeb788e4 100644 --- a/packages/medusa-plugin-sendgrid/src/services/sendgrid.js +++ b/packages/medusa-plugin-sendgrid/src/services/sendgrid.js @@ -381,6 +381,10 @@ class SendGridService extends NotificationService { relations: ["region", "order"], }) + if (!giftCard.order) { + return + } + const taxRate = giftCard.region.tax_rate / 100 return { diff --git a/packages/medusa/src/services/gift-card.js b/packages/medusa/src/services/gift-card.js index a2f13d31bc..ecd62cf045 100644 --- a/packages/medusa/src/services/gift-card.js +++ b/packages/medusa/src/services/gift-card.js @@ -108,13 +108,6 @@ class GiftCardService extends BaseService { ) } - if (!giftCard.order_id) { - throw new MedusaError( - MedusaError.Types.NOT_FOUND, - `Gift card is missing order_id` - ) - } - // Will throw if region does not exist const region = await this.regionService_.retrieve(giftCard.region_id)