From 193f93464fd6f410e5068ab8615b80126cd1b30c Mon Sep 17 00:00:00 2001
From: Adrien de Peretti <adrien.deperetti@gmail.com>
Date: Thu, 3 Oct 2024 11:00:32 +0200
Subject: [PATCH] fix(core-flows): Remove concurrent steps that rely on the
 same data update (#9438)

**What**
The `updateTaxLinesWorkflow` rely on the cart shipping method meaning that concurrent refresh of shipping method can impact tax lines therefore leading to wrong tax lines
---
 .../src/cart/workflows/add-to-cart.ts         | 21 +++++++++----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/packages/core/core-flows/src/cart/workflows/add-to-cart.ts b/packages/core/core-flows/src/cart/workflows/add-to-cart.ts
index c20ee67f49..d0407723b9 100644
--- a/packages/core/core-flows/src/cart/workflows/add-to-cart.ts
+++ b/packages/core/core-flows/src/cart/workflows/add-to-cart.ts
@@ -3,11 +3,11 @@ import {
   CreateLineItemForCartDTO,
 } from "@medusajs/framework/types"
 import {
-  WorkflowData,
-  WorkflowResponse,
   createWorkflow,
   parallelize,
   transform,
+  WorkflowData,
+  WorkflowResponse,
 } from "@medusajs/framework/workflows-sdk"
 import { useRemoteQueryStep } from "../../common/steps/use-remote-query"
 import {
@@ -120,15 +120,14 @@ export const addToCartWorkflow = createWorkflow(
       list: false,
     }).config({ name: "refetch–cart" })
 
-    parallelize(
-      refreshCartShippingMethodsStep({ cart }),
-      updateTaxLinesWorkflow.runAsStep({
-        input: {
-          cart_id: input.cart.id,
-          items,
-        },
-      })
-    )
+    refreshCartShippingMethodsStep({ cart })
+
+    updateTaxLinesWorkflow.runAsStep({
+      input: {
+        cart_id: input.cart.id,
+        items,
+      },
+    })
 
     updateCartPromotionsWorkflow.runAsStep({
       input: {