From a2b065b3ae5b40b3b8afcab33445568b96781e55 Mon Sep 17 00:00:00 2001 From: Pedro Guzman Date: Mon, 14 Jul 2025 17:28:12 +0200 Subject: [PATCH 1/2] fix: only log server errors --- .../core/framework/src/http/middlewares/error-handler.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/core/framework/src/http/middlewares/error-handler.ts b/packages/core/framework/src/http/middlewares/error-handler.ts index 822d0c1582..60598238b2 100644 --- a/packages/core/framework/src/http/middlewares/error-handler.ts +++ b/packages/core/framework/src/http/middlewares/error-handler.ts @@ -1,9 +1,9 @@ +import { ErrorRequestHandler, NextFunction, Response } from "express" import { fromZodIssue } from "zod-validation-error" -import { NextFunction, ErrorRequestHandler, Response } from "express" import { ContainerRegistrationKeys, MedusaError } from "@medusajs/utils" -import { formatException } from "./exception-formatter" import { MedusaRequest } from "../types" +import { formatException } from "./exception-formatter" const QUERY_RUNNER_RELEASED = "QueryRunnerAlreadyReleasedError" const TRANSACTION_STARTED = "TransactionAlreadyStartedError" @@ -31,7 +31,6 @@ export function errorHandler() { } err = formatException(err) - logger.error(err) const errorType = err.type || err.name const errObj = { @@ -82,6 +81,10 @@ export function errorHandler() { break } + if (statusCode >= 500) { + logger.error(err) + } + if ("issues" in err && Array.isArray(err.issues)) { const messages = err.issues.map((issue) => fromZodIssue(issue).toString()) res.status(statusCode).json({ From c50e63aa17dab0310ed154385a886159ff3fc4e9 Mon Sep 17 00:00:00 2001 From: Pedro Guzman Date: Tue, 15 Jul 2025 09:53:17 +0200 Subject: [PATCH 2/2] fix: log client errors as info --- .../core/framework/src/http/__fixtures__/server/index.ts | 5 +++-- .../core/framework/src/http/middlewares/error-handler.ts | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/core/framework/src/http/__fixtures__/server/index.ts b/packages/core/framework/src/http/__fixtures__/server/index.ts index 153bac8fe9..368151468f 100644 --- a/packages/core/framework/src/http/__fixtures__/server/index.ts +++ b/packages/core/framework/src/http/__fixtures__/server/index.ts @@ -9,14 +9,14 @@ import express from "express" import querystring from "querystring" import supertest from "supertest" -import { config } from "../mocks" import { MedusaContainer } from "@medusajs/types" import { configManager } from "../../../config" import { container } from "../../../container" import { featureFlagsLoader } from "../../../feature-flags" import { logger } from "../../../logger" -import { MedusaRequest } from "../../types" import { ApiLoader } from "../../router" +import { MedusaRequest } from "../../types" +import { config } from "../mocks" function asArray(resolvers) { return { @@ -69,6 +69,7 @@ export const createServer = async (rootDir) => { container.register({ logger: asValue({ error: () => {}, + info: () => {}, }), manager: asValue({}), }) diff --git a/packages/core/framework/src/http/middlewares/error-handler.ts b/packages/core/framework/src/http/middlewares/error-handler.ts index 60598238b2..f46d3d44da 100644 --- a/packages/core/framework/src/http/middlewares/error-handler.ts +++ b/packages/core/framework/src/http/middlewares/error-handler.ts @@ -83,6 +83,8 @@ export function errorHandler() { if (statusCode >= 500) { logger.error(err) + } else { + logger.info(err.message) } if ("issues" in err && Array.isArray(err.issues)) {