From 2187b82d5d68b39636517b860dff63021e59f333 Mon Sep 17 00:00:00 2001
From: Shahed Nasser <shahednasser@gmail.com>
Date: Wed, 22 May 2024 12:27:12 +0300
Subject: [PATCH] fix(core-flows,types): general fixes to workflow types
 (#7392)

---
 .../src/fulfillment/workflows/create-shipping-profiles.ts   | 2 +-
 .../core-flows/src/product/workflows/create-products.ts     | 4 ++--
 .../src/workflow/fulfillment/create-shipping-options.ts     | 6 ++----
 .../types/src/workflow/fulfillment/shipping-profiles.ts     | 4 +++-
 packages/core/types/src/workflow/region/create-regions.ts   | 4 +---
 5 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/packages/core/core-flows/src/fulfillment/workflows/create-shipping-profiles.ts b/packages/core/core-flows/src/fulfillment/workflows/create-shipping-profiles.ts
index d1821c711b..6d27eca6f2 100644
--- a/packages/core/core-flows/src/fulfillment/workflows/create-shipping-profiles.ts
+++ b/packages/core/core-flows/src/fulfillment/workflows/create-shipping-profiles.ts
@@ -8,7 +8,7 @@ export const createShippingProfilesWorkflow = createWorkflow(
   createShippingProfilesWorkflowId,
   (
     input: WorkflowData<FulfillmentWorkflow.CreateShippingProfilesWorkflowInput>
-  ): WorkflowData => {
+  ): WorkflowData<FulfillmentWorkflow.CreateShippingProfilesWorkflowOutput> => {
     const shippingProfiles = createShippingProfilesStep(input.data)
 
     return shippingProfiles
diff --git a/packages/core/core-flows/src/product/workflows/create-products.ts b/packages/core/core-flows/src/product/workflows/create-products.ts
index 4d9aac1e13..fc22f47d0d 100644
--- a/packages/core/core-flows/src/product/workflows/create-products.ts
+++ b/packages/core/core-flows/src/product/workflows/create-products.ts
@@ -1,4 +1,4 @@
-import { ProductTypes, PricingTypes } from "@medusajs/types"
+import { ProductTypes } from "@medusajs/types"
 import {
   WorkflowData,
   createWorkflow,
@@ -8,7 +8,7 @@ import { createProductsStep } from "../steps/create-products"
 import { createVariantPricingLinkStep } from "../steps/create-variant-pricing-link"
 import { createPriceSetsStep } from "../../pricing"
 import { associateProductsWithSalesChannelsStep } from "../../sales-channel"
-import { CreateProductWorkflowInputDTO } from "@medusajs/types/src"
+import { CreateProductWorkflowInputDTO } from "@medusajs/types"
 
 type WorkflowInput = {
   products: CreateProductWorkflowInputDTO[]
diff --git a/packages/core/types/src/workflow/fulfillment/create-shipping-options.ts b/packages/core/types/src/workflow/fulfillment/create-shipping-options.ts
index 8afb89d9c2..bb207b8649 100644
--- a/packages/core/types/src/workflow/fulfillment/create-shipping-options.ts
+++ b/packages/core/types/src/workflow/fulfillment/create-shipping-options.ts
@@ -1,4 +1,4 @@
-import { ShippingOptionPriceType } from "../../fulfillment"
+import { ShippingOptionDTO, ShippingOptionPriceType } from "../../fulfillment"
 import { RuleOperatorType } from "../../common"
 
 export interface CreateShippingOptionsWorkflowInput {
@@ -30,6 +30,4 @@ export interface CreateShippingOptionsWorkflowInput {
   }[]
 }
 
-export type CreateShippingOptionsWorkflowOutput = {
-  id: string
-}[]
+export type CreateShippingOptionsWorkflowOutput = ShippingOptionDTO[]
diff --git a/packages/core/types/src/workflow/fulfillment/shipping-profiles.ts b/packages/core/types/src/workflow/fulfillment/shipping-profiles.ts
index 2def6b6380..3c57e881e0 100644
--- a/packages/core/types/src/workflow/fulfillment/shipping-profiles.ts
+++ b/packages/core/types/src/workflow/fulfillment/shipping-profiles.ts
@@ -1,4 +1,4 @@
-import { FilterableShippingProfileProps } from "../../fulfillment"
+import { FilterableShippingProfileProps, ShippingProfileDTO } from "../../fulfillment"
 
 interface CreateShippingProfile {
   name: string
@@ -9,6 +9,8 @@ export interface CreateShippingProfilesWorkflowInput {
   data: CreateShippingProfile[]
 }
 
+export type CreateShippingProfilesWorkflowOutput = ShippingProfileDTO[]
+
 interface UpdateShippingProfile {
   name?: string
   type?: string
diff --git a/packages/core/types/src/workflow/region/create-regions.ts b/packages/core/types/src/workflow/region/create-regions.ts
index 779ad4f12e..8a990449fd 100644
--- a/packages/core/types/src/workflow/region/create-regions.ts
+++ b/packages/core/types/src/workflow/region/create-regions.ts
@@ -1,9 +1,7 @@
 import { CreateRegionDTO, RegionDTO } from "../../region"
 
 export interface CreateRegionsWorkflowInput {
-  regions: (CreateRegionDTO & {
-    payment_providers?: string[]
-  })[]
+  regions: CreateRegionDTO[]
 }
 
 export type CreateRegionsWorkflowOutput = RegionDTO[]