fix(types, medusa): fixes to draft order request types (#8949)

- remove the `name` filter for orders (couldn't find any `name` property in the order data model).
- Remove the `order_id` property of a shipping method in the request body type for creating a draft order
- Update the types of `fulfillment_status` and `payment_status` in the order filters to showcase the possible status values.
This commit is contained in:
Shahed Nasser
2024-09-02 17:09:41 +00:00
committed by GitHub
parent d88e6474e9
commit 29555ae518
2 changed files with 3 additions and 5 deletions
@@ -1,14 +1,14 @@
import { OperatorMap } from "../../../dal" import { OperatorMap } from "../../../dal"
import { FulfillmentStatus, PaymentStatus } from "../../../order"
import { FindParams } from "../../common" import { FindParams } from "../../common"
import { BaseOrderFilters } from "../common" import { BaseOrderFilters } from "../common"
import { BaseOrderChangesFilters } from "../common" import { BaseOrderChangesFilters } from "../common"
export interface AdminOrderFilters extends FindParams, BaseOrderFilters { export interface AdminOrderFilters extends FindParams, BaseOrderFilters {
id?: string[] | string id?: string[] | string
name?: string[] | string
sales_channel_id?: string[] sales_channel_id?: string[]
fulfillment_status?: string[] fulfillment_status?: FulfillmentStatus[]
payment_status?: string[] payment_status?: PaymentStatus[]
region_id?: string[] region_id?: string[]
q?: string q?: string
created_at?: OperatorMap<string> created_at?: OperatorMap<string>
@@ -16,7 +16,6 @@ export const AdminGetOrdersParams = createFindParams({
}).merge( }).merge(
z.object({ z.object({
id: z.union([z.string(), z.array(z.string())]).optional(), id: z.union([z.string(), z.array(z.string())]).optional(),
name: z.union([z.string(), z.array(z.string())]).optional(),
$and: z.lazy(() => AdminGetOrdersParams.array()).optional(), $and: z.lazy(() => AdminGetOrdersParams.array()).optional(),
$or: z.lazy(() => AdminGetOrdersParams.array()).optional(), $or: z.lazy(() => AdminGetOrdersParams.array()).optional(),
}) })
@@ -28,7 +27,6 @@ enum Status {
const ShippingMethod = z.object({ const ShippingMethod = z.object({
shipping_method_id: z.string().nullish(), shipping_method_id: z.string().nullish(),
order_id: z.string().nullish(),
name: z.string(), name: z.string(),
shipping_option_id: z.string(), shipping_option_id: z.string(),
data: z.record(z.string(), z.unknown()).optional(), data: z.record(z.string(), z.unknown()).optional(),