fix: make packages/medusa/src/api/routes/admin/returns pass eslint (#653)

.eslintignore

@@ -28,7 +28,6 @@
 /packages/medusa/src/api/routes/admin/collections
 /packages/medusa/src/api/routes/admin/notes
 /packages/medusa/src/api/routes/admin/orders
-/packages/medusa/src/api/routes/admin/returns
 /packages/medusa/src/api/routes/admin/shipping-profiles
 /packages/medusa/src/api/routes/admin/store
 /packages/medusa/src/api/routes/store/carts

packages/medusa/src/api/routes/admin/returns/cancel-return.js

@@ -1,5 +1,3 @@
-import { result } from "lodash"
-import { MedusaError, Validator } from "medusa-core-utils"
 import { defaultFields, defaultRelations } from "../orders"
 
 /**
@@ -24,7 +22,6 @@ import { defaultFields, defaultRelations } from "../orders"
 export default async (req, res) => {
   const { id } = req.params
 
-  try {
   const returnService = req.scope.resolve("returnService")
   const orderService = req.scope.resolve("orderService")
 
@@ -44,7 +41,4 @@ export default async (req, res) => {
   })
 
   res.status(200).json({ order })
-  } catch (err) {
-    throw err
-  }
 }

packages/medusa/src/api/routes/admin/returns/index.js

@@ -3,7 +3,7 @@ import middlewares from "../../../middlewares"
 
 const route = Router()
 
-export default app => {
+export default (app) => {
   app.use("/returns", route)
 
   /**

packages/medusa/src/api/routes/admin/returns/list-returns.js

@@ -1,5 +1,3 @@
-import _ from "lodash"
-
 /**
  * @oas [get] /returns
  * operationId: "GetReturns"
@@ -20,7 +18,6 @@ import _ from "lodash"
  *                 $ref: "#/components/schemas/return"
  */
 export default async (req, res) => {
-  try {
   const returnService = req.scope.resolve("returnService")
 
   const limit = parseInt(req.query.limit) || 50
@@ -38,7 +35,4 @@ export default async (req, res) => {
   const returns = await returnService.list(selector, { ...listConfig })
 
   res.json({ returns, count: returns.length, offset, limit })
-  } catch (error) {
-    throw error
-  }
 }

packages/medusa/src/api/routes/admin/returns/receive-return.js

@@ -48,9 +48,7 @@ export default async (req, res) => {
         quantity: Validator.number().required(),
       })
       .required(),
-    refund: Validator.number()
+    refund: Validator.number().integer().optional(),
-      .integer()
-      .optional(),
   })
 
   const { value, error } = schema.validate(req.body)
@@ -59,14 +57,13 @@ export default async (req, res) => {
     throw new MedusaError(MedusaError.Types.INVALID_DATA, error.details)
   }
 
-  try {
   const returnService = req.scope.resolve("returnService")
   const orderService = req.scope.resolve("orderService")
   const swapService = req.scope.resolve("swapService")
   const entityManager = req.scope.resolve("manager")
 
   let receivedReturn
-    await entityManager.transaction(async manager => {
+  await entityManager.transaction(async (manager) => {
     let refundAmount = value.refund
 
     if (typeof value.refund !== "undefined" && value.refund < 0) {
@@ -97,7 +94,4 @@ export default async (req, res) => {
   receivedReturn = await returnService.retrieve(id, { relations: ["swap"] })
 
   res.status(200).json({ return: receivedReturn })
-  } catch (err) {
-    throw err
-  }
 }