From 300ef8dbb90a699fdb7a53adffd5d95e0385263f Mon Sep 17 00:00:00 2001
From: Harminder Virk <virk.officials@gmail.com>
Date: Mon, 4 Nov 2024 14:56:57 +0530
Subject: [PATCH] fix: consider --host flag and HOST env variable (#9912)

---
 packages/cli/medusa-cli/src/create-cli.ts | 12 ++++++++----
 packages/medusa/src/commands/start.ts     | 18 ++++++++++++------
 2 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/packages/cli/medusa-cli/src/create-cli.ts b/packages/cli/medusa-cli/src/create-cli.ts
index a62c780ddf..333879fdd5 100644
--- a/packages/cli/medusa-cli/src/create-cli.ts
+++ b/packages/cli/medusa-cli/src/create-cli.ts
@@ -290,8 +290,10 @@ function buildLocalCommands(cli, isLocalProject) {
           .option(`H`, {
             alias: `host`,
             type: `string`,
-            default: defaultHost,
-            describe: `Set host. Defaults to ${defaultHost}`,
+            default: process.env.HOST || defaultHost,
+            describe: process.env.HOST
+              ? `Set host. Defaults to ${process.env.HOST} (set by env.HOST) (otherwise defaults ${defaultHost})`
+              : `Set host. Defaults to ${defaultHost}`,
           })
           .option(`p`, {
             alias: `port`,
@@ -326,8 +328,10 @@ function buildLocalCommands(cli, isLocalProject) {
           .option(`H`, {
             alias: `host`,
             type: `string`,
-            default: defaultHost,
-            describe: `Set host. Defaults to ${defaultHost}`,
+            default: process.env.HOST || defaultHost,
+            describe: process.env.HOST
+              ? `Set host. Defaults to ${process.env.HOST} (set by env.HOST) (otherwise defaults ${defaultHost})`
+              : `Set host. Defaults to ${defaultHost}`,
           })
           .option(`p`, {
             alias: `port`,
diff --git a/packages/medusa/src/commands/start.ts b/packages/medusa/src/commands/start.ts
index 3e58911891..8a686218a4 100644
--- a/packages/medusa/src/commands/start.ts
+++ b/packages/medusa/src/commands/start.ts
@@ -59,9 +59,11 @@ export async function registerInstrumentation(directory: string) {
 export var traceRequestHandler: (...args: any[]) => Promise<any> = void 0 as any
 
 function displayAdminUrl({
-  container,
+  host,
   port,
+  container,
 }: {
+  host: string
   port: string | number
   container: MedusaContainer
 }) {
@@ -82,16 +84,17 @@ function displayAdminUrl({
     return
   }
 
-  logger.info(`Admin URL → http://localhost:${port}${adminPath}`)
+  logger.info(`Admin URL → http://${host}:${port}${adminPath}`)
 }
 
 async function start(args: {
   directory: string
+  host?: string
   port?: number
   types?: boolean
   cluster?: number
 }) {
-  const { port = 9000, directory, types } = args
+  const { port = 9000, host = "localhost", directory, types } = args
 
   async function internalStart(generateTypes: boolean) {
     track("CLI_START")
@@ -136,9 +139,12 @@ async function start(args: {
 
       const serverActivity = logger.activity(`Creating server`)
       const server = GracefulShutdownServer.create(
-        http_.listen(port).on("listening", () => {
-          logger.success(serverActivity, `Server is ready on port: ${port}`)
-          displayAdminUrl({ container, port })
+        http_.listen(port, host).on("listening", () => {
+          logger.success(
+            serverActivity,
+            `Server is ready on http://${host}:${port}`
+          )
+          displayAdminUrl({ container, host, port })
           track("CLI_START_COMPLETED")
         })
       )