From 370bd472ed8c9038f66defd012a886e0f83c32cf Mon Sep 17 00:00:00 2001 From: pepijn-vanvlaanderen Date: Tue, 28 Feb 2023 08:53:51 +0100 Subject: [PATCH] fix(medusa): Fix regression in job scheduler service (#3335) The queue registration of jobs has stopped working due to a small issue in how the jobs are added to the queue. Co-authored-by: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com> --- .changeset/green-crabs-fly.md | 5 +++++ packages/medusa/src/services/__tests__/job-scheduler.js | 9 +++++++++ packages/medusa/src/services/job-scheduler.ts | 4 ++-- 3 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 .changeset/green-crabs-fly.md diff --git a/.changeset/green-crabs-fly.md b/.changeset/green-crabs-fly.md new file mode 100644 index 0000000000..391bf47cbf --- /dev/null +++ b/.changeset/green-crabs-fly.md @@ -0,0 +1,5 @@ +--- +"@medusajs/medusa": patch +--- + +fix(medusa): Fix regression in job scheduler service diff --git a/packages/medusa/src/services/__tests__/job-scheduler.js b/packages/medusa/src/services/__tests__/job-scheduler.js index 75e2a934da..a4d89ee5a6 100644 --- a/packages/medusa/src/services/__tests__/job-scheduler.js +++ b/packages/medusa/src/services/__tests__/job-scheduler.js @@ -53,6 +53,15 @@ describe("JobSchedulerService", () => { it("added the handler to the job queue", () => { expect(jobScheduler.handlers_.get("eventName").length).toEqual(1) + expect(jobScheduler.queue_.add).toHaveBeenCalledWith( + { + eventName: "eventName", + data: { data: "test" }, + }, + { + repeat: { cron: "* * * * *" }, + } + ) }) }) diff --git a/packages/medusa/src/services/job-scheduler.ts b/packages/medusa/src/services/job-scheduler.ts index 90062d2503..4acfa01bdb 100644 --- a/packages/medusa/src/services/job-scheduler.ts +++ b/packages/medusa/src/services/job-scheduler.ts @@ -123,7 +123,7 @@ export default class JobSchedulerService { const repeatOpts = { repeat: { cron: schedule } } if (options?.keepExisting) { - return await this.queue_.add(eventName, jobToCreate, repeatOpts) + return await this.queue_.add(jobToCreate, repeatOpts) } const existingJobs = (await this.queue_.getRepeatableJobs()) ?? [] @@ -134,6 +134,6 @@ export default class JobSchedulerService { await this.queue_.removeRepeatableByKey(existingJob.key) } - return await this.queue_.add(eventName, jobToCreate, repeatOpts) + return await this.queue_.add(jobToCreate, repeatOpts) } }