From 47603f479731ad495938b056da7a493991a1d9a9 Mon Sep 17 00:00:00 2001 From: "Carlos R. L. Rodrigues" <37986729+carlos-r-l-rodrigues@users.noreply.github.com> Date: Wed, 20 Sep 2023 05:20:46 -0300 Subject: [PATCH] fix(modules-sdk): medusa app load legacy modules (#5115) * fix: default module path * fix: allow legacy modules to be loaded by MedusaApp * changeset --------- Co-authored-by: Adrien de Peretti --- .changeset/lucky-bulldogs-juggle.md | 5 +++++ packages/modules-sdk/src/loaders/register-modules.ts | 6 ------ 2 files changed, 5 insertions(+), 6 deletions(-) create mode 100644 .changeset/lucky-bulldogs-juggle.md diff --git a/.changeset/lucky-bulldogs-juggle.md b/.changeset/lucky-bulldogs-juggle.md new file mode 100644 index 0000000000..4ee2a54d00 --- /dev/null +++ b/.changeset/lucky-bulldogs-juggle.md @@ -0,0 +1,5 @@ +--- +"@medusajs/modules-sdk": patch +--- + +Allow MedusaApp load legacy modules diff --git a/packages/modules-sdk/src/loaders/register-modules.ts b/packages/modules-sdk/src/loaders/register-modules.ts index e4a46d4052..a1ba16711b 100644 --- a/packages/modules-sdk/src/loaders/register-modules.ts +++ b/packages/modules-sdk/src/loaders/register-modules.ts @@ -73,12 +73,6 @@ export const registerMedusaModule = ( throw new Error(`Module: ${moduleKey} is not defined.`) } - if (modDefinition.isLegacy) { - throw new Error( - `Module: ${moduleKey} is a legacy module. Please use registerModules instead.` - ) - } - if ( isObject(moduleDeclaration) && moduleDeclaration?.scope === MODULE_SCOPE.EXTERNAL