asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(medusa): sales_channel_id middleware manipulation (#12234)

Browse Source 
* fix(medusa): sales_channel_id middleware manipulation leading to lost of the sc

* fix(medusa): sales_channel_id middleware manipulation leading to lost of the sc

* add unit tests

* add unit tests

* improve

* integration tests
This commit is contained in:
Adrien de Peretti
2025-04-20 17:42:59 +02:00
committed by GitHub
parent a8a7af46a6
commit 49c526399e
5 changed files with 494 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
integration-tests/http/__tests__/product/store/product.spec.ts
View File

@@ -1478,7 +1478,7 @@ medusaIntegrationTestRunner({
describe("with inventory items", () => {
let location1
let location2
let salesChannel1
let salesChannel1, salesChannel2
let publishableKey1
beforeEach(async () => {
@@ -1503,6 +1503,11 @@ medusaIntegrationTestRunner({
[product.id, product2.id]
)
salesChannel2 = await createSalesChannel(
{ name: "sales channel test 2" },
[product.id, product2.id]
)
const api1Res = await api.post(
`/admin/api-keys`,
{ title: "Test publishable KEY", type: ApiKeyType.PUBLISHABLE },
@@ -1721,6 +1726,63 @@ medusaIntegrationTestRunner({
)
})
it("should list all inventory items for a variant in a given sales channel passed as a query param AND when there are multiple sales channels associated with the publishable key", async () => {
await api.post(
`/admin/api-keys/${publishableKey1.id}/sales-channels`,
{ add: [salesChannel2.id] },
adminHeaders
)
let response = await api.get(
`/store/products?sales_channel_id[]=${salesChannel1.id}&fields=variants.inventory_items.inventory.location_levels.*`,
{ headers: { "x-publishable-api-key": publishableKey1.token } }
)
expect(response.status).toEqual(200)
expect(response.data.count).toEqual(2)
expect(response.data.products).toEqual(
expect.arrayContaining([
expect.objectContaining({
id: product.id,
variants: expect.arrayContaining([
expect.objectContaining({
inventory_items: expect.arrayContaining([
expect.objectContaining({
inventory_item_id: inventoryItem1.id,
}),
expect.objectContaining({
inventory_item_id: inventoryItem2.id,
}),
]),
}),
]),
}),
])
)
})
it("should throw when multiple sales channels are passed as a query param AND there are multiple sales channels associated with the publishable key", async () => {
await api.post(
`/admin/api-keys/${publishableKey1.id}/sales-channels`,
{ add: [salesChannel2.id] },
adminHeaders
)
let error = await api
.get(
`/store/products?sales_channel_id[]=${salesChannel1.id}&sales_channel_id[]=${salesChannel2.id}&fields=variants.inventory_quantity`,
{ headers: { "x-publishable-api-key": publishableKey1.token } }
)
.catch((e) => e)
expect(error.response.status).toEqual(400)
expect(error.response.data).toEqual({
message:
"Inventory availability cannot be calculated in the given context. Either provide a single sales channel id or configure a single sales channel in the publishable key",
type: "invalid_data",
})
})
it("should return inventory quantity when variant's manage_inventory is true", async () => {
await api.post(
`/admin/products/${product.id}/variants/${variant.id}/inventory-items`,