From 4c3389e1e635ec8be967c4ae582174e162ac1c0c Mon Sep 17 00:00:00 2001 From: Sebastian Rindom Date: Fri, 22 Mar 2024 15:57:34 +0100 Subject: [PATCH] fix: revert no server start (#6790) **Why** - we want to start a server so we can allow health checks on workers --- packages/medusa/src/commands/start.js | 59 ++++++++++++--------------- 1 file changed, 26 insertions(+), 33 deletions(-) diff --git a/packages/medusa/src/commands/start.js b/packages/medusa/src/commands/start.js index 41e70fc626..9e421fed45 100644 --- a/packages/medusa/src/commands/start.js +++ b/packages/medusa/src/commands/start.js @@ -24,47 +24,40 @@ export default async function ({ port, directory }) { expressApp: app, }) - const shouldStartServer = - configModule.projectConfig.worker_mode !== "worker" - let server - if (shouldStartServer) { - const serverActivity = Logger.activity(`Creating server`) - server = GracefulShutdownServer.create( - app.listen(port, (err) => { - if (err) { - return - } - Logger.success(serverActivity, `Server is ready on port: ${port}`) - track("CLI_START_COMPLETED") + const serverActivity = Logger.activity(`Creating server`) + server = GracefulShutdownServer.create( + app.listen(port, (err) => { + if (err) { + return + } + Logger.success(serverActivity, `Server is ready on port: ${port}`) + track("CLI_START_COMPLETED") + }) + ) + + // Handle graceful shutdown + const gracefulShutDown = () => { + server + .shutdown() + .then(() => { + Logger.info("Gracefully stopping the server.") + process.exit(0) + }) + .catch((e) => { + Logger.error("Error received when shutting down the server.", e) + process.exit(1) }) - ) - - // Handle graceful shutdown - const gracefulShutDown = () => { - server - .shutdown() - .then(() => { - Logger.info("Gracefully stopping the server.") - process.exit(0) - }) - .catch((e) => { - Logger.error("Error received when shutting down the server.", e) - process.exit(1) - }) - } - - process.on("SIGTERM", gracefulShutDown) - process.on("SIGINT", gracefulShutDown) - } else { - Logger.info("Running in worker mode, server will not be started.") } + process.on("SIGTERM", gracefulShutDown) + process.on("SIGINT", gracefulShutDown) + scheduleJob(CRON_SCHEDULE, () => { track("PING") }) - return shouldStartServer ? { dbConnection, server } : { dbConnection } + return { dbConnection, server } } catch (err) { Logger.error("Error starting server", err) process.exit(1)