From 4c43122358a29bf47a2bc3c271b24759803b86b4 Mon Sep 17 00:00:00 2001 From: "Carlos R. L. Rodrigues" <37986729+carlos-r-l-rodrigues@users.noreply.github.com> Date: Thu, 22 Aug 2024 08:32:27 -0300 Subject: [PATCH] chore(core-flows): order edit - remove item update action (#8722) --- .../order-edit/remove-order-edit-item-action.ts | 10 ++++++++-- packages/core/types/src/order/common.ts | 1 - 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/core/core-flows/src/order/workflows/order-edit/remove-order-edit-item-action.ts b/packages/core/core-flows/src/order/workflows/order-edit/remove-order-edit-item-action.ts index f808d4857a..87476dd2e4 100644 --- a/packages/core/core-flows/src/order/workflows/order-edit/remove-order-edit-item-action.ts +++ b/packages/core/core-flows/src/order/workflows/order-edit/remove-order-edit-item-action.ts @@ -47,8 +47,14 @@ export const removeOrderEditItemActionValidationStep = createStep( throw new Error( `No item found for order ${input.order_id} in order change ${orderChange.id}` ) - } else if (associatedAction.action !== ChangeActionType.ITEM_ADD) { - throw new Error(`Action ${associatedAction.id} is not adding an item`) + } else if ( + ![ChangeActionType.ITEM_ADD, ChangeActionType.ITEM_UPDATE].includes( + associatedAction.action as ChangeActionType + ) + ) { + throw new Error( + `Action ${associatedAction.id} is not adding or updating an item` + ) } } ) diff --git a/packages/core/types/src/order/common.ts b/packages/core/types/src/order/common.ts index e091439d96..336633cd80 100644 --- a/packages/core/types/src/order/common.ts +++ b/packages/core/types/src/order/common.ts @@ -9,7 +9,6 @@ import { ClaimReason } from "./mutations" * The change action's type. */ export type ChangeActionType = - | "CANCEL" | "CANCEL_RETURN_ITEM" | "FULFILL_ITEM" | "CANCEL_ITEM_FULFILLMENT"