asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: normalize path before consuming it while loading models (#8194)

Browse Source 
* fix: normalize path before consuming it while loading models

* Make it so that models derived from the service if present

* fix linkable tests that now match what has been passed to the medusa service if there is no custom joiner config

* fix linkable tests that now match what has been passed to the medusa service if there is no custom joiner config

* fix linkable tests that now match what has been passed to the medusa service if there is no custom joiner config
This commit is contained in:
Adrien de Peretti
2024-07-21 21:21:05 +02:00
committed by GitHub
parent 2f56030101
commit 566300d54b
7 changed files with 203 additions and 248 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/modules/tax/integration-tests/__tests__/index.spec.ts
+44 -36
View File
@@ -16,10 +16,10 @@ moduleIntegrationTestRunner<ITaxModuleService>({
}).linkable
expect(Object.keys(linkable)).toEqual([
"taxProvider",
"taxRateRule",
"taxRate",
"taxRegion",
"taxRateRule",
"taxProvider",
])
Object.keys(linkable).forEach((key) => {
@@ -27,22 +27,6 @@ moduleIntegrationTestRunner<ITaxModuleService>({
})
expect(linkable).toEqual({
taxProvider: {
id: {
linkable: "tax_provider_id",
primaryKey: "id",
serviceName: "tax",
field: "taxProvider",
},
},
taxRateRule: {
id: {
linkable: "tax_rate_rule_id",
primaryKey: "id",
serviceName: "tax",
field: "taxRateRule",
},
},
taxRate: {
id: {
linkable: "tax_rate_id",
@@ -59,6 +43,22 @@ moduleIntegrationTestRunner<ITaxModuleService>({
field: "taxRegion",
},
},
taxRateRule: {
id: {
linkable: "tax_rate_rule_id",
primaryKey: "id",
serviceName: "tax",
field: "taxRateRule",
},
},
taxProvider: {
id: {
linkable: "tax_provider_id",
primaryKey: "id",
serviceName: "tax",
field: "taxProvider",
},
},
})
})
@@ -214,15 +214,19 @@ moduleIntegrationTestRunner<ITaxModuleService>({
},
})
const error = await service.createTaxRegions({
country_code: "US",
default_tax_rate: {
name: "Test Rate",
rate: 0.2,
},
}).catch(e => e)
const error = await service
.createTaxRegions({
country_code: "US",
default_tax_rate: {
name: "Test Rate",
rate: 0.2,
},
})
.catch((e) => e)
expect(error.message).toEqual("Tax region with country_code: us, already exists.")
expect(error.message).toEqual(
"Tax region with country_code: us, already exists."
)
})
it("should throw when creating a tax region with a country code and province code of an existing region", async () => {
@@ -235,18 +239,22 @@ moduleIntegrationTestRunner<ITaxModuleService>({
},
})
const error = await service.createTaxRegions({
country_code: "US",
province_code: "CA",
default_tax_rate: {
name: "Test Rate",
rate: 0.2,
},
}).catch(e => e)
const error = await service
.createTaxRegions({
country_code: "US",
province_code: "CA",
default_tax_rate: {
name: "Test Rate",
rate: 0.2,
},
})
.catch((e) => e)
expect(error.message).toEqual("Tax region with country_code: us, province_code: ca, already exists.")
expect(error.message).toEqual(
"Tax region with country_code: us, province_code: ca, already exists."
)
})
it("should create tax rates and update them", async () => {
const region = await service.createTaxRegions({
country_code: "US",