fix(product): Serialize typings (#4602)

What:
Fix the serializer

.changeset/dirty-pumas-push.md

@@ -0,0 +1,6 @@
+---
+"@medusajs/product": patch
+"@medusajs/types": patch
+---
+
+fix(product): Serialize typings

packages/product/src/repositories/base.ts

@@ -74,16 +74,13 @@ const updateDeletedAtRecursively = async <T extends object = any>(
   }
 }
 
-const serializer = <
+const serializer = <TOutput extends object>(
-  T extends object | object[],
+  data: any,
-  TResult extends object | object[]
->(
-  data: T,
   options?: any
-): Promise<TResult> => {
+): Promise<TOutput> => {
   options ??= {}
   const result = serialize(data, options)
-  return Array.isArray(data) ? result : result[0]
+  return result as unknown as Promise<TOutput>
 }
 
 export abstract class AbstractBaseRepository<T = any>
@@ -110,11 +107,11 @@ export abstract class AbstractBaseRepository<T = any>
     return await transactionWrapper.apply(this, arguments)
   }
 
-  serialize<
+  async serialize<TOutput extends object | object[]>(
-    TData extends object | object[] = object[],
+    data: any,
-    TResult extends object | object[] = object[]
+    options?: any
-  >(data: TData, options?: any): Promise<TResult> {
+  ): Promise<TOutput> {
-    return serializer<TData, TResult>(data, options)
+    return await serializer<TOutput>(data, options)
   }
 
   abstract find(options?: DAL.FindOptions<T>, context?: Context)
@@ -203,13 +200,6 @@ export class BaseRepository extends AbstractBaseRepository {
     super(...arguments)
   }
 
-  serialize<
-    TData extends object | object[] = object[],
-    TResult extends object | object[] = object[]
-  >(data: TData, options?: any): Promise<TResult> {
-    return serializer<TData, TResult>(data, options)
-  }
-
   create(data: unknown[], context?: Context): Promise<any[]> {
     throw new Error("Method not implemented.")
   }

packages/product/src/services/product-module-service.ts

@@ -285,10 +285,7 @@ export default class ProductModuleService<
   async create(data: ProductTypes.CreateProductDTO[], sharedContext?: Context) {
     const products = await this.create_(data, sharedContext)
 
-    return this.baseRepository_.serialize<
+    return this.baseRepository_.serialize<ProductTypes.ProductDTO[]>(products, {
-      TProduct[],
-      ProductTypes.ProductDTO[]
-    >(products, {
       populate: true,
     })
   }
@@ -425,10 +422,7 @@ export default class ProductModuleService<
   ): Promise<ProductTypes.ProductDTO[]> {
     const products = await this.softDelete_(productIds, sharedContext)
 
-    return this.baseRepository_.serialize<
+    return this.baseRepository_.serialize<ProductTypes.ProductDTO[]>(products, {
-      TProduct[],
-      ProductTypes.ProductDTO[]
-    >(products, {
       populate: true,
     })
   }
@@ -447,10 +441,7 @@ export default class ProductModuleService<
   ): Promise<ProductTypes.ProductDTO[]> {
     const products = await this.restore_(productIds, sharedContext)
 
-    return this.baseRepository_.serialize<
+    return this.baseRepository_.serialize<ProductTypes.ProductDTO[]>(products, {
-      TProduct[],
-      ProductTypes.ProductDTO[]
-    >(products, {
       populate: true,
     })
   }

packages/types/src/dal/repository-service.ts

@@ -17,15 +17,10 @@ export interface RepositoryService<T = any> {
     }
   ): Promise<any>
 
-  serialize<TData extends object, TResult extends object, TOptions = any>(
+  serialize<TOutput extends object | object[]>(
-    data: TData,
+    data: any,
-    options?: TOptions
+    options?: any
-  ): Promise<TResult>
+  ): Promise<TOutput>
-
-  serialize<TData extends object[], TResult extends object[], TOptions = any>(
-    data: TData[],
-    options?: TOptions
-  ): Promise<TResult>
 
   find(options?: FindOptions<T>, context?: Context): Promise<T[]>