From 5ad7347408746fd717354c99a530aaab5e86ffa2 Mon Sep 17 00:00:00 2001 From: Shahed Nasser Date: Thu, 15 Jun 2023 22:15:19 +0300 Subject: [PATCH] fix(create-medusa-app): disable opening browser (#4321) --- .changeset/cool-mayflies-listen.md | 5 ++ .../create-medusa-app/src/commands/create.ts | 58 ++++++++++--------- 2 files changed, 37 insertions(+), 26 deletions(-) create mode 100644 .changeset/cool-mayflies-listen.md diff --git a/.changeset/cool-mayflies-listen.md b/.changeset/cool-mayflies-listen.md new file mode 100644 index 0000000000..db1db22248 --- /dev/null +++ b/.changeset/cool-mayflies-listen.md @@ -0,0 +1,5 @@ +--- +"create-medusa-app": patch +--- + +fix(create-medusa-app): disable opening browser diff --git a/packages/create-medusa-app/src/commands/create.ts b/packages/create-medusa-app/src/commands/create.ts index 96c733b775..4207712c64 100644 --- a/packages/create-medusa-app/src/commands/create.ts +++ b/packages/create-medusa-app/src/commands/create.ts @@ -34,7 +34,12 @@ type CreateOptions = { boilerplate?: boolean } -export default async ({ repoUrl = "", seed, boilerplate }: CreateOptions) => { +export default async ({ + repoUrl = "", + // TODO remove default value later + seed = true, + boilerplate, +}: CreateOptions) => { track("CREATE_CLI") if (repoUrl) { track("STARTER_SELECTED", { starter: repoUrl }) @@ -113,19 +118,20 @@ export default async ({ repoUrl = "", seed, boilerplate }: CreateOptions) => { } } - const { adminEmail } = await inquirer.prompt([ - { - type: "input", - name: "adminEmail", - message: "Enter an email for your admin dashboard user", - default: !seed && boilerplate ? "admin@medusa-test.com" : undefined, - validate: (input) => { - return typeof input === "string" && input.length > 0 && isEmail(input) - ? true - : "Please enter a valid email" - }, - }, - ]) + // TODO enable this later + // const { adminEmail } = await inquirer.prompt([ + // { + // type: "input", + // name: "adminEmail", + // message: "Enter an email for your admin dashboard user", + // default: !seed && boilerplate ? "admin@medusa-test.com" : undefined, + // validate: (input) => { + // return typeof input === "string" && input.length > 0 && isEmail(input) + // ? true + // : "Please enter a valid email" + // }, + // }, + // ]) logMessage({ message: `${emojify( @@ -208,9 +214,9 @@ export default async ({ repoUrl = "", seed, boilerplate }: CreateOptions) => { inviteToken = await prepareProject({ directory: projectName, dbConnectionString, - admin: { - email: adminEmail, - }, + // admin: { + // email: adminEmail, + // }, seed, boilerplate, spinner, @@ -279,13 +285,13 @@ export default async ({ repoUrl = "", seed, boilerplate }: CreateOptions) => { } }) - await waitOn({ - resources: ["http://localhost:9000/health"], - }).then(async () => - open( - inviteToken - ? `http://localhost:7001/invite?token=${inviteToken}&first_run=true` - : "http://localhost:7001" - ) - ) + // await waitOn({ + // resources: ["http://localhost:9000/health"], + // }).then(async () => + // open( + // inviteToken + // ? `http://localhost:7001/invite?token=${inviteToken}&first_run=true` + // : "http://localhost:7001" + // ) + // ) }