From 5b0c6e6a948ed1ecb45862a2d5f3f01cb810d21c Mon Sep 17 00:00:00 2001
From: Shahed Nasser <shahednasser@gmail.com>
Date: Tue, 28 Oct 2025 11:02:28 +0200
Subject: [PATCH] chore: fixes to HTTP and request types for API Keys (#13819)

---
 packages/core/types/src/http/api-key/admin/payloads.ts    | 3 +++
 .../medusa/src/api/admin/api-keys/[id]/revoke/route.ts    | 6 ++++--
 packages/medusa/src/api/admin/api-keys/[id]/route.ts      | 8 +++++---
 .../src/api/admin/api-keys/[id]/sales-channels/route.ts   | 7 +++++--
 4 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/packages/core/types/src/http/api-key/admin/payloads.ts b/packages/core/types/src/http/api-key/admin/payloads.ts
index 53b5a10110..7103e98c46 100644
--- a/packages/core/types/src/http/api-key/admin/payloads.ts
+++ b/packages/core/types/src/http/api-key/admin/payloads.ts
@@ -19,5 +19,8 @@ export interface AdminUpdateApiKey {
 }
 
 export interface AdminRevokeApiKey {
+  /**
+   * The number of seconds to wait before revoking the API key.
+   */
   revoke_in?: number
 }
diff --git a/packages/medusa/src/api/admin/api-keys/[id]/revoke/route.ts b/packages/medusa/src/api/admin/api-keys/[id]/revoke/route.ts
index ee45147314..be942ca01c 100644
--- a/packages/medusa/src/api/admin/api-keys/[id]/revoke/route.ts
+++ b/packages/medusa/src/api/admin/api-keys/[id]/revoke/route.ts
@@ -3,12 +3,14 @@ import {
   AuthenticatedMedusaRequest,
   MedusaResponse,
 } from "@medusajs/framework/http"
-import { AdminRevokeApiKeyType } from "../../validators"
 import { refetchApiKey } from "../../helpers"
 import { HttpTypes } from "@medusajs/framework/types"
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<AdminRevokeApiKeyType>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminRevokeApiKey,
+    HttpTypes.SelectParams
+  >,
   res: MedusaResponse<HttpTypes.AdminApiKeyResponse>
 ) => {
   await revokeApiKeysWorkflow(req.scope).run({
diff --git a/packages/medusa/src/api/admin/api-keys/[id]/route.ts b/packages/medusa/src/api/admin/api-keys/[id]/route.ts
index 6cb01ad194..c11e9e43b2 100644
--- a/packages/medusa/src/api/admin/api-keys/[id]/route.ts
+++ b/packages/medusa/src/api/admin/api-keys/[id]/route.ts
@@ -8,12 +8,11 @@ import {
 } from "@medusajs/framework/http"
 
 import { refetchApiKey } from "../helpers"
-import { AdminUpdateApiKeyType } from "../validators"
 import { MedusaError } from "@medusajs/framework/utils"
 import { HttpTypes } from "@medusajs/framework/types"
 
 export const GET = async (
-  req: AuthenticatedMedusaRequest,
+  req: AuthenticatedMedusaRequest<HttpTypes.SelectParams>,
   res: MedusaResponse<HttpTypes.AdminApiKeyResponse>
 ) => {
   const apiKey = await refetchApiKey(
@@ -33,7 +32,10 @@ export const GET = async (
 }
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<AdminUpdateApiKeyType>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminUpdateApiKey,
+    HttpTypes.SelectParams
+  >,
   res: MedusaResponse<HttpTypes.AdminApiKeyResponse>
 ) => {
   await updateApiKeysWorkflow(req.scope).run({
diff --git a/packages/medusa/src/api/admin/api-keys/[id]/sales-channels/route.ts b/packages/medusa/src/api/admin/api-keys/[id]/sales-channels/route.ts
index 5b8af4d47e..95ac90da25 100644
--- a/packages/medusa/src/api/admin/api-keys/[id]/sales-channels/route.ts
+++ b/packages/medusa/src/api/admin/api-keys/[id]/sales-channels/route.ts
@@ -1,5 +1,5 @@
 import { linkSalesChannelsToApiKeyWorkflow } from "@medusajs/core-flows"
-import { HttpTypes, LinkMethodRequest } from "@medusajs/framework/types"
+import { HttpTypes } from "@medusajs/framework/types"
 import { ApiKeyType, MedusaError } from "@medusajs/framework/utils"
 import {
   AuthenticatedMedusaRequest,
@@ -8,7 +8,10 @@ import {
 import { refetchApiKey } from "../../helpers"
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<LinkMethodRequest>,
+  req: AuthenticatedMedusaRequest<
+    HttpTypes.AdminBatchLink,
+    HttpTypes.SelectParams
+  >,
   res: MedusaResponse<HttpTypes.AdminApiKeyResponse>
 ) => {
   const { add, remove } = req.validatedBody