fix(medusa): Fix order service linting issues (#5071)

* style(medusa): Fix order service linting issues

* Create short-ligers-pull.md

.changeset/short-ligers-pull.md

@@ -0,0 +1,5 @@
+---
+"@medusajs/medusa": patch
+---
+
+style(medusa): Fix order service linting issues

packages/medusa/src/services/order.ts

@@ -735,8 +735,8 @@ class OrderService extends TransactionBaseService {
 
       // Order the gift cards by first ends_at date, then remaining amount. To ensure largest possible amount left, for longest possible time.
       const orderedGiftCards = cart.gift_cards.sort((a, b) => {
-        let aEnd = a.ends_at ?? new Date(2100, 1, 1)
+        const aEnd = a.ends_at ?? new Date(2100, 1, 1)
-        let bEnd = b.ends_at ?? new Date(2100, 1, 1)
+        const bEnd = b.ends_at ?? new Date(2100, 1, 1)
         return aEnd.getTime() - bEnd.getTime() || a.balance - b.balance
       })
       for (const giftCard of orderedGiftCards) {
@@ -762,8 +762,9 @@ class OrderService extends TransactionBaseService {
         giftCardableAmountBalance =
           giftCardableAmountBalance - giftCardBalanceUsed
 
-        if (giftCardableAmountBalance == 0)
+        if (giftCardableAmountBalance == 0) {
-          break;
+          break
+        }
       }
 
       const shippingOptionServiceTx =