fix(medusa): Upserting tax rates (#4189)

* fix(medusa): Upserting tax rates

* Create orange-bikes-sparkle.md

* add more tests

* add explicit null type

packages/medusa/src/api/routes/admin/tax-rates/create-tax-rate.ts

@@ -1,12 +1,11 @@
-import { IsArray, IsOptional, IsString } from "class-validator"
+import { IsArray, IsNumber, IsOptional, IsString } from "class-validator"
 import { getRetrieveConfig, pickByConfig } from "./utils/get-query-config"
 
-import { EntityManager } from "typeorm"
-import { IsType } from "../../../../utils/validators/is-type"
+import { omit } from "lodash"
 import { isDefined, MedusaError } from "medusa-core-utils"
+import { EntityManager } from "typeorm"
 import { TaxRate } from "../../../.."
 import { TaxRateService } from "../../../../services"
-import { omit } from "lodash"
 import { validator } from "../../../../utils/validator"
 
 /**
@@ -187,7 +186,7 @@ export class AdminPostTaxRatesReq {
   region_id: string
 
   @IsOptional()
-  @IsType([Number, null])
+  @IsNumber()
   rate?: number | null
 
   @IsOptional()

packages/medusa/src/api/routes/admin/tax-rates/update-tax-rate.ts

@@ -1,13 +1,12 @@
-import { IsArray, IsOptional, IsString } from "class-validator"
+import { IsArray, IsNumber, IsOptional, IsString } from "class-validator"
 import { getRetrieveConfig, pickByConfig } from "./utils/get-query-config"
 
+import { omit } from "lodash"
+import { isDefined } from "medusa-core-utils"
 import { EntityManager } from "typeorm"
-import { IsType } from "../../../../utils/validators/is-type"
 import { TaxRate } from "../../../.."
 import { TaxRateService } from "../../../../services"
-import { omit } from "lodash"
 import { validator } from "../../../../utils/validator"
-import { isDefined } from "medusa-core-utils"
 
 /**
  * @oas [post] /admin/tax-rates/{id}
@@ -183,7 +182,7 @@ export class AdminPostTaxRatesTaxRateReq {
   region_id?: string
 
   @IsOptional()
-  @IsType([Number, null])
+  @IsNumber()
   rate?: number | null
 
   @IsOptional()