From 6e443dc708ffe20bf96d45ddc207ed274c28e344 Mon Sep 17 00:00:00 2001 From: Adrien de Peretti Date: Thu, 9 Feb 2023 16:55:40 +0100 Subject: [PATCH] feat(medusa): Improve `addShippingMethod` on store cart route (#3222) --- .changeset/brown-drinks-flow.md | 5 +++++ .../src/api/routes/store/carts/add-shipping-method.ts | 1 + packages/medusa/src/services/cart.ts | 6 +----- 3 files changed, 7 insertions(+), 5 deletions(-) create mode 100644 .changeset/brown-drinks-flow.md diff --git a/.changeset/brown-drinks-flow.md b/.changeset/brown-drinks-flow.md new file mode 100644 index 0000000000..4c3f781cd0 --- /dev/null +++ b/.changeset/brown-drinks-flow.md @@ -0,0 +1,5 @@ +--- +"@medusajs/medusa": patch +--- + +chore(medusa): Improve addShippingMethod on store cart route to use new totals calculation algo diff --git a/packages/medusa/src/api/routes/store/carts/add-shipping-method.ts b/packages/medusa/src/api/routes/store/carts/add-shipping-method.ts index 1cb495b835..4a95d190d9 100644 --- a/packages/medusa/src/api/routes/store/carts/add-shipping-method.ts +++ b/packages/medusa/src/api/routes/store/carts/add-shipping-method.ts @@ -80,6 +80,7 @@ export default async (req, res) => { ) const updated = await txCartService.retrieve(id, { + select: ["id"], relations: ["payment_sessions"], }) diff --git a/packages/medusa/src/services/cart.ts b/packages/medusa/src/services/cart.ts index 42f219d515..9c0dda7648 100644 --- a/packages/medusa/src/services/cart.ts +++ b/packages/medusa/src/services/cart.ts @@ -2072,16 +2072,12 @@ class CartService extends TransactionBaseService { ): Promise { return await this.atomicPhase_( async (transactionManager: EntityManager) => { - const cart = await this.retrieve(cartId, { - select: ["subtotal", "total"], + const cart = await this.retrieveWithTotals(cartId, { relations: [ "shipping_methods", - "discounts", - "discounts.rule", "shipping_methods.shipping_option", "items", "items.variant", - "payment_sessions", "items.variant.product", ], })