fix(medusa): Cleanup Tax lines in case of a failed cart completion (#2212)

integration-tests/api/__tests__/store/orders.js

@@ -8,12 +8,18 @@ const {
   ProductVariant,
   LineItem,
   Payment,
+  PaymentSession,
 } = require("@medusajs/medusa")
 
 const setupServer = require("../../../helpers/setup-server")
 const { useApi } = require("../../../helpers/use-api")
 const { initDb, useDb } = require("../../../helpers/use-db")
-const { simpleRegionFactory, simpleProductFactory } = require("../../factories")
+const {
+  simpleRegionFactory,
+  simpleProductFactory,
+  simpleCartFactory,
+  simpleShippingOptionFactory,
+} = require("../../factories")
 const { MedusaError } = require("medusa-core-utils")
 
 jest.setTimeout(30000)
@@ -299,4 +305,122 @@ describe("/store/carts", () => {
       )
     })
   })
+
+  describe("Cart completion with failed payment removes taxlines", () => {
+    afterEach(async () => {
+      const db = useDb()
+      await db.teardown()
+    })
+
+    it("should remove taxlines when a cart completion fails", async () => {
+      expect.assertions(2)
+
+      const api = useApi()
+
+      const region = await simpleRegionFactory(dbConnection)
+      const product = await simpleProductFactory(dbConnection)
+
+      const cartRes = await api.post("/store/carts", {})
+      const cartId = cartRes.data.cart.id
+
+      await api.post(`/store/carts/${cartId}/line-items`, {
+        variant_id: product.variants[0].id,
+        quantity: 1,
+      })
+      await api.post(`/store/carts/${cartId}`, {
+        email: "testmailer@medusajs.com",
+      })
+      await api.post(`/store/carts/${cartId}/payment-sessions`)
+
+      const cartResponse = await api.get(`/store/carts/${cartId}`)
+
+      await dbConnection.manager.remove(
+        PaymentSession,
+        cartResponse.data.cart.payment_session
+      )
+
+      await api.post(`/store/carts/${cartId}/complete`).catch((err) => {
+        expect(err.response.status).toEqual(400)
+      })
+
+      const lineItem = await dbConnection.manager.findOne(LineItem, {
+        where: {
+          id: cartResponse.data.cart.items[0].id,
+        },
+        relations: ["tax_lines"],
+      })
+
+      expect(lineItem.tax_lines).toHaveLength(0)
+    })
+
+    it("should remove taxlines when a payment authorization is pending", async () => {
+      const cartId = "cart-id-tax-line-testing-for-pending-payment"
+
+      const api = useApi()
+
+      const region = await simpleRegionFactory(dbConnection)
+      const shippingOption = await simpleShippingOptionFactory(dbConnection, {
+        region_id: region.id,
+      })
+      const shippingOption1 = await simpleShippingOptionFactory(dbConnection, {
+        region_id: region.id,
+      })
+      const product = await simpleProductFactory(dbConnection)
+
+      const cart = await simpleCartFactory(dbConnection, {
+        region: region.id,
+        id: cartId,
+      })
+
+      await api.post(
+        `/store/carts/${cartId}/shipping-methods`,
+        {
+          option_id: shippingOption.id,
+        },
+        { withCredentials: true }
+      )
+
+      await api.post(`/store/carts/${cartId}/line-items`, {
+        variant_id: product.variants[0].id,
+        quantity: 1,
+      })
+      await api.post(`/store/carts/${cartId}`, {
+        email: "testmailer@medusajs.com",
+      })
+      await api.post(`/store/carts/${cartId}/payment-sessions`)
+
+      const cartResponse = await api.get(`/store/carts/${cartId}`)
+
+      const completedOrder = await api.post(`/store/carts/${cartId}/complete`)
+
+      expect(completedOrder.status).toEqual(200)
+      expect(completedOrder.data).toEqual(
+        expect.objectContaining({
+          data: expect.any(Object),
+          payment_status: "pending",
+          type: "cart",
+        })
+      )
+
+      const lineItem = await dbConnection.manager.findOne(LineItem, {
+        where: {
+          id: cartResponse.data.cart.items[0].id,
+        },
+        relations: ["tax_lines"],
+      })
+
+      const cartWithShippingMethod1 = await api.post(
+        `/store/carts/${cartId}/shipping-methods`,
+        {
+          option_id: shippingOption1.id,
+        },
+        { withCredentials: true }
+      )
+
+      expect(
+        cartWithShippingMethod1.data.cart.shipping_methods[0].shipping_option_id
+      ).toEqual(shippingOption1.id)
+      expect(lineItem.tax_lines).toHaveLength(0)
+    })
+  })
 })

integration-tests/api/src/services/test-pay.js

@@ -42,6 +42,12 @@ class TestPayService extends AbstractPaymentService {
   }
 
   async authorizePayment(sessionData, context = {}) {
+    if (
+      sessionData.cart_id === "cart-id-tax-line-testing-for-pending-payment"
+    ) {
+      return { data: {}, status: "pending" }
+    }
+
     return { data: {}, status: "authorized" }
   }