From 753e8081c49ba88ff4b0afa91f48bff2e0109b9c Mon Sep 17 00:00:00 2001 From: Pepijn Date: Tue, 2 Sep 2025 11:46:32 +0200 Subject: [PATCH] fix(dashboard): promotion expired status check when limit is null (#13373) * Fix promotion expired status * Update .changeset/bright-spoons-float.md Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com> --------- Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com> --- .changeset/bright-spoons-float.md | 5 +++++ packages/admin/dashboard/src/lib/promotions.ts | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/bright-spoons-float.md diff --git a/.changeset/bright-spoons-float.md b/.changeset/bright-spoons-float.md new file mode 100644 index 0000000000..14035bc1f8 --- /dev/null +++ b/.changeset/bright-spoons-float.md @@ -0,0 +1,5 @@ +--- +"@medusajs/dashboard": patch +--- + +Fix promotion expired status check when limit is null diff --git a/packages/admin/dashboard/src/lib/promotions.ts b/packages/admin/dashboard/src/lib/promotions.ts index a2cdc916ae..ef6966705e 100644 --- a/packages/admin/dashboard/src/lib/promotions.ts +++ b/packages/admin/dashboard/src/lib/promotions.ts @@ -39,7 +39,9 @@ export const getPromotionStatus = (promotion: HttpTypes.AdminPromotion) => { const campaignBudget = campaign.budget const overBudget = - campaignBudget && campaignBudget.used! > campaignBudget.limit! + campaignBudget && + campaignBudget.limit && + campaignBudget.used! > campaignBudget.limit! if ((campaign.ends_at && new Date(campaign.ends_at) < date) || overBudget) { return promotionStatusMap[PromotionStatus.EXPIRED]