From 79cfc1a69ee166fec298aa706b994253a1284520 Mon Sep 17 00:00:00 2001 From: Oli Juhl <59018053+olivermrbl@users.noreply.github.com> Date: Fri, 28 Mar 2025 16:23:02 +0100 Subject: [PATCH] fix(utils): Enable Redis locking by default in Cloud (#12017) * fix(utils): Enable redis locking by default * fix: tests * Create popular-rules-shake.md --- .changeset/popular-rules-shake.md | 5 +++++ .../src/common/__tests__/define-config.spec.ts | 13 +++++++++++-- packages/core/utils/src/common/define-config.ts | 16 +++++++++++++--- 3 files changed, 29 insertions(+), 5 deletions(-) create mode 100644 .changeset/popular-rules-shake.md diff --git a/.changeset/popular-rules-shake.md b/.changeset/popular-rules-shake.md new file mode 100644 index 0000000000..af1290c287 --- /dev/null +++ b/.changeset/popular-rules-shake.md @@ -0,0 +1,5 @@ +--- +"@medusajs/utils": patch +--- + +fix(utils): Enable Redis locking by default in Cloud diff --git a/packages/core/utils/src/common/__tests__/define-config.spec.ts b/packages/core/utils/src/common/__tests__/define-config.spec.ts index a1be108eb9..76c6ffdc79 100644 --- a/packages/core/utils/src/common/__tests__/define-config.spec.ts +++ b/packages/core/utils/src/common/__tests__/define-config.spec.ts @@ -1051,9 +1051,18 @@ describe("defineConfig", function () { }, "locking": { "options": { - "redisUrl": "redis://localhost:6379", + "providers": [ + { + "id": "locking-redis", + "is_default": true, + "options": { + "redisUrl": "redis://localhost:6379", + }, + "resolve": "@medusajs/medusa/locking-redis", + }, + ], }, - "resolve": "@medusajs/medusa/locking-redis", + "resolve": "@medusajs/medusa/locking", }, "notification": { "options": { diff --git a/packages/core/utils/src/common/define-config.ts b/packages/core/utils/src/common/define-config.ts index 92d8f2ecc3..e701d18a78 100644 --- a/packages/core/utils/src/common/define-config.ts +++ b/packages/core/utils/src/common/define-config.ts @@ -233,10 +233,20 @@ function resolveModules( options: { redisUrl: process.env.REDIS_URL }, }, { - resolve: TEMPORARY_REDIS_MODULE_PACKAGE_NAMES[Modules.LOCKING], - options: { redisUrl: process.env.REDIS_URL }, + resolve: MODULE_PACKAGE_NAMES[Modules.LOCKING], + options: { + providers: [ + { + id: "locking-redis", + resolve: TEMPORARY_REDIS_MODULE_PACKAGE_NAMES[Modules.LOCKING], + is_default: true, + options: { + redisUrl: process.env.REDIS_URL, + }, + }, + ], + }, }, - { resolve: MODULE_PACKAGE_NAMES[Modules.FILE], options: {