chore(): Update module provider retrieval error message and type (#10138)

Partially RESOLVES FRMW-2802

**What**
Improve error message and change the error type when retrieving a provider from a local container fail
This commit is contained in:
Adrien de Peretti
2024-11-19 12:19:19 +01:00
committed by GitHub
parent 661ea7865c
commit 7aa990795c
12 changed files with 94 additions and 24 deletions

View File

@@ -2,6 +2,7 @@ import {
Context,
ILockingModule,
InternalModuleDeclaration,
Logger,
} from "@medusajs/types"
import { EntityManager } from "@mikro-orm/core"
import { LockingDefaultProvider } from "@types"
@@ -10,6 +11,7 @@ import LockingProviderService from "./locking-provider"
type InjectedDependencies = {
manager: EntityManager
lockingProviderService: LockingProviderService
logger?: Logger
[LockingDefaultProvider]: string
}

View File

@@ -1,16 +1,25 @@
import { Constructor, ILockingProvider } from "@medusajs/framework/types"
import {
Constructor,
ILockingProvider,
Logger,
} from "@medusajs/framework/types"
import { MedusaError } from "@medusajs/framework/utils"
import { LockingProviderRegistrationPrefix } from "../types"
type InjectedDependencies = {
[key: `lp_${string}`]: ILockingProvider
logger?: Logger
}
export default class LockingProviderService {
protected __container__: InjectedDependencies
#logger: Logger
constructor(container: InjectedDependencies) {
this.__container__ = container
this.#logger = container["logger"]
? container.logger
: (console as unknown as Logger)
}
static getRegistrationIdentifier(
@@ -31,10 +40,12 @@ export default class LockingProviderService {
`${LockingProviderRegistrationPrefix}${providerId}`
]
} catch (err) {
throw new MedusaError(
MedusaError.Types.NOT_FOUND,
`Could not find a locking provider with id: ${providerId}`
)
const errMessage = `
Unable to retrieve the locking provider with id: ${providerId}
Please make sure that the provider is registered in the container and it is configured correctly in your project configuration file.
`
this.#logger.error(errMessage)
throw new Error(errMessage)
}
}
}