From 7bb9cd6aff1d832e6e159f2c878be88a054eddaa Mon Sep 17 00:00:00 2001 From: Patrick <116003638+patrick-medusajs@users.noreply.github.com> Date: Wed, 14 Dec 2022 11:46:08 -0500 Subject: [PATCH] fix(medusa-js): missing devDependency was failing repo build task (#2804) ### What Explicitly declare `@medusajs/medusa` as a devDependency for `@medusajs/medusa-js` client package. ### Why With our latest version upgrade of `turbo`, peerDependencies aren't taken into account in the build graph. The recommendation is to also explicitly declare them in devDependencies. ### Test * Run `yarn build --graph` * Expect to see medusa-js having a dependency on medusa ``` "[root] @medusajs/medusa-js#build" -> "[root] @medusajs/medusa#build" ``` --- .changeset/giant-insects-tease.md | 5 +++++ packages/medusa-js/package.json | 1 + yarn.lock | 3 ++- 3 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/giant-insects-tease.md diff --git a/.changeset/giant-insects-tease.md b/.changeset/giant-insects-tease.md new file mode 100644 index 0000000000..d2c78ab6d7 --- /dev/null +++ b/.changeset/giant-insects-tease.md @@ -0,0 +1,5 @@ +--- +"@medusajs/medusa-js": patch +--- + +fix: missing devDependency was failing repo build task diff --git a/packages/medusa-js/package.json b/packages/medusa-js/package.json index eeb9e42a31..2990067f0e 100644 --- a/packages/medusa-js/package.json +++ b/packages/medusa-js/package.json @@ -32,6 +32,7 @@ "url": "https://github.com/medusajs/medusa/issues" }, "devDependencies": { + "@medusajs/medusa": "^1.7.0", "@types/jest": "^26.0.19", "cross-env": "^7.0.3", "jest": "^26.6.3", diff --git a/yarn.lock b/yarn.lock index 37bd0e35f2..cd853c606a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4381,6 +4381,7 @@ __metadata: version: 0.0.0-use.local resolution: "@medusajs/medusa-js@workspace:packages/medusa-js" dependencies: + "@medusajs/medusa": ^1.7.0 "@types/jest": ^26.0.19 axios: ^0.24.0 cross-env: ^7.0.3 @@ -4394,7 +4395,7 @@ __metadata: languageName: unknown linkType: soft -"@medusajs/medusa@*, @medusajs/medusa@^1.3.3, @medusajs/medusa@workspace:packages/medusa": +"@medusajs/medusa@*, @medusajs/medusa@^1.3.3, @medusajs/medusa@^1.7.0, @medusajs/medusa@workspace:packages/medusa": version: 0.0.0-use.local resolution: "@medusajs/medusa@workspace:packages/medusa" dependencies: