fix(core-flows): refresh payment collection inside updateCartPromotionsWorkflow (#13963)

* Refresh payment collection after cart promotion update

* Add missing test

* Add changeset

* Update changeset

* Add force_refresh_payment_collection to updateCartPromotionsWorkflow to conditionally refresh payment collection

* Prevent refreshing payment collection multiple times

* Fix test

* Formatting and unused vars

---------

Co-authored-by: Adrien de Peretti <adrien.deperetti@gmail.com>

packages/core/core-flows/src/cart/workflows/create-carts.ts

@@ -234,6 +234,7 @@ export const createCartWorkflow = createWorkflow(
       input: {
         cart_id: cart.id,
         promo_codes: input.promo_codes,
+        force_refresh_payment_collection: false,
       },
     })
 

packages/core/core-flows/src/cart/workflows/refresh-cart-items.ts

@@ -230,6 +230,7 @@ export const refreshCartItemsWorkflow = createWorkflow(
         cart: refetchedCart, // Pass cart to avoid refetch in updateCartPromotionsWorkflow
         promo_codes: cartPromoCodes,
         action: PromotionActions.REPLACE,
+        force_refresh_payment_collection: false,
       },
     })
 

packages/core/core-flows/src/cart/workflows/update-cart-promotions.ts

@@ -22,6 +22,7 @@ import {
 } from "../steps"
 import { updateCartPromotionsStep } from "../steps/update-cart-promotions"
 import { cartFieldsForRefreshSteps } from "../utils/fields"
+import { refreshPaymentCollectionForCartWorkflow } from "./refresh-payment-collection"
 
 /**
  * The details of the promotion updates on a cart.
@@ -47,6 +48,11 @@ export type UpdateCartPromotionsWorkflowInput = {
     | PromotionActions.ADD
     | PromotionActions.REMOVE
     | PromotionActions.REPLACE
+    /**
+     * Wether to force the refresh of the cart payment collection. If the caller doesn't refresh it explicitly,
+     * you should probably set this property to true.
+     */
+    force_refresh_payment_collection?: boolean
 }
 
 export const updateCartPromotionsWorkflowId = "update-cart-promotions"
@@ -153,6 +159,15 @@ export const updateCartPromotionsWorkflow = createWorkflow(
       })
     )
 
+    when(
+      { input },
+      ({ input }) => input.force_refresh_payment_collection === true
+    ).then(() => {
+      refreshPaymentCollectionForCartWorkflow.runAsStep({
+        input: { cart },
+      })
+    })
+
     releaseLockStep({
       key: cart.id,
     })