diff --git a/packages/medusa/src/services/__mocks__/product.js b/packages/medusa/src/services/__mocks__/product.js index 9880d920f2..c86cec482e 100644 --- a/packages/medusa/src/services/__mocks__/product.js +++ b/packages/medusa/src/services/__mocks__/product.js @@ -36,9 +36,9 @@ export const ProductServiceMock = { if (data.title === "Test Product") { return Promise.resolve(products.product1) } - if (data.title === "Test Product with variants") + if (data.title === "Test Product with variants") { return Promise.resolve(products.productWithOptions) - + } return Promise.resolve({ ...data }) }), count: jest.fn().mockReturnValue(4), diff --git a/packages/medusa/src/services/__tests__/product.js b/packages/medusa/src/services/__tests__/product.js index 4f4033d7a3..a8fe0463d4 100644 --- a/packages/medusa/src/services/__tests__/product.js +++ b/packages/medusa/src/services/__tests__/product.js @@ -12,7 +12,7 @@ describe("ProductService", () => { describe("retrieve", () => { const productRepo = MockRepository({ findOneWithRelations: (rels, query) => { - if (query.where.id === "test id with variants") + if (query.where.id === "test id with variants") { return { id: "test id with variants", variants: [ @@ -20,11 +20,13 @@ describe("ProductService", () => { { id: "test_123", title: "Blue" }, ], } - if (query.where.id === "test id one variant") + } + if (query.where.id === "test id one variant") { return { id: "test id one variant", variants: [{ id: "test_123", title: "Blue" }], } + } return Promise.resolve({ id: IdMap.getId("ironman") }) }, }) diff --git a/packages/medusa/src/services/product-variant.js b/packages/medusa/src/services/product-variant.js index 922d607a37..388d8fad24 100644 --- a/packages/medusa/src/services/product-variant.js +++ b/packages/medusa/src/services/product-variant.js @@ -174,7 +174,9 @@ class ProductVariantService extends BaseService { ) } - if (!rest.variant_rank) rest.variant_rank = product.variants.length + if (!rest.variant_rank) { + rest.variant_rank = product.variants.length + } const toCreate = { ...rest,