fix(): Transform map (#13655)

**What**
It seems that for some reason the weak map fail in some scenario, but after investigation, the usage of map would not have a bad impact as it will be released after the Distributed transaction if finished. Therefore, falling back to Map instead

FIXES https://github.com/medusajs/medusa/issues/13654

NOTE: Waiting for the user feedback as he is also using node 18. We also use the exact same pattern in all our core flows without issues 🤔

.changeset/witty-nails-drive.md

@@ -0,0 +1,6 @@
+---
+"@medusajs/orchestration": patch
+"@medusajs/workflows-sdk": patch
+---
+
+fix(): Transform map

packages/core/orchestration/src/transaction/distributed-transaction.ts

@@ -91,7 +91,7 @@ class DistributedTransaction extends EventEmitter {
    *
    * @private
    */
-  #temporaryStorage = new WeakMap<{ key: string }, unknown>()
+  #temporaryStorage = new Map<string, unknown>()
 
   public static setStorage(storage: IDistributedTransactionStorage) {
     this.keyValueStore = storage
@@ -311,15 +311,15 @@ class DistributedTransaction extends EventEmitter {
     await DistributedTransaction.keyValueStore.clearStepTimeout(this, step)
   }
 
-  public setTemporaryData(key: { key: string }, value: unknown) {
+  public setTemporaryData(key: string, value: unknown) {
     this.#temporaryStorage.set(key, value)
   }
 
-  public getTemporaryData(key: { key: string }) {
+  public getTemporaryData(key: string) {
     return this.#temporaryStorage.get(key)
   }
 
-  public hasTemporaryData(key: { key: string }) {
+  public hasTemporaryData(key: string) {
     return this.#temporaryStorage.has(key)
   }
 

packages/core/utils/src/dal/mikro-orm/integration-tests/__tests__/mikro-orm-repository.spec.ts

@@ -1521,8 +1521,10 @@ describe("mikroOrmRepository", () => {
       expect(e5SelectCalls).toBe(2) // One for Entity5, one for Entity6
       expect(e5InsertCalls).toBe(2) // One batch insert for Entity5s, one for Entity6s
 
-      expect(qbInsertSpy.mock.calls[0][0]).toHaveLength(800) // entity5 25 * 8 * 4
+      // Check that the expected batch sizes exist (order may vary)
-      expect(qbInsertSpy.mock.calls[1][0]).toHaveLength(2400) // entity6 25 * 8 * 4 * 3
+      const e5BatchSizes = qbInsertSpy.mock.calls.map(call => call[0].length)
+      expect(e5BatchSizes).toContain(800) // entity5 25 * 8 * 4
+      expect(e5BatchSizes).toContain(2400) // entity6 25 * 8 * 4 * 3
 
       findSpy.mockClear()
       qbSelectSpy.mockClear()
@@ -1551,9 +1553,11 @@ describe("mikroOrmRepository", () => {
       expect(e3SelectCalls).toBe(3) // One for Entity3, one for Entity5, One pivot entity3 -> entity5
       expect(e3InsertCalls).toBe(3) // One batch insert for Entity3s, one for Entity4s and one pivot entity3 -> entity5
 
-      expect(qbInsertSpy.mock.calls[0][0]).toHaveLength(200) // entity3: 25 * 8
+      // Check that the expected batch sizes exist (order may vary)
-      expect(qbInsertSpy.mock.calls[1][0]).toHaveLength(800) // pivot entity3 -> entity5: 25 * 8 * 4
+      const e3BatchSizes = qbInsertSpy.mock.calls.map(call => call[0].length)
-      expect(qbInsertSpy.mock.calls[2][0]).toHaveLength(1000) // entity4: 25 * 8 * 5
+      expect(e3BatchSizes).toContain(200) // entity3: 25 * 8
+      expect(e3BatchSizes).toContain(800) // pivot entity3 -> entity5: 25 * 8 * 4
+      expect(e3BatchSizes).toContain(1000) // entity4: 25 * 8 * 5
 
       findSpy.mockClear()
       qbSelectSpy.mockClear()
@@ -1580,9 +1584,11 @@ describe("mikroOrmRepository", () => {
       expect(mainSelectCalls).toBe(3) // One for Entity1, one for Entity3, one for Entity2
       expect(mainInsertCalls).toBe(3) // One batch insert for Entity1s, one for Entity2s, one for Entity3s
 
-      expect(qbInsertSpy.mock.calls[0][0]).toHaveLength(25) // entity1: 25
+      // Check that the expected batch sizes exist (order may vary)
-      expect(qbInsertSpy.mock.calls[1][0]).toHaveLength(200) // entity3: 25 * 8
+      const mainBatchSizes = qbInsertSpy.mock.calls.map(call => call[0].length)
-      expect(qbInsertSpy.mock.calls[2][0]).toHaveLength(250) // entity2: 25 * 10
+      expect(mainBatchSizes).toContain(25) // entity1: 25
+      expect(mainBatchSizes).toContain(200) // entity3: 25 * 8
+      expect(mainBatchSizes).toContain(250) // entity2: 25 * 10
 
       findSpy.mockClear()
       qbSelectSpy.mockClear()
@@ -1658,8 +1664,10 @@ describe("mikroOrmRepository", () => {
 
       // Should use batch inserts for new entities and pivot relationships
       expect(updateInsertCalls).toBe(2) // pivot Entity1 - Entity3 (with conflict resolution) + new Entity2s
-      expect(qbInsertSpy.mock.calls[0][0]).toHaveLength(100) // pivot Entity1 - Entity3: 25 parents × 4 entity3s each (uses onConflict().ignore())
+      // Check that the expected batch sizes exist (order may vary)
-      expect(qbInsertSpy.mock.calls[1][0]).toHaveLength(50) // New Entity2s: 25 parents × 2 new each
+      const updateBatchSizes = qbInsertSpy.mock.calls.map(call => call[0].length)
+      expect(updateBatchSizes).toContain(100) // pivot Entity1 - Entity3: 25 parents × 4 entity3s each (uses onConflict().ignore())
+      expect(updateBatchSizes).toContain(50) // New Entity2s: 25 parents × 2 new each
 
       // We wont check the deletion which happen through knex directly. It will be accounted for in
       // the final state verification

packages/core/workflows-sdk/src/utils/composer/transform.ts

@@ -170,7 +170,7 @@ export function transform(
   } as WorkflowData & {
     __id: string
     __type: string
-    __temporary_storage_key: { key: string } | null
+    __temporary_storage_key: string | null
   }
 
   const returnFn = async function (
@@ -179,8 +179,7 @@ export function transform(
   ): Promise<any> {
     if ("transaction" in transactionContext) {
       const temporaryDataKey = `${transactionContext.transaction.modelId}_${transactionContext.transaction.transactionId}_${uniqId}`
-
+      ret.__temporary_storage_key ??= temporaryDataKey
-      ret.__temporary_storage_key ??= { key: temporaryDataKey }
 
       if (
         transactionContext.transaction.hasTemporaryData(