From 8c26a5fd88fa80d7e944ab01120422faa57c37a3 Mon Sep 17 00:00:00 2001
From: Abraham Ugbeshe <abrahamugbeshe@gmail.com>
Date: Thu, 22 Jul 2021 17:28:12 +0100
Subject: [PATCH] chore: issue #299: implemented DUPLICATE_ERROR in places
 necessary (#314)

---
 packages/medusa/src/services/order.js           | 2 +-
 packages/medusa/src/services/product-variant.js | 2 +-
 packages/medusa/src/services/product.js         | 4 ++--
 packages/medusa/src/services/region.js          | 2 +-
 packages/medusa/src/services/shipping-option.js | 2 +-
 packages/medusa/src/services/store.js           | 2 +-
 packages/medusa/src/services/swap.js            | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/packages/medusa/src/services/order.js b/packages/medusa/src/services/order.js
index 947027c525..af5bd541c6 100644
--- a/packages/medusa/src/services/order.js
+++ b/packages/medusa/src/services/order.js
@@ -454,7 +454,7 @@ class OrderService extends BaseService {
       const exists = await this.existsByCartId(cart.id)
       if (exists) {
         throw new MedusaError(
-          MedusaError.Types.INVALID_ARGUMENT,
+          MedusaError.Types.DUPLICATE_ERROR,
           "Order from cart already exists"
         )
       }
diff --git a/packages/medusa/src/services/product-variant.js b/packages/medusa/src/services/product-variant.js
index 42fca94c47..b474865043 100644
--- a/packages/medusa/src/services/product-variant.js
+++ b/packages/medusa/src/services/product-variant.js
@@ -169,7 +169,7 @@ class ProductVariantService extends BaseService {
 
       if (variantExists) {
         throw new MedusaError(
-          MedusaError.Types.INVALID_DATA,
+          MedusaError.Types.DUPLICATE_ERROR,
           `Variant with title ${variantExists.title} with provided options already exists`
         )
       }
diff --git a/packages/medusa/src/services/product.js b/packages/medusa/src/services/product.js
index 968071b890..ea9c810c71 100644
--- a/packages/medusa/src/services/product.js
+++ b/packages/medusa/src/services/product.js
@@ -492,7 +492,7 @@ class ProductService extends BaseService {
 
       if (product.options.find(o => o.title === optionTitle)) {
         throw new MedusaError(
-          MedusaError.Types.INVALID_DATA,
+          MedusaError.Types.DUPLICATE_ERROR,
           `An option with the title: ${optionTitle} already exists`
         )
       }
@@ -631,7 +631,7 @@ class ProductService extends BaseService {
       if (!productOption) {
         throw new MedusaError(
           MedusaError.Types.NOT_FOUND,
-          `Option with id: ${optionId} deos not exists`
+          `Option with id: ${optionId} does not exists`
         )
       }
 
diff --git a/packages/medusa/src/services/region.js b/packages/medusa/src/services/region.js
index 33a56ff3c7..0994214958 100644
--- a/packages/medusa/src/services/region.js
+++ b/packages/medusa/src/services/region.js
@@ -328,7 +328,7 @@ class RegionService extends BaseService {
 
     if (country.region_id && country.region_id !== regionId) {
       throw new MedusaError(
-        MedusaError.Types.NOT_ALLOWED,
+        MedusaError.Types.DUPLICATE_ERROR,
         `${country.name} already exists in ${country.name}, delete it in that region before adding it`
       )
     }
diff --git a/packages/medusa/src/services/shipping-option.js b/packages/medusa/src/services/shipping-option.js
index eb136eda5c..52c922aa0e 100644
--- a/packages/medusa/src/services/shipping-option.js
+++ b/packages/medusa/src/services/shipping-option.js
@@ -523,7 +523,7 @@ class ShippingOptionService extends BaseService {
 
       if (option.requirements.find(r => r.type === validatedReq.type)) {
         throw new MedusaError(
-          MedusaError.Types.INVALID_DATA,
+          MedusaError.Types.DUPLICATE_ERROR,
           `A requirement with type: ${validatedReq.type} already exists`
         )
       }
diff --git a/packages/medusa/src/services/store.js b/packages/medusa/src/services/store.js
index 1eed24e6f3..ac65a9ad21 100644
--- a/packages/medusa/src/services/store.js
+++ b/packages/medusa/src/services/store.js
@@ -189,7 +189,7 @@ class StoreService extends BaseService {
 
       if (store.currencies.map(c => c.code).includes(curr.code.toLowerCase())) {
         throw new MedusaError(
-          MedusaError.Types.INVALID_DATA,
+          MedusaError.Types.DUPLICATE_ERROR,
           `Currency already added`
         )
       }
diff --git a/packages/medusa/src/services/swap.js b/packages/medusa/src/services/swap.js
index b12cf4477e..c1c8711c42 100644
--- a/packages/medusa/src/services/swap.js
+++ b/packages/medusa/src/services/swap.js
@@ -440,7 +440,7 @@ class SwapService extends BaseService {
 
       if (swap.cart_id) {
         throw new MedusaError(
-          MedusaError.Types.NOT_ALLOWED,
+          MedusaError.Types.DUPLICATE_ERROR,
           "A cart has already been created for the swap"
         )
       }