asyavee/medusa-store
1
0 Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

feat(): remove status from translatable fields (#14321)

Browse Source 
* feat(): remove status from translatable fields

* Create tender-mugs-shave.md

* feat(): remove status from translatable fields
This commit is contained in:
Adrien de Peretti authored and GitHub committed 2025-12-16 14:57:06 +01:00
1 parent 53cdbaa069
commit 8c29d85f0f
4 files changed
+59 -58
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

.changeset/tender-mugs-shave.md
+5
View File
@@ -0,0 +1,5 @@
---
"@medusajs/translation": patch
---
feat(): remove status from translatable fields
integration-tests/http/__tests__/translation/admin/translation.spec.ts
+20 -21
View File
@@ -691,13 +691,13 @@ medusaIntegrationTestRunner({
expect(response.status).toEqual(200) expect(response.status).toEqual(200)
expect(response.data.statistics).toBeDefined() expect(response.data.statistics).toBeDefined()
expect(response.data.statistics.product).toEqual({ expect(response.data.statistics.product).toEqual({
// 2 products × 5 translatable fields × 2 locales = 20 expected // 2 products × 4 translatable fields × 2 locales = 16 expected
expected: 20, expected: 16,
translated: 0, translated: 0,
missing: 20, missing: 16,
by_locale: { by_locale: {
"en-US": { expected: 10, translated: 0, missing: 10 }, "en-US": { expected: 8, translated: 0, missing: 8 },
"fr-FR": { expected: 10, translated: 0, missing: 10 }, "fr-FR": { expected: 8, translated: 0, missing: 8 },
}, },
}) })
}) })
@@ -742,14 +742,14 @@ medusaIntegrationTestRunner({
) )
expect(response.status).toEqual(200) expect(response.status).toEqual(200)
// 2 products × 5 fields × 1 locale = 10 expected // 2 products × 4 fields × 1 locale = 8 expected
// product1 has 2 fields, product2 has 1 field = 3 translated // product1 has 2 fields, product2 has 1 field = 3 translated
expect(response.data.statistics.product).toEqual({ expect(response.data.statistics.product).toEqual({
expected: 10, expected: 8,
translated: 3, translated: 3,
missing: 7, missing: 5,
by_locale: { by_locale: {
"fr-FR": { expected: 10, translated: 3, missing: 7 }, "fr-FR": { expected: 8, translated: 3, missing: 5 },
}, },
}) })
}) })
@@ -775,7 +775,6 @@ medusaIntegrationTestRunner({
title: "Produit", title: "Produit",
description: "Description", description: "Description",
subtitle: "Sous-titre", subtitle: "Sous-titre",
status: "Actif",
material: "Matériau", material: "Matériau",
}, },
}, },
@@ -799,13 +798,13 @@ medusaIntegrationTestRunner({
expect(response.status).toEqual(200) expect(response.status).toEqual(200)
// Product: 1 × 5 fields × 1 locale = 5, all translated // Product: 1 × 4 fields × 1 locale = 4, all translated
expect(response.data.statistics.product).toEqual({ expect(response.data.statistics.product).toEqual({
expected: 5, expected: 4,
translated: 5, translated: 4,
missing: 0, missing: 0,
by_locale: { by_locale: {
"fr-FR": { expected: 5, translated: 5, missing: 0 }, "fr-FR": { expected: 4, translated: 4, missing: 0 },
}, },
}) })
@@ -856,21 +855,21 @@ medusaIntegrationTestRunner({
) )
expect(response.status).toEqual(200) expect(response.status).toEqual(200)
// 1 product × 5 fields × 2 locales = 10 expected // 1 product × 4 fields × 2 locales = 8 expected
// fr-FR: 2 translated, de-DE: 1 translated = 3 total // fr-FR: 2 translated, de-DE: 1 translated = 3 total
expect(response.data.statistics.product.expected).toEqual(10) expect(response.data.statistics.product.expected).toEqual(8)
expect(response.data.statistics.product.translated).toEqual(3) expect(response.data.statistics.product.translated).toEqual(3)
expect(response.data.statistics.product.missing).toEqual(7) expect(response.data.statistics.product.missing).toEqual(5)
expect(response.data.statistics.product.by_locale["fr-FR"]).toEqual({ expect(response.data.statistics.product.by_locale["fr-FR"]).toEqual({
expected: 5, expected: 4,
translated: 2, translated: 2,
missing: 3, missing: 2,
}) })
expect(response.data.statistics.product.by_locale["de-DE"]).toEqual({ expect(response.data.statistics.product.by_locale["de-DE"]).toEqual({
expected: 5, expected: 4,
translated: 1, translated: 1,
missing: 4, missing: 3,
}) })
}) })
packages/modules/translation/integration-tests/__tests__/translation-module-service.spec.ts
+34 -36
View File
@@ -651,7 +651,7 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
describe("getStatistics", () => { describe("getStatistics", () => {
it("should return statistics for a single entity type and locale", async () => { it("should return statistics for a single entity type and locale", async () => {
// Create translations for 2 products with some fields filled // Create translations for 2 products with some fields filled
// Product has 4 translatable fields: title, description, subtitle, status // Product has 4 translatable fields: title, description, material, subtitle
await service.createTranslations([ await service.createTranslations([
{ {
reference_id: "prod_stat_1", reference_id: "prod_stat_1",
@@ -660,7 +660,7 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
translations: { translations: {
title: "Product 1", title: "Product 1",
description: "Description 1", description: "Description 1",
// subtitle and status are missing // material and subtitle are missing
}, },
}, },
{ {
@@ -671,7 +671,6 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
title: "Product 2", title: "Product 2",
description: "Description 2", description: "Description 2",
subtitle: "Subtitle 2", subtitle: "Subtitle 2",
status: "Active",
}, },
}, },
]) ])
@@ -683,17 +682,17 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
}, },
}) })
// Expected: 2 products × 5 fields × 1 locale = 10 // Expected: 2 products × 4 fields × 1 locale = 8
// Translated: prod_1 has 2, prod_2 has 4 = 6 // Translated: prod_1 has 2, prod_2 has 3 = 5
expect(stats.product).toEqual({ expect(stats.product).toEqual({
expected: 10, expected: 8,
translated: 6, translated: 5,
missing: 4, missing: 3,
by_locale: { by_locale: {
"en-US": { "en-US": {
expected: 10, expected: 8,
translated: 6, translated: 5,
missing: 4, missing: 3,
}, },
}, },
}) })
@@ -728,22 +727,22 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
}, },
}) })
// Expected per locale: 1 product × 5 fields = 5 // Expected per locale: 1 product × 4 fields = 4
// Total expected: 5 × 2 locales = 10 // Total expected: 4 × 2 locales = 8
expect(stats.product.expected).toEqual(10) expect(stats.product.expected).toEqual(8)
expect(stats.product.translated).toEqual(3) // 2 EN + 1 FR expect(stats.product.translated).toEqual(3) // 2 EN + 1 FR
expect(stats.product.missing).toEqual(7) expect(stats.product.missing).toEqual(5)
expect(stats.product.by_locale["en-US"]).toEqual({ expect(stats.product.by_locale["en-US"]).toEqual({
expected: 5, expected: 4,
translated: 2, translated: 2,
missing: 3, missing: 2,
}) })
expect(stats.product.by_locale["fr-FR"]).toEqual({ expect(stats.product.by_locale["fr-FR"]).toEqual({
expected: 5, expected: 4,
translated: 1, translated: 1,
missing: 4, missing: 3,
}) })
}) })
@@ -757,7 +756,6 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
title: "Product Title", title: "Product Title",
description: "Product Description", description: "Product Description",
subtitle: "Product Subtitle", subtitle: "Product Subtitle",
status: "Active",
material: "Product Material", material: "Product Material",
}, },
}, },
@@ -780,13 +778,13 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
}, },
}) })
// Product: 1 × 5 fields = 5 expected, 5 translated // Product: 1 × 4 fields = 4 expected, 4 translated
expect(stats.product).toEqual({ expect(stats.product).toEqual({
expected: 5, expected: 4,
translated: 5, translated: 4,
missing: 0, missing: 0,
by_locale: { by_locale: {
"en-US": { expected: 5, translated: 5, missing: 0 }, "en-US": { expected: 4, translated: 4, missing: 0 },
}, },
}) })
@@ -827,14 +825,14 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
}, },
}) })
// 5 products × 5 fields × 2 locales = 50 expected, 0 translated // 5 products × 4 fields × 2 locales = 40 expected, 0 translated
expect(stats.product).toEqual({ expect(stats.product).toEqual({
expected: 50, expected: 40,
translated: 0, translated: 0,
missing: 50, missing: 40,
by_locale: { by_locale: {
"en-US": { expected: 25, translated: 0, missing: 25 }, "en-US": { expected: 20, translated: 0, missing: 20 },
"fr-FR": { expected: 25, translated: 0, missing: 25 }, "fr-FR": { expected: 20, translated: 0, missing: 20 },
}, },
}) })
}) })
@@ -860,9 +858,9 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
}, },
}) })
// Only title, subtitle and material should count (3), not empty description // Only title and subtitle count (2), not empty description
expect(stats.product.translated).toEqual(2) expect(stats.product.translated).toEqual(2)
expect(stats.product.missing).toEqual(3) expect(stats.product.missing).toEqual(2)
}) })
it("should normalize locale codes", async () => { it("should normalize locale codes", async () => {
@@ -924,10 +922,10 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
}, },
}) })
// Product: 10000 × 5 fields × 3 locales = 150000 // Product: 10000 × 4 fields × 3 locales = 120000
expect(stats.product.expected).toEqual(150000) expect(stats.product.expected).toEqual(120000)
expect(stats.product.translated).toEqual(0) expect(stats.product.translated).toEqual(0)
expect(stats.product.missing).toEqual(150000) expect(stats.product.missing).toEqual(120000)
// Variant: 50000 × 2 fields × 3 locales = 300000 // Variant: 50000 × 2 fields × 3 locales = 300000
expect(stats.product_variant.expected).toEqual(300000) expect(stats.product_variant.expected).toEqual(300000)
@@ -942,7 +940,7 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
locale_code: "en-US", locale_code: "en-US",
translations: { translations: {
title: "Product Title", title: "Product Title",
// only 1 of 5 fields // only 1 of 4 fields
}, },
}) })
@@ -966,7 +964,7 @@ moduleIntegrationTestRunner<ITranslationModuleService>({
entities: { product: { count: 1 } }, entities: { product: { count: 1 } },
}) })
expect(stats.product.translated).toEqual(3) expect(stats.product.translated).toEqual(3)
expect(stats.product.missing).toEqual(2) expect(stats.product.missing).toEqual(1)
}) })
}) })
}) })
packages/modules/translation/src/utils/translatable-fields.ts
-1
View File
@@ -3,7 +3,6 @@ export const PRODUCT_TRANSLATABLE_FIELDS = [
"description", "description",
"material", "material",
"subtitle", "subtitle",
"status",
] ]
export const PRODUCT_VARIANT_TRANSLATABLE_FIELDS = ["title", "material"] export const PRODUCT_VARIANT_TRANSLATABLE_FIELDS = ["title", "material"]
export const PRODUCT_TYPE_TRANSLATABLE_FIELDS = ["value"] export const PRODUCT_TYPE_TRANSLATABLE_FIELDS = ["value"]