asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(medusa): category list api bug where limit skews results (#3914)

Browse Source 
* chore: fix category list api bug where limit skews results

* chore: add limits to integration test
This commit is contained in:
Riqwan Thamir
2023-04-24 19:16:58 +02:00
committed by GitHub
parent 88a224e42a
commit 935abeae68
4 changed files with 60 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-tests/api/__tests__/admin/product-category.ts
+7 -7
View File
@@ -179,14 +179,14 @@ describe("/admin/product-categories", () => {
const api = useApi()
const response = await api.get(
`/admin/product-categories`,
`/admin/product-categories?limit=7`,
adminHeaders
)
expect(response.status).toEqual(200)
expect(response.data.count).toEqual(7)
expect(response.data.offset).toEqual(0)
expect(response.data.limit).toEqual(100)
expect(response.data.limit).toEqual(7)
expect(response.data.product_categories).toEqual(
[
@@ -296,7 +296,7 @@ describe("/admin/product-categories", () => {
const api = useApi()
const response = await api.get(
`/admin/product-categories?is_internal=true`,
`/admin/product-categories?is_internal=true&limit=7`,
adminHeaders,
)
@@ -309,7 +309,7 @@ describe("/admin/product-categories", () => {
const api = useApi()
const response = await api.get(
`/admin/product-categories?handle=${productCategory.handle}`,
`/admin/product-categories?handle=${productCategory.handle}&limit=2`,
adminHeaders,
)
@@ -322,7 +322,7 @@ describe("/admin/product-categories", () => {
const api = useApi()
const response = await api.get(
`/admin/product-categories?q=men`,
`/admin/product-categories?q=men&limit=1`,
adminHeaders,
)
@@ -335,7 +335,7 @@ describe("/admin/product-categories", () => {
const api = useApi()
const response = await api.get(
`/admin/product-categories?parent_category_id=${productCategoryParent.id}`,
`/admin/product-categories?parent_category_id=${productCategoryParent.id}&limit=7`,
adminHeaders,
)
@@ -357,7 +357,7 @@ describe("/admin/product-categories", () => {
const api = useApi()
const response = await api.get(
`/admin/product-categories?parent_category_id=null&include_descendants_tree=true`,
`/admin/product-categories?parent_category_id=null&include_descendants_tree=true&limit=7`,
adminHeaders
)
integration-tests/api/__tests__/store/product-category.ts
+7 -7
View File
@@ -178,13 +178,13 @@ describe("/store/product-categories", () => {
const api = useApi()
const response = await api.get(
`/store/product-categories`,
`/store/product-categories?limit=10`,
)
expect(response.status).toEqual(200)
expect(response.data.count).toEqual(4)
expect(response.data.offset).toEqual(0)
expect(response.data.limit).toEqual(100)
expect(response.data.limit).toEqual(10)
expect(response.data.product_categories).toEqual(
[
@@ -239,7 +239,7 @@ describe("/store/product-categories", () => {
const api = useApi()
const response = await api.get(
`/store/product-categories?parent_category_id=null&include_descendants_tree=true`,
`/store/product-categories?parent_category_id=null&include_descendants_tree=true&limit=10`,
)
expect(response.status).toEqual(200)
@@ -280,7 +280,7 @@ describe("/store/product-categories", () => {
const api = useApi()
const error = await api.get(
`/store/product-categories?is_internal=true`,
`/store/product-categories?is_internal=true&limit=10`,
).catch(e => e)
expect(error.response.status).toEqual(400)
@@ -292,7 +292,7 @@ describe("/store/product-categories", () => {
const api = useApi()
const response = await api.get(
`/store/product-categories?q=category-parent`,
`/store/product-categories?q=category-parent&limit=10`,
)
expect(response.status).toEqual(200)
@@ -304,7 +304,7 @@ describe("/store/product-categories", () => {
const api = useApi()
const response = await api.get(
`/store/product-categories?handle=${productCategory.handle}`,
`/store/product-categories?handle=${productCategory.handle}&limit=10`,
)
expect(response.status).toEqual(200)
@@ -316,7 +316,7 @@ describe("/store/product-categories", () => {
const api = useApi()
const response = await api.get(
`/store/product-categories?parent_category_id=${productCategory.id}`,
`/store/product-categories?parent_category_id=${productCategory.id}&limit=10`,
)
expect(response.status).toEqual(200)