From 950a5816909b2038a5bee5d8e6912290e5c7c53b Mon Sep 17 00:00:00 2001
From: Philip Korsholm <88927411+pKorsholm@users.noreply.github.com>
Date: Mon, 17 Jul 2023 10:50:06 +0200
Subject: [PATCH] fix(medusa-file-minio): Minio private bucket default (#4540)

* default "getUploadDescriptor" to private (similar to aws + digital ocean)

* add changeset
---
 .changeset/rotten-peas-heal.md                   |  5 +++++
 packages/medusa-file-minio/src/services/minio.ts | 13 +++++++------
 2 files changed, 12 insertions(+), 6 deletions(-)
 create mode 100644 .changeset/rotten-peas-heal.md

diff --git a/.changeset/rotten-peas-heal.md b/.changeset/rotten-peas-heal.md
new file mode 100644
index 0000000000..55e2d9b68f
--- /dev/null
+++ b/.changeset/rotten-peas-heal.md
@@ -0,0 +1,5 @@
+---
+"medusa-file-minio": patch
+---
+
+fix(medusa-file-minio): default getUploadDescriptor to private
diff --git a/packages/medusa-file-minio/src/services/minio.ts b/packages/medusa-file-minio/src/services/minio.ts
index 3339383944..f8205fd72c 100644
--- a/packages/medusa-file-minio/src/services/minio.ts
+++ b/packages/medusa-file-minio/src/services/minio.ts
@@ -1,7 +1,3 @@
-import stream from "stream"
-import aws from "aws-sdk"
-import { parse } from "path"
-import fs from "fs"
 import {
   AbstractFileService,
   DeleteFileType,
@@ -10,9 +6,14 @@ import {
   IFileService,
   UploadStreamDescriptorType,
 } from "@medusajs/medusa"
-import { MedusaError } from "medusa-core-utils"
 import { ClientConfiguration, PutObjectRequest } from "aws-sdk/clients/s3"
 
+import { MedusaError } from "medusa-core-utils"
+import aws from "aws-sdk"
+import fs from "fs"
+import { parse } from "path"
+import stream from "stream"
+
 class MinioService extends AbstractFileService implements IFileService {
   protected bucket_: string
   protected accessKeyId_: string
@@ -123,7 +124,7 @@ class MinioService extends AbstractFileService implements IFileService {
       contentType?: string
     }
   ) {
-    const usePrivateBucket = !!fileData.usePrivateBucket
+    const usePrivateBucket = fileData.usePrivateBucket ?? true
 
     this.validatePrivateBucketConfiguration_(usePrivateBucket)