asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(types,utils,promotion): Move from total to original_total to resolve edge case for adjustments calculation (#13106)

Browse Source 
* Move from total to original_total to resolve edge case in adjustment calculation

* Added changeset

* Added test case for correction

---------

Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
This commit is contained in:
scherddel
2025-08-01 12:52:04 +02:00
committed by GitHub
parent b37a87c355
commit 9766570827
5 changed files with 156 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/utils/src/totals/promotion/index.ts
+5 -5
View File
@@ -53,8 +53,8 @@ function getLineItemSubtotal(lineItem) {
return MathBN.div(lineItem.subtotal, lineItem.quantity)
}
function getLineItemTotal(lineItem) {
return MathBN.div(lineItem.total, lineItem.quantity)
function getLineItemOriginalTotal(lineItem) {
return MathBN.div(lineItem.original_total, lineItem.quantity)
}
export function calculateAdjustmentAmountFromPromotion(
@@ -95,7 +95,7 @@ export function calculateAdjustmentAmountFromPromotion(
const lineItemAmount = MathBN.mult(
promotion.is_tax_inclusive
? getLineItemTotal(lineItem)
? getLineItemOriginalTotal(lineItem)
: getLineItemSubtotal(lineItem),
quantity
)
@@ -134,11 +134,11 @@ export function calculateAdjustmentAmountFromPromotion(
*/
const remainingItemAmount = MathBN.sub(
promotion.is_tax_inclusive ? lineItem.total : lineItem.subtotal,
promotion.is_tax_inclusive ? lineItem.original_total : lineItem.subtotal,
promotion.applied_value
)
const itemAmount = MathBN.div(
promotion.is_tax_inclusive ? lineItem.total : lineItem.subtotal,
promotion.is_tax_inclusive ? lineItem.original_total : lineItem.subtotal,
lineItem.quantity
)
const maximumPromotionAmount = MathBN.mult(