From 9851598dae63b12cff4a9fa491981ca72bd0b736 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Frane=20Poli=C4=87?=
 <16856471+fPolic@users.noreply.github.com>
Date: Wed, 16 Apr 2025 09:57:39 +0200
Subject: [PATCH] fix(payment): properly delete refund (#12193)

**What**
- properly delete the refund record if refunding with the provider fails

---

CLOSES SUP-1398
---
 .../payment/src/services/payment-module.ts        | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/packages/modules/payment/src/services/payment-module.ts b/packages/modules/payment/src/services/payment-module.ts
index 8390348371..25202e32d3 100644
--- a/packages/modules/payment/src/services/payment-module.ts
+++ b/packages/modules/payment/src/services/payment-module.ts
@@ -504,11 +504,14 @@ export default class PaymentModuleService
       status !== PaymentSessionStatus.AUTHORIZED &&
       status !== PaymentSessionStatus.CAPTURED
     ) {
-      await this.paymentSessionService_.update({
-        id: session.id,
-        status,
-        data,
-    }, sharedContext);
+      await this.paymentSessionService_.update(
+        {
+          id: session.id,
+          status,
+          data,
+        },
+        sharedContext
+      )
       throw new MedusaError(
         MedusaError.Types.NOT_ALLOWED,
         `Session: ${session.id} was not authorized with the provider.`
@@ -770,7 +773,7 @@ export default class PaymentModuleService
     try {
       await this.refundPaymentFromProvider_(payment, refund, sharedContext)
     } catch (error) {
-      await super.deleteRefunds(data.payment_id, sharedContext)
+      await super.deleteRefunds({ id: refund.id }, sharedContext)
       throw error
     }