asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

feat(core-flows,types,medusa): API to add promotions to campaign (#7277)

Browse Source 
what:

- adds an API to add promotions to campaign
- reworks module to perform atomic actions
This commit is contained in:
Riqwan Thamir
2024-05-10 07:53:56 +00:00
committed by GitHub
parent 489a54e1fb
commit 9a14aeebcf
31 changed files with 1033 additions and 939 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/modules/promotion/integration-tests/__tests__/services/promotion-module/campaign.spec.ts
+71 -97
View File
@@ -152,43 +152,6 @@ moduleIntegrationTestRunner({
})
)
})
it("should create a basic campaign with promotions successfully", async () => {
await createPromotions(MikroOrmWrapper.forkManager())
const startsAt = new Date("01/01/2024")
const endsAt = new Date("01/01/2025")
const [createdCampaign] = await service.createCampaigns([
{
name: "test",
campaign_identifier: "test",
starts_at: startsAt,
ends_at: endsAt,
promotions: [{ id: "promotion-id-1" }, { id: "promotion-id-2" }],
},
])
const campaign = await service.retrieveCampaign(createdCampaign.id, {
relations: ["promotions"],
})
expect(campaign).toEqual(
expect.objectContaining({
name: "test",
campaign_identifier: "test",
starts_at: startsAt,
ends_at: endsAt,
promotions: [
expect.objectContaining({
id: "promotion-id-1",
}),
expect.objectContaining({
id: "promotion-id-2",
}),
],
})
)
})
})
describe("updateCampaigns", () => {
@@ -251,66 +214,6 @@ moduleIntegrationTestRunner({
})
)
})
it("should update promotions of a campaign successfully", async () => {
await createCampaigns(MikroOrmWrapper.forkManager())
await createPromotions(MikroOrmWrapper.forkManager())
const [updatedCampaign] = await service.updateCampaigns([
{
id: "campaign-id-1",
description: "test description 1",
currency: "EUR",
campaign_identifier: "new",
starts_at: new Date("01/01/2024"),
ends_at: new Date("01/01/2025"),
promotions: [{ id: "promotion-id-1" }, { id: "promotion-id-2" }],
},
])
expect(updatedCampaign).toEqual(
expect.objectContaining({
description: "test description 1",
currency: "EUR",
campaign_identifier: "new",
starts_at: new Date("01/01/2024"),
ends_at: new Date("01/01/2025"),
promotions: [
expect.objectContaining({
id: "promotion-id-1",
}),
expect.objectContaining({
id: "promotion-id-2",
}),
],
})
)
})
it("should remove promotions of the campaign successfully", async () => {
await createCampaigns(MikroOrmWrapper.forkManager())
await createPromotions(MikroOrmWrapper.forkManager())
await service.updateCampaigns({
id: "campaign-id-1",
promotions: [{ id: "promotion-id-1" }, { id: "promotion-id-2" }],
})
const updatedCampaign = await service.updateCampaigns({
id: "campaign-id-1",
promotions: [{ id: "promotion-id-1" }],
})
expect(updatedCampaign).toEqual(
expect.objectContaining({
promotions: [
expect.objectContaining({
id: "promotion-id-1",
}),
],
})
)
})
})
describe("retrieveCampaign", () => {
@@ -438,6 +341,77 @@ moduleIntegrationTestRunner({
expect(campaigns).toHaveLength(1)
})
})
describe("addPromotionsToCampaign", () => {
beforeEach(async () => {
await createCampaigns(MikroOrmWrapper.forkManager())
await createPromotions(MikroOrmWrapper.forkManager())
await service.addPromotionsToCampaign({
id,
promotion_ids: ["promotion-id-1"],
})
})
const id = "campaign-id-1"
it("should add promotions to a campaign", async () => {
await service.addPromotionsToCampaign({
id,
promotion_ids: ["promotion-id-2"],
})
const campaign = await service.retrieveCampaign(id, {
relations: ["promotions"],
})
expect(campaign.promotions).toHaveLength(2)
expect(campaign).toEqual(
expect.objectContaining({
id,
promotions: expect.arrayContaining([
expect.objectContaining({ id: "promotion-id-1" }),
expect.objectContaining({ id: "promotion-id-2" }),
]),
})
)
})
})
describe("removePromotionsFromCampaign", () => {
beforeEach(async () => {
await createCampaigns(MikroOrmWrapper.forkManager())
await createPromotions(MikroOrmWrapper.forkManager())
await service.addPromotionsToCampaign({
id,
promotion_ids: ["promotion-id-1", "promotion-id-2"],
})
})
const id = "campaign-id-1"
it("should remove promotions to a campaign", async () => {
await service.removePromotionsFromCampaign({
id,
promotion_ids: ["promotion-id-1"],
})
const campaign = await service.retrieveCampaign(id, {
relations: ["promotions"],
})
expect(campaign.promotions).toHaveLength(1)
expect(campaign).toEqual(
expect.objectContaining({
id,
promotions: expect.arrayContaining([
expect.objectContaining({ id: "promotion-id-2" }),
]),
})
)
})
})
})
},
})
packages/modules/promotion/integration-tests/__tests__/services/promotion-module/compute-actions.spec.ts
+1 -1
View File
@@ -539,7 +539,7 @@ moduleIntegrationTestRunner({
},
])
await service.updateCampaigns({
const updated = await service.updateCampaigns({
id: "campaign-id-2",
budget: { used: 1000 },
})
packages/modules/promotion/integration-tests/__tests__/services/promotion-module/promotion.spec.ts
+3 -1
View File
@@ -6,9 +6,9 @@ import {
CampaignBudgetType,
PromotionType,
} from "@medusajs/utils"
import { moduleIntegrationTestRunner, SuiteOptions } from "medusa-test-utils"
import { createCampaigns } from "../../../__fixtures__/campaigns"
import { createPromotions } from "../../../__fixtures__/promotion"
import { moduleIntegrationTestRunner, SuiteOptions } from "medusa-test-utils"
jest.setTimeout(30000)
@@ -918,6 +918,7 @@ moduleIntegrationTestRunner({
{
id: "promotion-id-1",
code: "PROMOTION_1",
campaign_id: null,
campaign: null,
is_automatic: false,
type: "standard",
@@ -929,6 +930,7 @@ moduleIntegrationTestRunner({
{
id: "promotion-id-2",
code: "PROMOTION_2",
campaign_id: null,
campaign: null,
is_automatic: false,
type: "standard",