From 9a34e03ae17b40b895e5ce2b45bf8fb241021a0b Mon Sep 17 00:00:00 2001
From: Shahed Nasser <shahednasser@gmail.com>
Date: Tue, 3 Sep 2024 13:46:00 +0300
Subject: [PATCH] fix(medusa): fix complete order API route to remove duplicate
 params (#8961)

Remove the `order_id` request body param from the complete order API route and use the `id` path parameter instead.
---
 packages/medusa/src/api/admin/orders/[id]/complete/route.ts | 5 ++---
 packages/medusa/src/api/admin/orders/validators.ts          | 6 +-----
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/packages/medusa/src/api/admin/orders/[id]/complete/route.ts b/packages/medusa/src/api/admin/orders/[id]/complete/route.ts
index 1b83626faf..0f64ec681f 100644
--- a/packages/medusa/src/api/admin/orders/[id]/complete/route.ts
+++ b/packages/medusa/src/api/admin/orders/[id]/complete/route.ts
@@ -8,10 +8,9 @@ import {
   AuthenticatedMedusaRequest,
   MedusaResponse,
 } from "../../../../../types/routing"
-import { AdminCompleteOrderType } from "../../validators"
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<AdminCompleteOrderType & AdditionalData>,
+  req: AuthenticatedMedusaRequest<AdditionalData>,
   res: MedusaResponse<HttpTypes.AdminOrderResponse>
 ) => {
   const remoteQuery = req.scope.resolve(ContainerRegistrationKeys.REMOTE_QUERY)
@@ -19,7 +18,7 @@ export const POST = async (
 
   await completeOrderWorkflow(req.scope).run({
     input: {
-      orderIds: [req.validatedBody.order_id],
+      orderIds: [id],
       additional_data: req.validatedBody.additional_data,
     },
   })
diff --git a/packages/medusa/src/api/admin/orders/validators.ts b/packages/medusa/src/api/admin/orders/validators.ts
index 44f0e82319..9705c7756f 100644
--- a/packages/medusa/src/api/admin/orders/validators.ts
+++ b/packages/medusa/src/api/admin/orders/validators.ts
@@ -52,11 +52,7 @@ export const AdminArchiveOrder = z.object({
 })
 export type AdminArchiveOrderType = z.infer<typeof AdminArchiveOrder>
 
-export type AdminCompleteOrderType = z.infer<typeof CompleteOrder>
-export const CompleteOrder = z.object({
-  order_id: z.string(),
-})
-export const AdminCompleteOrder = WithAdditionalData(CompleteOrder)
+export const AdminCompleteOrder = WithAdditionalData(z.object({}))
 
 const Item = z.object({
   id: z.string(),