fix: failing integration tests

This commit is contained in:
Sebastian Rindom
2021-10-15 19:14:44 +02:00
parent 1a37b27ca0
commit 9c72acda40
4 changed files with 28 additions and 11 deletions
@@ -19,12 +19,12 @@ Object {
"mid_code": null, "mid_code": null,
"options": Array [ "options": Array [
Object { Object {
"created_at": "2021-10-13T08:02:41.668Z", "created_at": Any<String>,
"deleted_at": null, "deleted_at": null,
"id": "test-variant-option", "id": "test-variant-option",
"metadata": null, "metadata": null,
"option_id": "test-option", "option_id": "test-option",
"updated_at": "2021-10-13T08:02:41.668Z", "updated_at": Any<String>,
"value": "Default variant", "value": "Default variant",
"variant_id": "test-variant", "variant_id": "test-variant",
}, },
@@ -75,12 +75,12 @@ Object {
"mid_code": null, "mid_code": null,
"options": Array [ "options": Array [
Object { Object {
"created_at": "2021-10-13T08:02:41.493Z", "created_at": Any<String>,
"deleted_at": null, "deleted_at": null,
"id": "test-variant-option", "id": "test-variant-option",
"metadata": null, "metadata": null,
"option_id": "test-option", "option_id": "test-option",
"updated_at": "2021-10-13T08:02:41.493Z", "updated_at": Any<String>,
"value": "Default variant", "value": "Default variant",
"variant_id": "test-variant", "variant_id": "test-variant",
}, },
@@ -65,6 +65,12 @@ describe("/store/variants", () => {
updated_at: expect.any(String), updated_at: expect.any(String),
weight: null, weight: null,
width: null, width: null,
options: [
{
created_at: expect.any(String),
updated_at: expect.any(String),
},
],
prices: [ prices: [
{ {
created_at: expect.any(String), created_at: expect.any(String),
@@ -113,6 +119,12 @@ describe("/store/variants", () => {
updated_at: expect.any(String), updated_at: expect.any(String),
weight: null, weight: null,
width: null, width: null,
options: [
{
created_at: expect.any(String),
updated_at: expect.any(String),
},
],
prices: [ prices: [
{ {
created_at: expect.any(String), created_at: expect.any(String),
@@ -66,9 +66,9 @@ export default async (req, res) => {
try { try {
const customerService = req.scope.resolve("customerService") const customerService = req.scope.resolve("customerService")
let customer = await customerService.update(id, value) await customerService.update(id, value)
customer = await customerService.retrieve(customer.id, { const customer = await customerService.retrieve(id, {
relations: defaultRelations, relations: defaultRelations,
select: defaultFields, select: defaultFields,
}) })
+10 -5
View File
@@ -224,7 +224,6 @@ class CustomerService extends BaseService {
const query = this.buildQuery_({ id: validatedId }, config) const query = this.buildQuery_({ id: validatedId }, config)
const customer = await customerRepo.findOne(query) const customer = await customerRepo.findOne(query)
if (!customer) { if (!customer) {
throw new MedusaError( throw new MedusaError(
MedusaError.Types.NOT_FOUND, MedusaError.Types.NOT_FOUND,
@@ -286,7 +285,7 @@ class CustomerService extends BaseService {
/** /**
* Hashes a password * Hashes a password
* @param {string} password - the value to hash * @param {string} password - the value to hash
* @return {string} hashed password * @return {Promise<string>} hashed password
*/ */
async hashPassword_(password) { async hashPassword_(password) {
const buf = await Scrypt.kdf(password, { logN: 1, r: 1, p: 1 }) const buf = await Scrypt.kdf(password, { logN: 1, r: 1, p: 1 })
@@ -371,7 +370,14 @@ class CustomerService extends BaseService {
const customer = await this.retrieve(customerId) const customer = await this.retrieve(customerId)
const { email, password, metadata, ...rest } = update const {
email,
password,
metadata,
billing_address,
billing_address_id,
...rest
} = update
if (metadata) { if (metadata) {
customer.metadata = this.setMetadata_(customer, metadata) customer.metadata = this.setMetadata_(customer, metadata)
@@ -381,7 +387,7 @@ class CustomerService extends BaseService {
customer.email = this.validateEmail_(email) customer.email = this.validateEmail_(email)
} }
if ("billing_address_id" in update || "billing_address" in update) { if (billing_address_id || billing_address) {
const address = update.billing_address_id || update.billing_address const address = update.billing_address_id || update.billing_address
await this.updateBillingAddress_(customer, address, addrRepo) await this.updateBillingAddress_(customer, address, addrRepo)
} }
@@ -421,7 +427,6 @@ class CustomerService extends BaseService {
if (addressOrId.id) { if (addressOrId.id) {
customer.billing_address_id = addressOrId.id customer.billing_address_id = addressOrId.id
customer.billing_address = addressOrId
} else { } else {
if (customer.billing_address_id) { if (customer.billing_address_id) {
const addr = await addrRepo.findOne({ const addr = await addrRepo.findOne({