chore(feature-flags): Remove OrderEditing feature flag (#3006)

packages/medusa/src/api/routes/admin/order-edits/__tests__/cancel-order-edit.ts

@@ -1,6 +1,5 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
 
 describe("POST /admin/order-edits/:id/cancel", () => {
@@ -17,8 +16,7 @@ describe("POST /admin/order-edits/:id/cancel", () => {
             jwt: {
               userId: IdMap.getId("admin_user"),
             },
-          },
-          flags: [OrderEditingFeatureFlag],
+          }
         }
       )
     })

packages/medusa/src/api/routes/admin/order-edits/__tests__/confirm-order-edit.ts

@@ -1,6 +1,5 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
 
 describe("POST /admin/order-edits/:id/confirm", () => {
@@ -18,7 +17,6 @@ describe("POST /admin/order-edits/:id/confirm", () => {
               userId: "admin_user",
             },
           },
-          flags: [OrderEditingFeatureFlag],
         }
       )
     })

packages/medusa/src/api/routes/admin/order-edits/__tests__/create-order-edit.ts

@@ -1,6 +1,5 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
 
 describe("POST /admin/order-edits", () => {
@@ -20,7 +19,6 @@ describe("POST /admin/order-edits", () => {
             userId: IdMap.getId("admin_user"),
           },
         },
-        flags: [OrderEditingFeatureFlag],
       })
     })
 

packages/medusa/src/api/routes/admin/order-edits/__tests__/delete-line-item.ts

@@ -1,6 +1,5 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
 
 describe("DELETE /admin/order-edits/:id/items/:item_id", () => {
@@ -16,7 +15,6 @@ describe("DELETE /admin/order-edits/:id/items/:item_id", () => {
             userId: IdMap.getId("admin_user"),
           },
         },
-        flags: [OrderEditingFeatureFlag],
       })
     })
 

packages/medusa/src/api/routes/admin/order-edits/__tests__/delete-order-edit-item-change.ts

@@ -1,6 +1,5 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
 
 describe("DELETE /admin/order-edits/:id/changes/:change_id", () => {
@@ -19,7 +18,6 @@ describe("DELETE /admin/order-edits/:id/changes/:change_id", () => {
               userId: IdMap.getId("admin_user"),
             },
           },
-          flags: [OrderEditingFeatureFlag],
         }
       )
     })

packages/medusa/src/api/routes/admin/order-edits/__tests__/delete-order-edit.ts

@@ -1,6 +1,5 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
 
 describe("DELETE /admin/order-edits/:id", () => {
@@ -15,7 +14,6 @@ describe("DELETE /admin/order-edits/:id", () => {
             userId: IdMap.getId("admin_user"),
           },
         },
-        flags: [OrderEditingFeatureFlag],
       })
     })
 

packages/medusa/src/api/routes/admin/order-edits/__tests__/get-order.ts

@@ -1,10 +1,9 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import {
   defaultOrderEditFields,
-  defaultOrderEditRelations,
+  defaultOrderEditRelations
 } from "../../../../../types/order-edit"
 
 describe("GET /admin/order-edits/:id", () => {
@@ -19,7 +18,6 @@ describe("GET /admin/order-edits/:id", () => {
             userId: IdMap.getId("admin_user"),
           },
         },
-        flags: [OrderEditingFeatureFlag],
       })
     })
 

packages/medusa/src/api/routes/admin/order-edits/__tests__/list-order-edit.ts

@@ -1,10 +1,9 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import {
   defaultOrderEditFields,
-  defaultOrderEditRelations,
+  defaultOrderEditRelations
 } from "../../../../../types/order-edit"
 
 describe("GET /admin/order-edits", () => {
@@ -18,7 +17,6 @@ describe("GET /admin/order-edits", () => {
             userId: IdMap.getId("admin_user"),
           },
         },
-        flags: [OrderEditingFeatureFlag],
       })
     })
 

packages/medusa/src/api/routes/admin/order-edits/__tests__/request-confirmation.ts

@@ -2,7 +2,6 @@ import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
 
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 
 describe("GET /admin/order-edits/:id", () => {
   describe("successfully requests an order edit confirmation", () => {
@@ -19,7 +18,6 @@ describe("GET /admin/order-edits/:id", () => {
               userId: IdMap.getId("admin_user"),
             },
           },
-          flags: [OrderEditingFeatureFlag],
           payload: {
             payment_collection_description: "PayCol description",
           },

packages/medusa/src/api/routes/admin/order-edits/__tests__/update-order-edit-line-item.ts

@@ -1,6 +1,5 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
 
 describe("POST /admin/order-edits/:id/items/:item_id", () => {
@@ -22,7 +21,6 @@ describe("POST /admin/order-edits/:id/items/:item_id", () => {
               userId: IdMap.getId("admin_user"),
             },
           },
-          flags: [OrderEditingFeatureFlag],
         }
       )
     })

packages/medusa/src/api/routes/admin/order-edits/index.ts

@@ -1,33 +1,27 @@
 import { Router } from "express"
 
-import middlewares, {
-  transformBody,
-  transformQuery,
-} from "../../../middlewares"
+import { OrderEdit } from "../../../../models"
 import { DeleteResponse, PaginatedResponse } from "../../../../types/common"
-import { isFeatureFlagEnabled } from "../../../middlewares/feature-flag-enabled"
-import OrderEditingFeatureFlag from "../../../../loaders/feature-flags/order-editing"
 import {
   defaultOrderEditFields,
   defaultOrderEditRelations,
 } from "../../../../types/order-edit"
-import { OrderEdit } from "../../../../models"
-import { AdminPostOrderEditsOrderEditReq } from "./update-order-edit"
-import { AdminPostOrderEditsReq } from "./create-order-edit"
+import middlewares, {
+  transformBody,
+  transformQuery,
+} from "../../../middlewares"
 import { AdminPostOrderEditsEditLineItemsReq } from "./add-line-item"
-import { AdminPostOrderEditsEditLineItemsLineItemReq } from "./update-order-edit-line-item"
-import { GetOrderEditsParams } from "./list-order-edit"
+import { AdminPostOrderEditsReq } from "./create-order-edit"
 import { GetOrderEditsOrderEditParams } from "./get-order-edit"
+import { GetOrderEditsParams } from "./list-order-edit"
 import { AdminPostOrderEditsRequestConfirmationReq } from "./request-confirmation"
+import { AdminPostOrderEditsOrderEditReq } from "./update-order-edit"
+import { AdminPostOrderEditsEditLineItemsLineItemReq } from "./update-order-edit-line-item"
 
 const route = Router()
 
 export default (app) => {
-  app.use(
-    "/order-edits",
-    isFeatureFlagEnabled(OrderEditingFeatureFlag.key),
-    route
-  )
+  app.use("/order-edits", route)
 
   route.post(
     "/",
@@ -117,10 +111,10 @@ export type AdminOrderEditItemChangeDeleteRes = {
   deleted: boolean
 }
 
-export * from "./update-order-edit"
-export * from "./update-order-edit-line-item"
+export * from "./add-line-item"
 export * from "./create-order-edit"
 export * from "./get-order-edit"
 export * from "./list-order-edit"
-export * from "./add-line-item"
 export * from "./request-confirmation"
+export * from "./update-order-edit"
+export * from "./update-order-edit-line-item"

packages/medusa/src/api/routes/admin/payment-collections/index.ts

@@ -4,21 +4,15 @@ import middlewares, {
   transformBody,
   transformQuery,
 } from "../../../middlewares"
-import OrderEditingFeatureFlag from "../../../../loaders/feature-flags/order-editing"
-import { isFeatureFlagEnabled } from "../../../middlewares/feature-flag-enabled"
 
+import { PaymentCollection } from "../../../../models"
 import { GetPaymentCollectionsParams } from "./get-payment-collection"
 import { AdminUpdatePaymentCollectionsReq } from "./update-payment-collection"
-import { PaymentCollection } from "../../../../models"
 
 const route = Router()
 
 export default (app, container) => {
-  app.use(
-    "/payment-collections",
-    isFeatureFlagEnabled(OrderEditingFeatureFlag.key),
-    route
-  )
+  app.use("/payment-collections", route)
 
   route.get(
     "/:id",

packages/medusa/src/api/routes/admin/payments/index.ts

@@ -4,17 +4,15 @@ import middlewares, {
   transformBody,
   transformQuery,
 } from "../../../middlewares"
-import OrderEditingFeatureFlag from "../../../../loaders/feature-flags/order-editing"
-import { isFeatureFlagEnabled } from "../../../middlewares/feature-flag-enabled"
 
+import { Payment, Refund } from "../../../../models"
 import { GetPaymentsParams } from "./get-payment"
 import { AdminPostPaymentRefundsReq } from "./refund-payment"
-import { Payment, Refund } from "../../../../models"
 
 const route = Router()
 
 export default (app, container) => {
-  app.use("/payments", isFeatureFlagEnabled(OrderEditingFeatureFlag.key), route)
+  app.use("/payments", route)
 
   route.get(
     "/:id",

packages/medusa/src/api/routes/store/order-edits/__tests__/complete-order-edit.ts

@@ -1,7 +1,6 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 
 describe("GET /store/order-edits/:id/complete", () => {
   describe("successfully complete an order edit", () => {
@@ -12,9 +11,6 @@ describe("GET /store/order-edits/:id/complete", () => {
       subject = await request(
         "POST",
         `/store/order-edits/${orderEditId}/complete`,
-        {
-          flags: [OrderEditingFeatureFlag],
-        }
       )
     })
 
@@ -44,7 +40,6 @@ describe("GET /store/order-edits/:id/complete", () => {
         "POST",
         `/store/order-edits/${orderEditId}/complete`,
         {
-          flags: [OrderEditingFeatureFlag],
           clientSession: {
             jwt: {
               user: IdMap.getId("lebron"),

packages/medusa/src/api/routes/store/order-edits/__tests__/decline-order-edit.ts

@@ -1,7 +1,6 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 
 describe("GET /store/order-edits/:id/decline", () => {
   describe("successfully decline an order edit", () => {
@@ -18,7 +17,6 @@ describe("GET /store/order-edits/:id/decline", () => {
         `/store/order-edits/${orderEditId}/decline`,
         {
           payload,
-          flags: [OrderEditingFeatureFlag],
         }
       )
     })

packages/medusa/src/api/routes/store/order-edits/__tests__/get-order.ts

@@ -1,10 +1,9 @@
 import { IdMap } from "medusa-test-utils"
 import { request } from "../../../../../helpers/test-request"
 import { orderEditServiceMock } from "../../../../../services/__mocks__/order-edit"
-import OrderEditingFeatureFlag from "../../../../../loaders/feature-flags/order-editing"
 import {
   defaultStoreOrderEditFields,
-  defaultStoreOrderEditRelations,
+  defaultStoreOrderEditRelations
 } from "../../../../../types/order-edit"
 
 describe("GET /store/order-edits/:id", () => {
@@ -13,9 +12,7 @@ describe("GET /store/order-edits/:id", () => {
     let subject
 
     beforeAll(async () => {
-      subject = await request("GET", `/store/order-edits/${orderEditId}`, {
-        flags: [OrderEditingFeatureFlag],
-      })
+      subject = await request("GET", `/store/order-edits/${orderEditId}`)
     })
 
     afterAll(() => {

packages/medusa/src/api/routes/store/order-edits/index.ts

@@ -1,26 +1,20 @@
 import { Router } from "express"
-import middlewares, {
-  transformBody,
-  transformQuery,
-} from "../../../middlewares"
+import { OrderEdit } from "../../../../models"
 import { FindParams } from "../../../../types/common"
-import { isFeatureFlagEnabled } from "../../../middlewares/feature-flag-enabled"
-import OrderEditingFeatureFlag from "../../../../loaders/feature-flags/order-editing"
 import {
   defaultStoreOrderEditFields,
   defaultStoreOrderEditRelations,
 } from "../../../../types/order-edit"
-import { OrderEdit } from "../../../../models"
+import middlewares, {
+  transformBody,
+  transformQuery,
+} from "../../../middlewares"
 import { StorePostOrderEditsOrderEditDecline } from "./decline-order-edit"
 
 const route = Router()
 
 export default (app) => {
-  app.use(
-    "/order-edits",
-    isFeatureFlagEnabled(OrderEditingFeatureFlag.key),
-    route
-  )
+  app.use("/order-edits", route)
 
   route.get(
     "/:id",

packages/medusa/src/api/routes/store/payment-collections/index.ts

@@ -5,23 +5,16 @@ import middlewares, {
   transformQuery,
 } from "../../../middlewares"
 
-import OrderEditingFeatureFlag from "../../../../loaders/feature-flags/order-editing"
-import { isFeatureFlagEnabled } from "../../../middlewares/feature-flag-enabled"
-
-import { StorePostPaymentCollectionsBatchSessionsReq } from "./manage-batch-payment-sessions"
-import { GetPaymentCollectionsParams } from "./get-payment-collection"
 import { PaymentCollection, PaymentSession } from "../../../../models"
-import { StorePaymentCollectionSessionsReq } from "./manage-payment-session"
 import { StorePostPaymentCollectionsBatchSessionsAuthorizeReq } from "./authorize-batch-payment-sessions"
+import { GetPaymentCollectionsParams } from "./get-payment-collection"
+import { StorePostPaymentCollectionsBatchSessionsReq } from "./manage-batch-payment-sessions"
+import { StorePaymentCollectionSessionsReq } from "./manage-payment-session"
 
 const route = Router()
 
 export default (app, container) => {
-  app.use(
-    "/payment-collections",
-    isFeatureFlagEnabled(OrderEditingFeatureFlag.key),
-    route
-  )
+  app.use("/payment-collections", route)
 
   route.get(
     "/:id",
@@ -86,8 +79,8 @@ export type StorePaymentCollectionsSessionRes = {
   payment_session: PaymentSession
 }
 
-export * from "./get-payment-collection"
-export * from "./manage-payment-session"
-export * from "./manage-batch-payment-sessions"
-export * from "./refresh-payment-session"
 export * from "./authorize-batch-payment-sessions"
+export * from "./get-payment-collection"
+export * from "./manage-batch-payment-sessions"
+export * from "./manage-payment-session"
+export * from "./refresh-payment-session"