From a16eaad6c97e1233bd30142adf314065d322af50 Mon Sep 17 00:00:00 2001
From: RONY GEDEON YEBADOKPO <49495160+Gederooney@users.noreply.github.com>
Date: Wed, 29 Jan 2025 08:30:18 -0500
Subject: [PATCH] fix(create-medusa-app): --db-url keep asking db credentials
 (#11037)

* fix create-medusa-app db-url error

* removed empty lines

* changeset
---
 .changeset/chatty-badgers-visit.md                  |  5 +++++
 .../cli/create-medusa-app/src/utils/create-db.ts    | 13 +++++++------
 2 files changed, 12 insertions(+), 6 deletions(-)
 create mode 100644 .changeset/chatty-badgers-visit.md

diff --git a/.changeset/chatty-badgers-visit.md b/.changeset/chatty-badgers-visit.md
new file mode 100644
index 0000000000..89306f0c03
--- /dev/null
+++ b/.changeset/chatty-badgers-visit.md
@@ -0,0 +1,5 @@
+---
+"create-medusa-app": patch
+---
+
+Fix issue where create-medusa-app repeatedly asked for database credentials even when --db-url was specified. The logic in MedusaProjectCreator->create()->initializeProject()->setupDatabase() always defines a dbName. Updated the getDbClientAndCredentials() method to check db-url first
diff --git a/packages/cli/create-medusa-app/src/utils/create-db.ts b/packages/cli/create-medusa-app/src/utils/create-db.ts
index 097d9521f1..38ad7de6ca 100644
--- a/packages/cli/create-medusa-app/src/utils/create-db.ts
+++ b/packages/cli/create-medusa-app/src/utils/create-db.ts
@@ -226,15 +226,16 @@ export async function getDbClientAndCredentials({
   verbose?: boolean
   dbName?: string
 }> {
-  if (dbName) {
-    return await getForDbName({
-      dbName,
-      verbose,
-    })
-  } else {
+  // Check the db-url first, because the dbName is always defined in MedusaProjectCreator->create()->initializeProject()->setupDatabase()
+  if (dbUrl) {
     return await getForDbUrl({
       dbUrl,
       verbose,
     })
+  } else {
+    return await getForDbName({
+      dbName,
+      verbose,
+    })
   }
 }