asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(product, types, workflows): Update product variant workflow (#5668)

Browse Source 
**What**
- Fix issues with update-variant workflow: 
  - other variants than the updated variant are no longer removed 
  - options are updated properly


Co-authored-by: Riqwan Thamir <5105988+riqwan@users.noreply.github.com>
This commit is contained in:
Philip Korsholm
2023-11-23 14:35:01 +00:00
committed by GitHub
co-authored by Riqwan Thamir
parent b25b29fe7b
commit a39ce125cc
16 changed files with 617 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-tests/plugins/__tests__/product/admin/update-product-variant.spec.ts
+234 -4
View File
@@ -1,5 +1,3 @@
import { useApi } from "../../../../environment-helpers/use-api"
import { getContainer } from "../../../../environment-helpers/use-container"
import { initDb, useDb } from "../../../../environment-helpers/use-db"
import {
simpleProductFactory,
@@ -7,11 +5,13 @@ import {
} from "../../../../factories"
import { AxiosInstance } from "axios"
import path from "path"
import { startBootstrapApp } from "../../../../environment-helpers/bootstrap-app"
import adminSeeder from "../../../../helpers/admin-seeder"
import { createDefaultRuleTypes } from "../../../helpers/create-default-rule-types"
import { createVariantPriceSet } from "../../../helpers/create-variant-price-set"
import { getContainer } from "../../../../environment-helpers/use-container"
import path from "path"
import { startBootstrapApp } from "../../../../environment-helpers/bootstrap-app"
import { useApi } from "../../../../environment-helpers/use-api"
jest.setTimeout(50000)
@@ -62,6 +62,9 @@ describe("POST /admin/products/:id/variants/:id", () => {
{
options: [{ option_id: "test-product-option-1", value: "test" }],
},
{
options: [{ option_id: "test-product-option-1", value: "test 2" }],
},
],
options: [
{
@@ -250,4 +253,231 @@ describe("POST /admin/products/:id/variants/:id", () => {
})
)
})
it("should update variant option value", async () => {
const api = useApi()! as AxiosInstance
const data = {
options: [
{
option_id: "test-product-option-1",
value: "updated",
},
],
}
await api.post(
`/admin/products/${product.id}/variants/${variant.id}`,
data,
adminHeaders
)
const response = await api.get(
`/admin/products/${product.id}`,
adminHeaders
)
expect(response.status).toEqual(200)
expect(response.data.product).toEqual(
expect.objectContaining({
id: expect.any(String),
variants: expect.arrayContaining([
expect.objectContaining({
id: variant.id,
options: [
expect.objectContaining({
option_id: "test-product-option-1",
value: "updated",
}),
],
}),
expect.objectContaining({
id: product.variants[1].id,
options: [
expect.objectContaining({
option_id: "test-product-option-1",
value: "test 2",
}),
],
}),
]),
})
)
})
it("should update variant metadata", async () => {
const api = useApi()! as AxiosInstance
const data = {
metadata: {
test: "string",
},
}
await api.post(
`/admin/products/${product.id}/variants/${variant.id}`,
data,
adminHeaders
)
const response = await api.get(
`/admin/products/${product.id}`,
adminHeaders
)
expect(response.status).toEqual(200)
expect(response.data.product).toEqual(
expect.objectContaining({
id: expect.any(String),
variants: expect.arrayContaining([
expect.objectContaining({
id: variant.id,
metadata: {
test: "string",
},
}),
]),
})
)
})
it("should remove options not present in update", async () => {
const api = useApi()! as AxiosInstance
product = await simpleProductFactory(dbConnection, {
id: "test-product-with-multiple-options",
variants: [
{
options: [
{ option_id: "test-product-multi-option-1", value: "test" },
{ option_id: "test-product-multi-option-2", value: "test value" },
],
},
],
options: [
{
id: "test-product-multi-option-1",
title: "Test option 1",
},
{
id: "test-product-multi-option-2",
title: "Test option 2",
},
],
})
variant = product.variants[0]
const data = {
options: [
{
option_id: "test-product-multi-option-1",
value: "updated",
},
],
}
await api.post(
`/admin/products/${product.id}/variants/${variant.id}`,
data,
adminHeaders
)
const response = await api.get(
`/admin/products/${product.id}`,
adminHeaders
)
expect(response.status).toEqual(200)
expect(response.data.product).toEqual(
expect.objectContaining({
id: expect.any(String),
variants: [
expect.objectContaining({
id: variant.id,
options: [
expect.objectContaining({
option_id: "test-product-multi-option-1",
value: "updated",
}),
],
}),
],
})
)
})
it("should update several options in the same api call", async () => {
const api = useApi()! as AxiosInstance
product = await simpleProductFactory(dbConnection, {
id: "test-product-with-multiple-options",
variants: [
{
options: [
{ option_id: "test-product-multi-option-1", value: "test" },
{ option_id: "test-product-multi-option-2", value: "test value" },
],
},
],
options: [
{
id: "test-product-multi-option-1",
title: "Test option 1",
},
{
id: "test-product-multi-option-2",
title: "Test option 2",
},
],
})
variant = product.variants[0]
const data = {
options: [
{
option_id: "test-product-multi-option-1",
value: "updated",
},
{
option_id: "test-product-multi-option-2",
value: "updated 2",
},
],
}
await api.post(
`/admin/products/${product.id}/variants/${variant.id}`,
data,
adminHeaders
)
const response = await api.get(
`/admin/products/${product.id}`,
adminHeaders
)
expect(response.status).toEqual(200)
expect(response.data.product).toEqual(
expect.objectContaining({
id: expect.any(String),
variants: [
expect.objectContaining({
id: variant.id,
options: [
expect.objectContaining({
option_id: "test-product-multi-option-1",
value: "updated",
}),
expect.objectContaining({
option_id: "test-product-multi-option-2",
value: "updated 2",
}),
],
}),
],
})
)
})
})