asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore(util): avoid promotion value precision limit (#13145)

Browse Source
This commit is contained in:
Carlos R. L. Rodrigues
2025-08-06 15:49:10 -03:00
committed by GitHub
parent b1cba9fdeb
commit a52708769d
3 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/utils/src/totals/math.ts
View File

@@ -3,6 +3,10 @@ import { BigNumber as BigNumberJS } from "bignumber.js"
import { isDefined } from "../common"
import { BigNumber } from "./big-number"
export const MEDUSA_EPSILON = new BigNumber(
process.env.MEDUSA_EPSILON || "0.0001"
)
type BNInput = BigNumberInput | BigNumber
export class MathBN {
static convert(num: BNInput, decimalPlaces?: number): BigNumberJS {

18
packages/core/utils/src/totals/promotion/index.ts
View File

@@ -3,13 +3,10 @@ import {
ApplicationMethodAllocation,
ApplicationMethodType,
} from "../../promotion"
import { MathBN } from "../math"
import { MathBN, MEDUSA_EPSILON } from "../math"
function getPromotionValueForPercentage(promotion, lineItemAmount) {
return MathBN.convert(
MathBN.mult(MathBN.div(promotion.value, 100), lineItemAmount),
2
)
return MathBN.mult(MathBN.div(promotion.value, 100), lineItemAmount)
}
function getPromotionValueForFixed(promotion, lineItemAmount, lineItemsAmount) {
@@ -28,10 +25,7 @@ function getPromotionValueForFixed(promotion, lineItemAmount, lineItemsAmount) {
promotionValueForItem
)
return MathBN.convert(
MathBN.mult(promotionValueForItem, MathBN.div(percentage, 100)),
2
)
return MathBN.mult(promotionValueForItem, MathBN.div(percentage, 100))
}
return promotion.value
}
@@ -104,8 +98,8 @@ export function calculateAdjustmentAmountFromPromotion(
)
const applicableAmount = MathBN.sub(lineItemAmount, promotion.applied_value)
if (MathBN.lte(applicableAmount, 0)) {
return applicableAmount
if (MathBN.lte(applicableAmount, MEDUSA_EPSILON)) {
return MathBN.convert(0)
}
const promotionValue = getPromotionValue(
@@ -153,7 +147,7 @@ export function calculateAdjustmentAmountFromPromotion(
maximumPromotionAmount
)
if (MathBN.lte(applicableAmount, 0)) {
if (MathBN.lte(applicableAmount, MEDUSA_EPSILON)) {
return MathBN.convert(0)
}