From a53ae1e29b53e08e7885f663a5bff5cfa193d338 Mon Sep 17 00:00:00 2001 From: pepijn-vanvlaanderen Date: Wed, 6 Dec 2023 15:10:56 +0700 Subject: [PATCH] feat(medusa): Replace Node Redis with ioredis (#5656) * Replaced Node Redis with ioredis * Update express.ts --- .changeset/wicked-crews-joke.md | 5 +++++ packages/medusa/package.json | 1 - packages/medusa/src/loaders/express.ts | 7 +++++-- yarn.lock | 1 - 4 files changed, 10 insertions(+), 4 deletions(-) create mode 100644 .changeset/wicked-crews-joke.md diff --git a/.changeset/wicked-crews-joke.md b/.changeset/wicked-crews-joke.md new file mode 100644 index 0000000000..c40c83dd44 --- /dev/null +++ b/.changeset/wicked-crews-joke.md @@ -0,0 +1,5 @@ +--- +"@medusajs/medusa": minor +--- + +Replaced Node Redis with ioredis diff --git a/packages/medusa/package.json b/packages/medusa/package.json index 9d1ea94ed6..db7e098ec7 100644 --- a/packages/medusa/package.json +++ b/packages/medusa/package.json @@ -91,7 +91,6 @@ "pg": "^8.11.2", "qs": "^6.11.2", "randomatic": "^3.1.1", - "redis": "^3.0.2", "reflect-metadata": "^0.1.13", "regenerator-runtime": "^0.13.11", "request-ip": "^3.3.0", diff --git a/packages/medusa/src/loaders/express.ts b/packages/medusa/src/loaders/express.ts index 0fb701b0d3..cd68d6ea94 100644 --- a/packages/medusa/src/loaders/express.ts +++ b/packages/medusa/src/loaders/express.ts @@ -3,7 +3,7 @@ import cookieParser from "cookie-parser" import { Express } from "express" import session from "express-session" import morgan from "morgan" -import redis from "redis" +import Redis from "ioredis" import { ConfigModule } from "../types/global" type Options = { @@ -40,7 +40,10 @@ export default async ({ app, configModule }: Options): Promise => { if (configModule?.projectConfig?.redis_url) { const RedisStore = createStore(session) - const redisClient = redis.createClient(configModule.projectConfig.redis_url) + const redisClient = new Redis( + configModule.projectConfig.redis_url, + configModule.projectConfig.redis_options ?? {} + ) sessionOpts.store = new RedisStore({ client: redisClient, prefix: `${configModule?.projectConfig?.redis_prefix ?? ""}sess:`, diff --git a/yarn.lock b/yarn.lock index b28f4bd5b4..7da8f24a49 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7739,7 +7739,6 @@ __metadata: pg: ^8.11.2 qs: ^6.11.2 randomatic: ^3.1.1 - redis: ^3.0.2 reflect-metadata: ^0.1.13 regenerator-runtime: ^0.13.11 request-ip: ^3.3.0