fix: Add some tests and test cleanup for product module (#6586)

This commit is contained in:
Stevche Radevski
2024-03-05 17:18:46 +01:00
committed by GitHub
parent e5dc918be5
commit a6736c7ee0
16 changed files with 710 additions and 801 deletions
@@ -8,7 +8,6 @@ import {
} from "@medusajs/core-flows"
import { UpdateProductDTO } from "@medusajs/types"
import { defaultAdminProductsOptionFields } from "../../../query-config"
import { remoteQueryObjectFromString } from "@medusajs/utils"
export const GET = async (
@@ -26,7 +25,7 @@ export const GET = async (
const queryObject = remoteQueryObjectFromString({
entryPoint: "product_option",
variables,
fields: defaultAdminProductsOptionFields,
fields: req.retrieveConfig.select as string[],
})
const [product_option] = await remoteQuery(queryObject)
@@ -5,7 +5,6 @@ import {
import { CreateProductOptionDTO } from "@medusajs/types"
import { createProductOptionsWorkflow } from "@medusajs/core-flows"
import { defaultAdminProductsOptionFields } from "../../query-config"
import { remoteQueryObjectFromString } from "@medusajs/utils"
export const GET = async (
@@ -23,7 +22,7 @@ export const GET = async (
skip: req.listConfig.skip,
take: req.listConfig.take,
},
fields: defaultAdminProductsOptionFields,
fields: req.listConfig.select as string[],
})
const { rows: product_options, metadata } = await remoteQuery(queryObject)
@@ -8,7 +8,6 @@ import {
} from "@medusajs/core-flows"
import { UpdateProductDTO } from "@medusajs/types"
import { defaultAdminProductFields } from "../query-config"
import { remoteQueryObjectFromString } from "@medusajs/utils"
export const GET = async (
@@ -22,7 +21,7 @@ export const GET = async (
const queryObject = remoteQueryObjectFromString({
entryPoint: "product",
variables,
fields: defaultAdminProductFields,
fields: req.retrieveConfig.select as string[],
})
const [product] = await remoteQuery(queryObject)
@@ -26,7 +26,7 @@ export const GET = async (
const queryObject = remoteQueryObjectFromString({
entryPoint: "product_variant",
variables,
fields: defaultAdminProductsVariantFields,
fields: req.retrieveConfig.select as string[],
})
const [product_variant] = await remoteQuery(queryObject)
@@ -5,7 +5,6 @@ import {
import { CreateProductVariantDTO } from "@medusajs/types"
import { createProductVariantsWorkflow } from "@medusajs/core-flows"
import { defaultAdminProductsVariantFields } from "../../query-config"
import { remoteQueryObjectFromString } from "@medusajs/utils"
export const GET = async (
@@ -23,7 +22,7 @@ export const GET = async (
skip: req.listConfig.skip,
take: req.listConfig.take,
},
fields: defaultAdminProductsVariantFields,
fields: req.listConfig.select as string[],
})
const { rows: product_variants, metadata } = await remoteQuery(queryObject)
@@ -68,7 +68,7 @@ export const adminProductRoutesMiddlewares: MiddlewareRoute[] = [
middlewares: [
transformQuery(
AdminGetProductsVariantsParams,
QueryConfig.retrieveTransformQueryConfig
QueryConfig.listVariantConfig
),
],
},
@@ -79,7 +79,7 @@ export const adminProductRoutesMiddlewares: MiddlewareRoute[] = [
middlewares: [
transformQuery(
AdminGetProductsProductVariantsVariantParams,
QueryConfig.retrieveTransformQueryConfig
QueryConfig.retrieveVariantConfig
),
],
},
@@ -106,7 +106,7 @@ export const adminProductRoutesMiddlewares: MiddlewareRoute[] = [
middlewares: [
transformQuery(
AdminGetProductsOptionsParams,
QueryConfig.retrieveTransformQueryConfig
QueryConfig.listOptionConfig
),
],
},
@@ -117,7 +117,7 @@ export const adminProductRoutesMiddlewares: MiddlewareRoute[] = [
middlewares: [
transformQuery(
AdminGetProductsProductOptionsOptionParams,
QueryConfig.retrieveTransformQueryConfig
QueryConfig.retrieveOptionConfig
),
],
},
@@ -1,4 +1,4 @@
export const defaultAdminProductRelations = [
export const allowedAdminProductRelations = [
"variants",
// TODO: Add in next iteration
// "variants.prices",
@@ -15,7 +15,7 @@ export const defaultAdminProductRelations = [
// "type",
// "collection",
]
export const allowedAdminProductRelations = [...defaultAdminProductRelations]
export const defaultAdminProductRelations = []
export const defaultAdminProductFields = [
"id",
"title",
@@ -52,6 +52,7 @@ export const retrieveTransformQueryConfig = {
}
export const listTransformQueryConfig = {
...retrieveTransformQueryConfig,
defaultLimit: 50,
isList: true,
}
@@ -82,4 +83,30 @@ export const defaultAdminProductsVariantFields = [
"barcode",
]
export const retrieveVariantConfig = {
defaultFields: defaultAdminProductsVariantFields,
defaultRelations: [],
allowedRelations: [],
isList: false,
}
export const listVariantConfig = {
...retrieveVariantConfig,
defaultLimit: 50,
isList: true,
}
export const defaultAdminProductsOptionFields = ["id", "title"]
export const retrieveOptionConfig = {
defaultFields: defaultAdminProductsOptionFields,
defaultRelations: [],
allowedRelations: [],
isList: false,
}
export const listOptionConfig = {
...retrieveVariantConfig,
defaultLimit: 50,
isList: true,
}
@@ -5,7 +5,6 @@ import {
import { CreateProductDTO } from "@medusajs/types"
import { createProductsWorkflow } from "@medusajs/core-flows"
import { defaultAdminProductFields } from "./query-config"
import { remoteQueryObjectFromString } from "@medusajs/utils"
export const GET = async (
@@ -22,7 +21,7 @@ export const GET = async (
skip: req.listConfig.skip,
take: req.listConfig.take,
},
fields: defaultAdminProductFields,
fields: req.listConfig.select as string[],
})
const { rows: products, metadata } = await remoteQuery(queryObject)