fix: make packages/medusa/src/api/routes/admin/return-reasons pass eslint (#654)

.eslintignore

@@ -28,7 +28,6 @@
 /packages/medusa/src/api/routes/admin/collections
 /packages/medusa/src/api/routes/admin/notes
 /packages/medusa/src/api/routes/admin/orders
-/packages/medusa/src/api/routes/admin/return-reasons
 /packages/medusa/src/api/routes/admin/returns
 /packages/medusa/src/api/routes/admin/shipping-profiles
 /packages/medusa/src/api/routes/admin/store

packages/medusa/src/api/routes/admin/return-reasons/create-reason.js

@@ -40,9 +40,7 @@ export default async (req, res) => {
     value: Validator.string().required(),
     label: Validator.string().required(),
     parent_return_reason_id: Validator.string().optional(),
-    description: Validator.string()
+    description: Validator.string().optional().allow(""),
-      .optional()
-      .allow(""),
     metadata: Validator.object().optional(),
   })
 
@@ -51,17 +49,13 @@ export default async (req, res) => {
     throw new MedusaError(MedusaError.Types.INVALID_DATA, error.details)
   }
 
-  try {
+  const returnReasonService = req.scope.resolve("returnReasonService")
-    const returnReasonService = req.scope.resolve("returnReasonService")
+  const result = await returnReasonService.create(value)
-    const result = await returnReasonService.create(value)
 
-    const reason = await returnReasonService.retrieve(result.id, {
+  const reason = await returnReasonService.retrieve(result.id, {
-      select: defaultFields,
+    select: defaultFields,
-      relations: defaultRelations,
+    relations: defaultRelations,
-    })
+  })
 
-    res.status(200).json({ return_reason: reason })
+  res.status(200).json({ return_reason: reason })
-  } catch (err) {
-    throw err
-  }
 }

packages/medusa/src/api/routes/admin/return-reasons/delete-reason.js

@@ -26,16 +26,12 @@
 export default async (req, res) => {
   const { id } = req.params
 
-  try {
+  const returnReasonService = req.scope.resolve("returnReasonService")
-    const returnReasonService = req.scope.resolve("returnReasonService")
+  await returnReasonService.delete(id)
-    await returnReasonService.delete(id)
 
-    res.json({
+  res.json({
-      id: id,
+    id: id,
-      object: "return_reason",
+    object: "return_reason",
-      deleted: true,
+    deleted: true,
-    })
+  })
-  } catch (err) {
-    throw err
-  }
 }

packages/medusa/src/api/routes/admin/return-reasons/get-reason.js

@@ -1,4 +1,3 @@
-import { MedusaError, Validator } from "medusa-core-utils"
 import { defaultRelations, defaultFields } from "./"
 
 /**
@@ -22,16 +21,12 @@ import { defaultRelations, defaultFields } from "./"
  */
 export default async (req, res) => {
   const { id } = req.params
-  try {
+  const returnReasonService = req.scope.resolve("returnReasonService")
-    const returnReasonService = req.scope.resolve("returnReasonService")
 
-    const data = await returnReasonService.retrieve(id, {
+  const data = await returnReasonService.retrieve(id, {
-      select: defaultFields,
+    select: defaultFields,
-      relations: defaultRelations,
+    relations: defaultRelations,
-    })
+  })
 
-    res.status(200).json({ return_reason: data })
+  res.status(200).json({ return_reason: data })
-  } catch (err) {
-    throw err
-  }
 }

packages/medusa/src/api/routes/admin/return-reasons/index.js

@@ -3,7 +3,7 @@ import middlewares from "../../../middlewares"
 
 const route = Router()
 
-export default app => {
+export default (app) => {
   app.use("/return-reasons", route)
 
   /**

packages/medusa/src/api/routes/admin/return-reasons/list-reasons.js

@@ -1,4 +1,3 @@
-import { MedusaError, Validator } from "medusa-core-utils"
 import { defaultRelations, defaultFields } from "./"
 
 /**
@@ -21,17 +20,13 @@ import { defaultRelations, defaultFields } from "./"
  *                 $ref: "#/components/schemas/return_reason"
  */
 export default async (req, res) => {
-  try {
+  const returnReasonService = req.scope.resolve("returnReasonService")
-    const returnReasonService = req.scope.resolve("returnReasonService")
 
-    const query = { parent_return_reason_id: null }
+  const query = { parent_return_reason_id: null }
-    const data = await returnReasonService.list(query, {
+  const data = await returnReasonService.list(query, {
-      select: defaultFields,
+    select: defaultFields,
-      relations: defaultRelations,
+    relations: defaultRelations,
-    })
+  })
 
-    res.status(200).json({ return_reasons: data })
+  res.status(200).json({ return_reasons: data })
-  } catch (err) {
-    throw err
-  }
 }

packages/medusa/src/api/routes/admin/return-reasons/update-reason.js

@@ -43,9 +43,7 @@ export default async (req, res) => {
   const schema = Validator.object().keys({
     label: Validator.string().optional(),
     parent_return_reason_id: Validator.string().optional(),
-    description: Validator.string()
+    description: Validator.string().optional().allow(""),
-      .optional()
-      .allow(""),
     metadata: Validator.object().optional(),
   })
 
@@ -54,18 +52,14 @@ export default async (req, res) => {
     throw new MedusaError(MedusaError.Types.INVALID_DATA, error.details)
   }
 
-  try {
+  const returnReasonService = req.scope.resolve("returnReasonService")
-    const returnReasonService = req.scope.resolve("returnReasonService")
 
-    await returnReasonService.update(id, value)
+  await returnReasonService.update(id, value)
 
-    const reason = await returnReasonService.retrieve(id, {
+  const reason = await returnReasonService.retrieve(id, {
-      select: defaultFields,
+    select: defaultFields,
-      relations: defaultRelations,
+    relations: defaultRelations,
-    })
+  })
 
-    res.status(200).json({ return_reason: reason })
+  res.status(200).json({ return_reason: reason })
-  } catch (err) {
-    throw err
-  }
 }